mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-18 03:01:00 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
31 lines
1.1 KiB
JavaScript
31 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Color Change', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should change the user\'s type when struck by a move', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Kecleon", ability: 'colorchange', moves: ['recover']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Paras", ability: 'damp', moves: ['absorb']}]});
|
|
const ccMon = battle.p1.active[0];
|
|
battle.makeChoices('move Recover', 'move Absorb');
|
|
assert(ccMon.hasType('Grass'));
|
|
});
|
|
|
|
it('should not change the user\'s type if it had a Substitute when hit', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Kecleon", ability: 'colorchange', moves: ['substitute']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Machamp", ability: 'purepower', item: 'laggingtail', moves: ['closecombat']}]});
|
|
const ccMon = battle.p1.active[0];
|
|
battle.makeChoices('move Substitute', 'move Closecombat');
|
|
assert.false(ccMon.hasType('Fighting'));
|
|
});
|
|
});
|