mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-20 14:08:15 -05:00
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
55 lines
2.0 KiB
JavaScript
55 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Sitrus Berry', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should heal 25% hp when consumed', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Aggron', ability: 'sturdy', item: 'sitrusberry', moves: ['sleeptalk']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Lucario', ability: 'adaptability', moves: ['aurasphere']}]});
|
|
const holder = battle.p1.active[0];
|
|
battle.makeChoices('move sleeptalk', 'move aurasphere');
|
|
assert.false.holdsItem(holder);
|
|
assert.equal(holder.hp, Math.floor(holder.maxhp / 4) + 1);
|
|
});
|
|
|
|
it('should be eaten immediately if (re)gained on low hp', function () {
|
|
battle = common.createBattle([
|
|
[{species: 'Magnemite', ability: 'sturdy', item: 'sitrusberry', moves: ['recycle']}],
|
|
[{species: 'Garchomp', ability: 'roughskin', moves: ['earthquake']}],
|
|
]);
|
|
const holder = battle.p1.active[0];
|
|
const hpgain = Math.floor(holder.maxhp / 4);
|
|
battle.makeChoices('move recycle', 'move earthquake');
|
|
assert.false.holdsItem(holder);
|
|
assert.equal(holder.hp, hpgain + hpgain + 1);
|
|
});
|
|
|
|
it('should not heal if Knocked Off', function () {
|
|
battle = common.createBattle([
|
|
[{species: 'Deoxys-Attack', ability: 'sturdy', item: 'sitrusberry', moves: ['sleeptalk']}],
|
|
[{species: 'Krookodile', ability: 'intimidate', moves: ['knockoff']}],
|
|
]);
|
|
battle.makeChoices('move sleeptalk', 'move knockoff');
|
|
assert.equal(battle.p1.active[0].hp, 1);
|
|
});
|
|
|
|
it.skip('should not heal 25% hp if a confusion self-hit triggers the healing', function () {
|
|
battle = common.createBattle([
|
|
[{species: 'Deoxys-Attack', ability: 'pressure', item: 'sitrusberry', moves: ['sleeptalk']}],
|
|
[{species: 'Sableye', ability: 'prankster', moves: ['confuseray']}],
|
|
]);
|
|
const holder = battle.p1.active[0];
|
|
battle.makeChoices('move sleeptalk', 'move confuseray');
|
|
assert.holdsItem(holder);
|
|
assert.false.equal(holder.hp, holder.maxhp);
|
|
});
|
|
});
|