mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-19 21:48:23 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
67 lines
3.3 KiB
JavaScript
67 lines
3.3 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Protective Pads', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should prevent ability-changing abilities triggered by contact from acting', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Cofagrigus", ability: 'mummy', moves: ['calmmind']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Hariyama", ability: 'thickfat', item: 'protectivepads', moves: ['bulletpunch']}]});
|
|
const attacker = battle.p2.active[0];
|
|
battle.makeChoices();
|
|
assert.equal(attacker.ability, 'thickfat');
|
|
const mummyActivationMessages = battle.log.filter(logStr => logStr.startsWith('|-activate|') && logStr.includes('Mummy'));
|
|
assert.equal(mummyActivationMessages.length, 1, "Mummy should activate only once");
|
|
assert(mummyActivationMessages[0].includes('Cofagrigus'), "Source of Mummy activation should be included");
|
|
assert.false(mummyActivationMessages[0].includes('Thick Fat'), "Attacker's ability should not be revealed");
|
|
});
|
|
|
|
it('should prevent damaging abilities triggered by contact from acting', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Purrloin", ability: 'prankster', item: 'protectivepads', moves: ['scratch']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Ferrothorn", ability: 'ironbarbs', moves: ['rest']}]});
|
|
battle.makeChoices();
|
|
assert.fullHP(battle.p1.active[0], "Attacker should not be hurt");
|
|
});
|
|
|
|
it('should prevent stat stage-changing abilities triggered by contact from acting', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Purrloin", ability: 'prankster', item: 'protectivepads', moves: ['scratch']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Goodra", ability: 'gooey', moves: ['rest']}]});
|
|
battle.makeChoices();
|
|
assert.statStage(battle.p1.active[0], 'spe', 0, "Speed should not be lowered");
|
|
});
|
|
|
|
it('should not stop Pickpocket', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Weavile", ability: 'pickpocket', moves: ['swordsdance']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Liepard", ability: 'prankster', item: 'protectivepads', moves: ['scratch']}]});
|
|
battle.makeChoices();
|
|
assert.false(battle.p2.active[0].item, "Attacker should lose their item");
|
|
assert.equal(battle.p1.active[0].item, 'protectivepads', "Target should receive stolen item");
|
|
});
|
|
|
|
it('should prevent item effects triggered by contact from acting', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Purrloin", ability: 'prankster', item: 'protectivepads', moves: ['scratch']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Cacnea", ability: 'waterabsorb', item: 'rockyhelmet', moves: ['synthesis']}]});
|
|
battle.makeChoices();
|
|
assert.fullHP(battle.p1.active[0], "Attacker should not be hurt");
|
|
});
|
|
|
|
it('should not activate on the opponent\'s moves', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Hariyama", ability: 'guts', item: 'protectivepads', moves: ['rest']}]});
|
|
battle.setPlayer('p2', {team: [{species: "Galvantula", ability: 'swarm', moves: ['lunge']}]});
|
|
battle.makeChoices();
|
|
assert.statStage(battle.p1.active[0], 'atk', -1, "Attack should be lowered");
|
|
});
|
|
});
|