9b3e433bc7
The following sequence of events was causing a crash: 1) User sends in decision to server (with the wrong rqid specified). 2) Server receives decision and sends message M to simulator process. 3) User leaves battle and sends the server a message to inform of this. 4) Server removes the user from his or her battle in the main process, which sets the user's entry in simulator.player to null. 5) The simulator process processes message M and, since the rqid in the decision is wrong, send a resendrequest message back to the main process. 6) The main process in resendRequest() tries to access properties of the player, which are now null as of event (4), causing a crash. This commit fixes the problem by making sure that user is not null before accessing its properties. |
||
|---|---|---|
| config | ||
| data | ||
| logs | ||
| mods | ||
| .gitignore | ||
| app.js | ||
| battles.js | ||
| chat-commands.js | ||
| doc.txt | ||
| LICENSE | ||
| old-doc.txt | ||
| package.json | ||
| Procfile | ||
| README.md | ||
| rooms.js | ||
| simulator.js | ||
| tools.js | ||
| users.js | ||
| verifier.js | ||
Pokemon Showdown
Pokemon Showdown is a simulator of Pokemon battles. It currently supports singles battles in Generations 4-5 (HGSS, BW, BW2).
Installing
Pokemon Showdown requires Node.js and npm (which is installed by default with Node.js since v0.6.3).
Run npm install to install all necessary dependencies.
Copy config/config-example.js into config/config.js, and edit as you please.
After this, start Node:
cd <location of PS>
node app.js
You can also specify a port:
node app.js 8000
Visit your server at http://play.pokemonshowdown.com/~~SERVER:PORT/
Replace SERVER with your server domain or IP, and PORT with the server's port. You can leave off :PORT if it is 8000 (the default).
Yes, you can test even if you are behind a NAT without port forwarding: http://play.pokemonshowdown.com/~~localhost/ will connect to your local machine. Some browser setups might prevent this sort of connection, however (NoScript, for instance). If you can't get connecting locally to work in Firefox, try Chrome.
The reason your server is visited through play.pokemonshowdown.com is to make it more difficult for servers to see a user's password in any form, by handling logins globally. I realize that you might want your own login server and client hosted outside the pokemonshowdown.com domain, and I'll look more deeply into how to facilitate that when we're closer to leaving beta.
Browser support
Showdown currently supports, in order of preference:
- Chrome
- Firefox
- Safari
- Chrome/Firefox/Safari for various mobile devices
- Opera
- Firefox for Android
- IE9+
IE8 support can technically be added without too much difficulty, but it doesn't run PS fast enough to be usable.
As for older browsers (Firefox 3.6), I won't go out of my way to support them, but if there's a simple fix, you can suggest it to me and I'll implement it.
License
Pokemon Showdown's server is distributed under the terms of the MIT License.
Credits
Pokemon Showdown was created by Guangcong Luo [Zarel].
Developers
- Guangcong Luo [Zarel]
- Bill Meltsner [bmelts]
Contributors
- [The Immortal]
- [Marty-D]
- Cody Thompson [Rising_Dusk]