mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-03-21 17:25:10 -05:00
78439b4a02
ESLint has a whole new config format, so I figure it's a good time to make the config system saner. - First, we no longer have separate eslint-no-types configs. Lint performance shouldn't be enough of a problem to justify the relevant maintenance complexity. - Second, our base config should work out-of-the-box now. `npx eslint` will work as expected, without any CLI flags. You should still use `npm run lint` which adds the `--cached` flag for performance. - Third, whatever updates I did fixed style linting, which apparently has been bugged for quite some time, considering all the obvious mixed-tabs-and-spaces issues I found in the upgrade. Also here are some changes to our style rules. In particular: - Curly brackets (for objects etc) now have spaces inside them. Sorry for the huge change. ESLint doesn't support our old style, and most projects use Prettier style, so we might as well match them in this way. See https://github.com/eslint-stylistic/eslint-stylistic/issues/415 - String + number concatenation is no longer allowed. We now consistently use template strings for this.
81 lines
2.3 KiB
YAML
81 lines
2.3 KiB
YAML
# This workflow will do an install of node dependencies, build the source code and run tests across different versions of node
|
|
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
|
|
|
|
name: Node.js CI
|
|
|
|
on:
|
|
push:
|
|
branches: [ master ]
|
|
pull_request:
|
|
branches: [ master ]
|
|
workflow_call:
|
|
|
|
jobs:
|
|
build:
|
|
|
|
runs-on: ubuntu-latest
|
|
|
|
strategy:
|
|
matrix:
|
|
node-version: [18.x]
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
with:
|
|
fetch-depth: 100 # assumes PR/push to master is no larger than 100 commits. Other solutions are needlessly complex.
|
|
|
|
- name: Use Node.js ${{ matrix.node-version }}
|
|
uses: actions/setup-node@v3
|
|
with:
|
|
node-version: ${{ matrix.node-version }}
|
|
cache: 'npm'
|
|
|
|
- run: npm ci
|
|
|
|
- name: Determine which files to lint (if pull request)
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
id: changed-files
|
|
uses: tj-actions/changed-files@v35
|
|
with:
|
|
files: |
|
|
./config/*.ts
|
|
./data/**/*.ts
|
|
./lib/*.ts
|
|
./server/**/*.ts
|
|
./server/**/*.tsx
|
|
./sim/**/*.ts
|
|
./tools/set-import/*.ts
|
|
files_ignore: |
|
|
./logs/
|
|
./node_modules/
|
|
./dist/
|
|
./data/**/learnsets.ts
|
|
./tools/set-import/importer.js
|
|
./tools/set-import/sets
|
|
./tools/modlog/converter.js
|
|
./server/global-variables.d.ts
|
|
|
|
- name: Determine whether test/sim or test/random-battles need to run (if pull request)
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
id: changed-directories
|
|
uses: tj-actions/changed-files@v35
|
|
with:
|
|
files: |
|
|
config/formats.ts
|
|
data/**
|
|
sim/**
|
|
|
|
- name: Run selective lint & neccessary tests (if pull request)
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
run: npm run full-test-ci
|
|
env:
|
|
CI: true
|
|
FILES: ${{ steps.changed-files.outputs.all_changed_and_modified_files }}
|
|
SKIPSIMTESTS: ${{ steps.changed-directories.outputs.all_changed_and_modified_files == '' }}
|
|
|
|
- name: Run full lint & test (if push to master)
|
|
run: npm run full-test
|
|
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
|
|
env:
|
|
CI: true
|