mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-06 05:27:54 -05:00
697c7c5eb9
The `let` hack is completely and utterly intentional.
Declare variables in the scope they're used in. There is no reason to
remove the let hack unless you want bad code to pass. I do not want
bad code to pass.
This reverts commit 0b76e245b6.
124 lines
3.1 KiB
JavaScript
124 lines
3.1 KiB
JavaScript
var gulp = require('gulp');
|
|
var jshintStylish = require('jshint-stylish');
|
|
var gutil = require('gulp-util'); // Currently unused, but gulp strongly suggested I install...
|
|
var jshint = require('gulp-jshint');
|
|
var jscs = require('gulp-jscs');
|
|
var replace = require('gulp-replace');
|
|
|
|
var jsHintOptions = {
|
|
"nonbsp": true,
|
|
"nonew": true,
|
|
"noarg": true,
|
|
"loopfunc": true,
|
|
"latedef": 'nofunc',
|
|
|
|
"freeze": true,
|
|
"immed": true,
|
|
"undef": true,
|
|
|
|
// style
|
|
"smarttabs": true,
|
|
"trailing": true,
|
|
"newcap": true,
|
|
|
|
"sub": true,
|
|
"evil": true,
|
|
"esnext": true,
|
|
"node": true,
|
|
"eqeqeq": true,
|
|
|
|
"globals": {
|
|
"Config": false,
|
|
"ResourceMonitor": false,
|
|
"toId": false,
|
|
"toName": false,
|
|
"string": false,
|
|
"LoginServer": false,
|
|
"Users": false,
|
|
"Rooms": false,
|
|
"Verifier": false,
|
|
"CommandParser": false,
|
|
"Simulator": false,
|
|
"Tournaments": false,
|
|
"Dnsbl": false,
|
|
"Cidr": false,
|
|
"Sockets": false,
|
|
"Tools": false,
|
|
"TeamValidator": false
|
|
}
|
|
};
|
|
|
|
var jscsOptions = {
|
|
"excludeFiles": ["./**/pokedex.js", "./**/formats-data.js", "./**/learnsets.js", "./**/learnsets-g6.js", "./config/config.js"],
|
|
|
|
"preset": "google",
|
|
|
|
"requireCurlyBraces": null,
|
|
"requireCamelCaseOrUpperCaseIdentifiers": null,
|
|
"maximumLineLength": null,
|
|
"validateIndentation": "\t",
|
|
"validateQuoteMarks": null,
|
|
|
|
"disallowMixedSpacesAndTabs": "smart",
|
|
"disallowMultipleVarDecl": null,
|
|
|
|
"requireSpaceAfterKeywords": true,
|
|
"requireSpaceBeforeBinaryOperators": true,
|
|
"disallowSpacesInAnonymousFunctionExpression": null,
|
|
"requireSpacesInAnonymousFunctionExpression": {
|
|
"beforeOpeningRoundBrace": true
|
|
},
|
|
|
|
"validateJSDoc": null,
|
|
|
|
"requireBlocksOnNewline": 1,
|
|
"disallowPaddingNewlinesInBlocks": true,
|
|
"disallowEmptyBlocks": true,
|
|
"disallowNewlineBeforeBlockStatements": true,
|
|
|
|
"requireCommaBeforeLineBreak": true,
|
|
"requireOperatorBeforeLineBreak": true,
|
|
|
|
"disallowSpaceAfterObjectKeys": true,
|
|
"disallowSpaceAfterPrefixUnaryOperators": true,
|
|
"disallowSpaceBeforePostfixUnaryOperators": true,
|
|
|
|
"disallowTrailingComma": true,
|
|
"validateLineBreaks": require('os').EOL.replace(/\r/g, 'CR').replace(/\n/g, 'LF'),
|
|
"validateParameterSeparator": ", ",
|
|
|
|
"requireCapitalizedConstructors": true
|
|
};
|
|
|
|
gulp.task('data', function () {
|
|
var directories = ['./data/*.js', './mods/*/*.js'];
|
|
jsHintOptions['es3'] = true;
|
|
|
|
// Replacing `var` with `let` is sort of a hack that stops jsHint from
|
|
// complaining that I'm using `var` like `let` should be used, but
|
|
// without having to deal with iffy `let` support.
|
|
|
|
return gulp.src(directories)
|
|
.pipe(jscs(jscsOptions))
|
|
.pipe(replace(/\bvar\b/g, 'let'))
|
|
.pipe(jshint(jsHintOptions))
|
|
.pipe(jshint.reporter(jshintStylish))
|
|
.pipe(jshint.reporter('fail'))
|
|
.pipe(jscs(jscsOptions));
|
|
});
|
|
|
|
gulp.task('fastlint', function () {
|
|
var directories = ['./*.js', './tournaments/*.js', './chat-plugins/*.js', './config/*.js'];
|
|
delete jsHintOptions['es3'];
|
|
|
|
return gulp.src(directories)
|
|
.pipe(jscs(jscsOptions))
|
|
.pipe(replace(/\bvar\b/g, 'let'))
|
|
.pipe(jshint(jsHintOptions))
|
|
.pipe(jshint.reporter(jshintStylish))
|
|
.pipe(jshint.reporter('fail'));
|
|
});
|
|
|
|
gulp.task('default', ['fastlint', 'data']);
|
|
gulp.task('lint', ['fastlint', 'data']);
|