mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-05-16 09:26:48 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
46 lines
1.3 KiB
JavaScript
46 lines
1.3 KiB
JavaScript
/**
|
|
* Tests for the Help room auto-answerer.
|
|
* Written by Mia.
|
|
* @author mia-pi-git
|
|
*/
|
|
|
|
'use strict';
|
|
const assert = require('assert').strict;
|
|
const Responder = require('../../../.server-dist/chat-plugins/help').HelpResponder;
|
|
const Help = new Responder({
|
|
stats: {},
|
|
pairs: {},
|
|
disabled: false,
|
|
queue: [],
|
|
});
|
|
|
|
describe('Help', function () {
|
|
it('should only return true on added regexes', function () {
|
|
Help.data.pairs.catra = [];
|
|
Help.data.pairs.catra.push(Help.stringRegex(`Hey & Adora`));
|
|
assert(Help.match('Hey, Adora', 'catra'));
|
|
assert(!Help.match('Hello, Adora', 'catra'));
|
|
});
|
|
|
|
it('should produce valid regexes', function () {
|
|
const regexString = Help.stringRegex(`uwu & awa`);
|
|
assert.equal(regexString, "(?=.*?(uwu))(?=.*?(awa))");
|
|
const regex = new RegExp(regexString);
|
|
assert(regex.test('uwu awa'));
|
|
});
|
|
it('should handle |, &, and ! correctly', function () {
|
|
const and = new RegExp(Help.stringRegex(`Horde & Prime`));
|
|
assert(and.test('Horde Prime'));
|
|
assert(!and.test('Horde'));
|
|
|
|
const or = new RegExp(Help.stringRegex(`she-ra|sea-ra`));
|
|
assert(or.test('sea-ra'));
|
|
assert(or.test(`she-ra`));
|
|
assert(!or.test('ADVENTURE'));
|
|
|
|
const ignore = new RegExp(Help.stringRegex(`!Hordak`));
|
|
assert(ignore.test(`FOR THE HONOR OF GREYSKULL`));
|
|
assert(!ignore.test('Hordak'));
|
|
});
|
|
});
|