mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-08-05 18:51:40 -05:00
78439b4a02
ESLint has a whole new config format, so I figure it's a good time to make the config system saner. - First, we no longer have separate eslint-no-types configs. Lint performance shouldn't be enough of a problem to justify the relevant maintenance complexity. - Second, our base config should work out-of-the-box now. `npx eslint` will work as expected, without any CLI flags. You should still use `npm run lint` which adds the `--cached` flag for performance. - Third, whatever updates I did fixed style linting, which apparently has been bugged for quite some time, considering all the obvious mixed-tabs-and-spaces issues I found in the upgrade. Also here are some changes to our style rules. In particular: - Curly brackets (for objects etc) now have spaces inside them. Sorry for the huge change. ESLint doesn't support our old style, and most projects use Prettier style, so we might as well match them in this way. See https://github.com/eslint-stylistic/eslint-stylistic/issues/415 - String + number concatenation is no longer allowed. We now consistently use template strings for this.
379 lines
16 KiB
JavaScript
379 lines
16 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Target Resolution', () => {
|
|
afterEach(() => {
|
|
battle.destroy();
|
|
});
|
|
|
|
describe(`Targetted Pokémon fainted in-turn`, () => {
|
|
it(`should redirect 'any' from a fainted foe to a targettable foe`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Wailord', item: 'laggingtail', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Metapod', ability: 'shedskin', moves: ['harden'] },
|
|
], [
|
|
{ species: 'Chansey', ability: 'naturalcure', moves: ['curse'] },
|
|
{ species: 'Latias', ability: 'levitate', moves: ['healingwish'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
]]);
|
|
const defender = battle.p2.active[0];
|
|
assert.hurts(defender, () => battle.makeChoices('move watergun 2, auto', 'auto'));
|
|
});
|
|
|
|
it(`should not redirect 'any' from a fainted ally to another Pokémon by default`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Wailord', item: 'laggingtail', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Latias', ability: 'levitate', moves: ['healingwish'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
], [
|
|
{ species: 'Chansey', ability: 'naturalcure', moves: ['curse'] },
|
|
{ species: 'Metapod', ability: 'shedskin', moves: ['harden'] },
|
|
]]);
|
|
const activePokemonList = [battle.p1.active[0], ...battle.p2.active];
|
|
const prevHps = activePokemonList.map(pokemon => pokemon.hp);
|
|
battle.makeChoices('move watergun -2, auto', 'auto');
|
|
const newHps = activePokemonList.map(pokemon => pokemon.hp);
|
|
|
|
assert.deepEqual(prevHps, newHps);
|
|
assert(battle.log.includes('|move|p1a: Wailord|Water Gun|p1: Latias|[notarget]'));
|
|
assert(battle.log.includes('|-fail|p1a: Wailord'));
|
|
});
|
|
|
|
it(`should support RedirectTarget event for a fainted foe and type 'any' `, () => {
|
|
battle = common.gen(5).createBattle({ gameType: 'triples' }, [[
|
|
{ species: 'Wailord', item: 'laggingtail', ability: 'pressure', moves: ['waterpulse'] }, // Water Pulse over Water Gun due to targeting in triples
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
], [
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['curse'] },
|
|
{ species: 'Latias', ability: 'levitate', moves: ['healingwish'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
]]);
|
|
let redirector = battle.p2.active[0];
|
|
battle.makeChoices('move waterpulse 2, auto', 'auto');
|
|
assert.statStage(redirector, 'spa', 1);
|
|
|
|
// Do it again with swapped positions
|
|
battle.destroy();
|
|
battle = common.gen(5).createBattle({ gameType: 'triples' }, [[
|
|
{ species: 'Wailord', item: 'laggingtail', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
], [
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
{ species: 'Latias', ability: 'levitate', moves: ['healingwish'] },
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['curse'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
]]);
|
|
redirector = battle.p2.active[2];
|
|
battle.makeChoices('move watergun 2, auto', 'auto');
|
|
assert.statStage(redirector, 'spa', 1);
|
|
|
|
// Test Storm Drain on the user's side
|
|
battle.destroy();
|
|
battle = common.gen(5).createBattle({ gameType: 'triples' }, [[
|
|
{ species: 'Shuckle', moves: ['watergun'] },
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['swordsdance'] },
|
|
{ species: 'Magikarp', moves: ['swordsdance'] },
|
|
], [
|
|
{ species: 'Beartic', moves: ['swordsdance'] },
|
|
{ species: 'Magikarp', moves: ['swordsdance'] },
|
|
{ species: 'Victini', moves: ['finalgambit'] },
|
|
]]);
|
|
redirector = battle.p1.active[1];
|
|
battle.makeChoices('move watergun 3, auto', 'move swordsdance, move swordsdance, move finalgambit -2');
|
|
assert.statStage(redirector, 'spa', 1);
|
|
});
|
|
|
|
it(`should not redirect non-pulse/flying moves in Triples if the Pokemon is out of range`, () => {
|
|
battle = common.gen(6).createBattle({ gameType: 'triples' }, [[
|
|
{ species: 'Shuckle', moves: ['watergun'] },
|
|
{ species: 'Magikarp', moves: ['swordsdance'] },
|
|
{ species: 'Magikarp', moves: ['swordsdance'] },
|
|
], [
|
|
{ species: 'Beartic', moves: ['swordsdance'] },
|
|
{ species: 'Magikarp', moves: ['swordsdance'] },
|
|
{ species: 'Victini', moves: ['finalgambit'] },
|
|
]]);
|
|
battle.makeChoices('move watergun 3, auto', 'move swordsdance, move swordsdance, move finalgambit -2');
|
|
assert.fullHP(battle.p2.active[0], `Beartic should not be damaged by a Water Gun because it is out of range`);
|
|
});
|
|
|
|
it(`should support RedirectTarget event for a fainted ally and type 'any'`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Wailord', item: 'laggingtail', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Latias', ability: 'levitate', moves: ['healingwish'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
], [
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['curse'] },
|
|
{ species: 'Metapod', ability: 'shedskin', moves: ['harden'] },
|
|
]]);
|
|
const redirector = battle.p2.active[0];
|
|
battle.makeChoices('move watergun -2, auto', 'auto');
|
|
assert.statStage(redirector, 'spa', 1);
|
|
});
|
|
|
|
it(`should not redirect to another random target if the intended one is fainted in FFA`, () => {
|
|
battle = common.createBattle({ gameType: 'freeforall' }, [[
|
|
{ species: 'Calyrex', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Victini', ability: 'Victory Star', moves: ['vcreate'] },
|
|
], [
|
|
{ species: 'Chansey', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Tyrunt', moves: ['crunch'] },
|
|
]]);
|
|
battle.makeChoices('auto', 'move vcreate 1', 'auto', 'move crunch 1');
|
|
assert.fainted(battle.sides[0].active[0]);
|
|
assert.fullHP(battle.sides[1].active[0]);
|
|
assert.fullHP(battle.sides[2].active[0]);
|
|
});
|
|
});
|
|
|
|
describe(`Targetted slot is empty`, () => {
|
|
it(`should redirect 'any' from a fainted foe to a targettable foe`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Wailord', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Shedinja', item: 'flameorb', ability: 'wonderguard', moves: ['agility'] },
|
|
], [
|
|
{ species: 'Wailord', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Shedinja', item: 'flameorb', ability: 'wonderguard', moves: ['agility'] },
|
|
]]);
|
|
const attackers = battle.sides.map(side => side.active[0]);
|
|
|
|
battle.makeChoices('auto', 'auto'); // Shedinjas burned
|
|
battle.makeChoices('auto', 'auto'); // Shedinjas faint
|
|
|
|
const prevHps = attackers.map(pokemon => pokemon.hp);
|
|
battle.makeChoices('move watergun 2, pass', 'move watergun 2, pass');
|
|
const newHps = attackers.map(pokemon => pokemon.hp);
|
|
|
|
assert(
|
|
newHps[0] < prevHps[0] && newHps[1] < prevHps[1],
|
|
`It should redirect the attacks from their original fainted targets to valid targets`
|
|
);
|
|
});
|
|
|
|
it(`should not redirect 'any' from a fainted ally to another Pokémon by default`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Wailord', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Shedinja', item: 'flameorb', ability: 'wonderguard', moves: ['agility'] },
|
|
], [
|
|
{ species: 'Wailord', ability: 'pressure', moves: ['watergun'] },
|
|
{ species: 'Shedinja', item: 'flameorb', ability: 'wonderguard', moves: ['agility'] },
|
|
]]);
|
|
|
|
const attackers = battle.sides.map(side => side.active[0]);
|
|
const faintTargets = battle.sides.map(side => side.active[1]);
|
|
|
|
battle.makeChoices('auto', 'auto'); // Shedinjas burned
|
|
battle.makeChoices('auto', 'auto'); // Shedinjas faint
|
|
assert.fainted(faintTargets[0]);
|
|
assert.fainted(faintTargets[1]);
|
|
|
|
const prevHps = attackers.map(pokemon => pokemon.hp);
|
|
battle.makeChoices('move watergun -2, pass', 'move watergun -2, pass');
|
|
const newHps = attackers.map(pokemon => pokemon.hp);
|
|
|
|
assert.deepEqual(prevHps, newHps);
|
|
assert(battle.log.includes('|move|p1a: Wailord|Water Gun|p1: Shedinja|[notarget]'));
|
|
assert(battle.log.includes('|-fail|p1a: Wailord'));
|
|
assert(battle.log.includes('|move|p2a: Wailord|Water Gun|p2: Shedinja|[notarget]'));
|
|
assert(battle.log.includes('|-fail|p2a: Wailord'));
|
|
});
|
|
|
|
it(`should support RedirectTarget event for a fainted foe and type 'any'`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Hippowdon', ability: 'sandstream', moves: ['waterpulse'] },
|
|
{ species: 'Shedinja', ability: 'wonderguard', moves: ['agility'] },
|
|
], [
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['curse'] },
|
|
{ species: 'Shedinja', ability: 'wonderguard', moves: ['agility'] },
|
|
]]);
|
|
const redirector = battle.p2.active[0];
|
|
|
|
battle.makeChoices('auto', 'auto'); // Shedinjas faint
|
|
battle.makeChoices('move waterpulse 2, pass', 'auto');
|
|
assert.statStage(redirector, 'spa', 2);
|
|
});
|
|
|
|
it(`should support RedirectTarget event for a fainted ally and type 'any'`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Hippowdon', ability: 'sandstream', moves: ['waterpulse'] },
|
|
{ species: 'Shedinja', ability: 'wonderguard', moves: ['agility'] },
|
|
], [
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['curse'] },
|
|
{ species: 'Shedinja', ability: 'wonderguard', moves: ['agility'] },
|
|
]]);
|
|
const redirector = battle.p2.active[0];
|
|
|
|
battle.makeChoices('auto', 'auto'); // Shedinjas faint
|
|
battle.makeChoices('move waterpulse -2, pass', 'auto');
|
|
assert.statStage(redirector, 'spa', 2);
|
|
});
|
|
});
|
|
|
|
describe(`Smart-tracking targeting effects`, () => {
|
|
it(`should allow Stalwart to follow its target after an opposing Ally Switch`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Duraludon', ability: 'stalwart', moves: ['watergun'] },
|
|
{ species: 'Wynaut', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Gastrodon', moves: ['sleeptalk'] },
|
|
{ species: 'Ninjask', moves: ['allyswitch'] },
|
|
]]);
|
|
|
|
const ninjask = battle.p2.active[1];
|
|
battle.makeChoices('move watergun 2, move sleeptalk', 'auto');
|
|
assert.false.fullHP(ninjask, `Duraludon should have followed Ninjask's Ally Switch.`);
|
|
});
|
|
|
|
it(`should allow Stalwart to bypass Storm Drain redirection`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Duraludon', ability: 'stalwart', moves: ['watergun'] },
|
|
{ species: 'Wynaut', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Gastrodon', ability: 'stormdrain', moves: ['sleeptalk'] },
|
|
{ species: 'Ninjask', moves: ['sleeptalk'] },
|
|
]]);
|
|
|
|
const ninjask = battle.p2.active[1];
|
|
battle.makeChoices('move watergun 2, move sleeptalk', 'auto');
|
|
assert.false.fullHP(ninjask, `Duraludon should have ignored Gastrodon's Storm Drain.`);
|
|
});
|
|
|
|
it(`should allow Stalwart to bypass Follow Me redirection`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Duraludon', ability: 'stalwart', moves: ['watergun'] },
|
|
{ species: 'Wynaut', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Clefable', moves: ['followme'] },
|
|
{ species: 'Ninjask', moves: ['sleeptalk'] },
|
|
]]);
|
|
|
|
const ninjask = battle.p2.active[1];
|
|
battle.makeChoices('move watergun 2, move sleeptalk', 'auto');
|
|
assert.false.fullHP(ninjask, `Duraludon should have ignored Clefable's Follow Me.`);
|
|
});
|
|
|
|
it(`should allow Stalwart to correctly target a Pokemon which switched out and back in another slot`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Duraludon', ability: 'stalwart', moves: ['watergun'] },
|
|
{ species: 'Wynaut', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Ninjask', moves: ['uturn'] },
|
|
{ species: 'Regieleki', moves: ['uturn'] },
|
|
{ species: 'Octillery', moves: ['sleeptalk'] },
|
|
]]);
|
|
|
|
const regieleki = battle.p2.active[1];
|
|
battle.makeChoices('move watergun 2, move sleeptalk', 'move uturn -2, move uturn -1');
|
|
battle.choose('p2', 'switch 3');
|
|
battle.choose('p2', 'switch 3');
|
|
assert.false.fullHP(regieleki, `Duraludon should have followed Regieleki through its switch-out.`);
|
|
});
|
|
|
|
it(`should allow Snipe Shot to follow its target after an opposing Ally Switch`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'Inteleon', moves: ['snipeshot'] },
|
|
{ species: 'Ninjask', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'Gastrodon', moves: ['sleeptalk'] },
|
|
{ species: 'Ninjask', moves: ['allyswitch'] },
|
|
]]);
|
|
|
|
const ninjask = battle.p2.active[1];
|
|
battle.makeChoices('move snipeshot 2, move sleeptalk', 'auto');
|
|
assert.false.fullHP(ninjask, `Inteleon should have followed Ninjask's Ally Switch.`);
|
|
});
|
|
});
|
|
|
|
it('should not force charge moves called by another move to target an ally after Ally Switch', () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'purrloin', ability: 'no guard', moves: ['copycat', 'sleeptalk'] },
|
|
{ species: 'wynaut', moves: ['allyswitch', 'fly', 'skullbash'] },
|
|
], [
|
|
{ species: 'aron', moves: ['sleeptalk'] },
|
|
{ species: 'lairon', moves: ['sleeptalk'] },
|
|
]]);
|
|
|
|
battle.makeChoices('move sleeptalk, move fly 1', 'auto');
|
|
battle.makeChoices();
|
|
battle.makeChoices();
|
|
battle.makeChoices('move skullbash 1, move sleeptalk', 'auto');
|
|
battle.makeChoices();
|
|
battle.makeChoices();
|
|
// ally switch was used twice, so wynaut will be back where it started
|
|
assert.fullHP(battle.p1.active[1]);
|
|
});
|
|
|
|
it(`Ally Switch should cause single-target moves to fail if targeting an ally`, () => {
|
|
battle = common.gen(8).createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'purrloin', moves: ['thunder', 'ironhead'] },
|
|
{ species: 'wynaut', moves: ['allyswitch'] },
|
|
], [
|
|
{ species: 'swablu', moves: ['sleeptalk'] },
|
|
{ species: 'swablu', moves: ['sleeptalk'] },
|
|
]]);
|
|
|
|
battle.makeChoices('move ironhead -2, move allyswitch', 'auto');
|
|
battle.makeChoices('move allyswitch, move thunder -1', 'auto');
|
|
assert.fullHP(battle.p1.active[0]);
|
|
});
|
|
|
|
it(`charge moves like Phantom Force should target slots turn 1 and Pokemon turn 2`, () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'houndour', level: 1, moves: ['sleeptalk'] },
|
|
{ species: 'altaria', moves: ['sleeptalk'] },
|
|
{ species: 'aggron', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'dragapult', moves: ['phantomforce'] },
|
|
{ species: 'regieleki', moves: ['sleeptalk', 'sheercold'] },
|
|
]]);
|
|
|
|
// Phantom Force should still target slot 1, despite Houndour fainting
|
|
battle.makeChoices('auto', 'move phantomforce 1, move sheercold 1');
|
|
battle.makeChoices('switch 3');
|
|
battle.makeChoices();
|
|
assert.fullHP(battle.p1.active[1], 'Altaria should be at full HP, because it was not targeted.');
|
|
assert.false.fullHP(battle.p1.active[0], 'Aggron should not be at full HP, because it was targeted.');
|
|
|
|
battle = common.createBattle({ gameType: 'doubles' }, [[
|
|
{ species: 'houndour', level: 1, moves: ['sleeptalk'] },
|
|
{ species: 'altaria', moves: ['sleeptalk'] },
|
|
{ species: 'aggron', moves: ['sleeptalk'] },
|
|
], [
|
|
{ species: 'dragapult', moves: ['phantomforce'] },
|
|
{ species: 'regieleki', moves: ['sleeptalk', 'sheercold'] },
|
|
]]);
|
|
|
|
battle.makeChoices('auto', 'move phantomforce 1, move sleeptalk');
|
|
battle.makeChoices('auto', 'move phantomforce 1, move sheercold 1');
|
|
assert.false.fullHP(battle.p1.active[1], 'Altaria should not be at full HP, because Phantom Force was redirected and targeted it.');
|
|
});
|
|
|
|
it(`should cause Rollout to target the same slot after being called as a submove`, () => {
|
|
// hardcoded RNG seed to show the erroneous targeting behavior
|
|
battle = common.createBattle({ gameType: 'doubles', seed: [1, 2, 3, 4] }, [[
|
|
{ species: 'shuckle', ability: 'compoundeyes', moves: ['copycat'] },
|
|
{ species: 'foongus', item: 'laggingtail', moves: ['spore'] },
|
|
], [
|
|
{ species: 'aggron', moves: ['splash'] },
|
|
{ species: 'slowbro', moves: ['splash', 'rollout'] },
|
|
]]);
|
|
|
|
battle.makeChoices('move copycat, move spore 2', 'move splash, move rollout 1');
|
|
// Determine which slot was damaged on first turn of Rollout
|
|
const aggron = battle.p2.active[0];
|
|
const notTargetedPokemon = aggron.hp === aggron.maxhp ? aggron : battle.p2.active[1];
|
|
|
|
for (let i = 0; i < 5; i++) battle.makeChoices();
|
|
assert.fullHP(notTargetedPokemon);
|
|
});
|
|
});
|