mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-08-28 12:04:28 -05:00
Some checks are pending
Node.js CI / build (16.x) (push) Waiting to run
* Preload data when using Dex.mod With the initial introduction fo TypeScript at3716f36, ``Dex.mod``, and ``Dex.format`` (nowadays ``Dex.forFormat``) no longer ensured that the data cache has been filled. Newer lazy-loading getter APIs were introduced, which were intended to be used as a replacement for direct access to the loaded data (``dataCache``). However, these APIs were either not effective or not properly used., as reflected by43ef4d9, which reverted ``Dex.forFormat`` to its full capabilities. Nevertheless, ``Dex.mod`` was left untouched, which results in a footgun where ``Dex.forFormat('gen1randbats').gen == 1``, but ``Dex.mod('gen1').gen == 9``. This commit brings back ``Dex.mod`` to its original behavior, so that gen information is always there when it's needed. * Add test for dex.mod(mod).gen * Swap around test instructions This is more reliable given the load order.
91 lines
3.5 KiB
JavaScript
91 lines
3.5 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../assert');
|
|
|
|
describe('Mod loader', function () {
|
|
it('should always provide accurate gen information', function () {
|
|
{
|
|
const Dex = require('./../../dist/sim/dex').Dex;
|
|
assert.equal(Dex.mod('gen2').gen, 2);
|
|
assert.equal(Dex.forFormat('gen1randombattle').gen, 1);
|
|
}
|
|
});
|
|
|
|
it('should work fine in any order', function () {
|
|
{
|
|
const Dex = require('./../../dist/sim/dex').Dex;
|
|
assert.equal(Dex.mod('gen2').species.getLearnsetData('nidoking').learnset.bubblebeam.join(','), '1M');
|
|
assert.equal(Dex.mod('gen2').moves.get('crunch').secondaries[0].boosts.def, undefined);
|
|
}
|
|
{
|
|
const Dex = require('./../../dist/sim/dex').Dex;
|
|
Dex.mod('gen2').species.getLearnsetData('nidoking');
|
|
Dex.mod('gen4').moves.get('crunch');
|
|
assert.equal(Dex.mod('gen2').species.getLearnsetData('nidoking').learnset.bubblebeam.join(','), '1M');
|
|
assert.equal(Dex.mod('gen2').moves.get('crunch').secondaries[0].boosts.def, undefined);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('Dex#getEffect', function () {
|
|
it('returns the same object for the same id', function () {
|
|
assert.equal(Dex.conditions.get('Stealth Rock'), Dex.conditions.get('stealthrock'));
|
|
assert.notEqual(Dex.conditions.get('move: Stealth Rock'), Dex.conditions.get('stealthrock'));
|
|
});
|
|
|
|
it('does not return elements from the Object prototype', function () {
|
|
assert.false(Dex.conditions.get('constructor').exists);
|
|
});
|
|
});
|
|
|
|
describe('Dex#getSpecies', function () {
|
|
it('should handle cosmetic Flabébé formes', function () {
|
|
assert.equal(Dex.species.get('Flabébé-yellow').name, 'Flabébé-Yellow');
|
|
});
|
|
|
|
it('should handle Minior-Meteor formes', function () {
|
|
assert(!Dex.species.get('Minior-Meteor').isNonstandard);
|
|
assert(Dex.forGen(8).species.get('Minior-Meteor').isNonstandard);
|
|
assert(!Dex.forGen(7).species.get('Minior-Meteor').isNonstandard);
|
|
});
|
|
|
|
it.skip('should handle Rockruff-Dusk', function () {
|
|
assert.equal(Dex.species.get('rockruffdusk').name, 'Rockruff-Dusk');
|
|
});
|
|
|
|
it('should handle Pikachu forme numbering', function () {
|
|
assert.deepEqual(
|
|
Dex.forGen(6).species.get('Pikachu').formeOrder.slice(0, 7),
|
|
["Pikachu", "Pikachu-Rock-Star", "Pikachu-Belle", "Pikachu-Pop-Star", "Pikachu-PhD", "Pikachu-Libre", "Pikachu-Cosplay"]
|
|
);
|
|
assert.deepEqual(
|
|
Dex.forGen(7).species.get('Pikachu').formeOrder.slice(0, 9),
|
|
["Pikachu", "Pikachu-Original", "Pikachu-Hoenn", "Pikachu-Sinnoh", "Pikachu-Unova", "Pikachu-Kalos", "Pikachu-Alola", "Pikachu-Partner", "Pikachu-Starter"]
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('Dex#getItem', function () {
|
|
it(`should correctly mark Gem legality`, function () {
|
|
assert.false(Dex.forGen(5).items.get('Normal Gem').isNonstandard);
|
|
assert.false(Dex.forGen(5).items.get('Rock Gem').isNonstandard);
|
|
|
|
assert.false(Dex.forGen(6).items.get('Normal Gem').isNonstandard);
|
|
assert.equal(Dex.forGen(6).items.get('Rock Gem').isNonstandard, "Unobtainable");
|
|
|
|
assert.false(Dex.forGen(7).items.get('Normal Gem').isNonstandard);
|
|
assert.equal(Dex.forGen(7).items.get('Rock Gem').isNonstandard, "Unobtainable");
|
|
|
|
assert.false(Dex.forGen(8).items.get('Normal Gem').isNonstandard);
|
|
assert.equal(Dex.forGen(8).items.get('Rock Gem').isNonstandard, "Past");
|
|
});
|
|
});
|
|
|
|
describe('Dex#getMove', function () {
|
|
it(`should correctly handle G-Max moves`, function () {
|
|
assert.equal(Dex.forGen(8).moves.get('G-Max Befuddle').name, "G-Max Befuddle");
|
|
assert.equal(Dex.forGen(8).moves.get('G-Max Befuddle').gen, 8);
|
|
assert.equal(Dex.forGen(8).moves.get('G-Max Befuddle').isNonstandard, "Gigantamax");
|
|
});
|
|
});
|