mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-09-14 20:25:36 -05:00
ESLint has a whole new config format, so I figure it's a good time to make the config system saner. - First, we no longer have separate eslint-no-types configs. Lint performance shouldn't be enough of a problem to justify the relevant maintenance complexity. - Second, our base config should work out-of-the-box now. `npx eslint` will work as expected, without any CLI flags. You should still use `npm run lint` which adds the `--cached` flag for performance. - Third, whatever updates I did fixed style linting, which apparently has been bugged for quite some time, considering all the obvious mixed-tabs-and-spaces issues I found in the upgrade. Also here are some changes to our style rules. In particular: - Curly brackets (for objects etc) now have spaces inside them. Sorry for the huge change. ESLint doesn't support our old style, and most projects use Prettier style, so we might as well match them in this way. See https://github.com/eslint-stylistic/eslint-stylistic/issues/415 - String + number concatenation is no longer allowed. We now consistently use template strings for this.
294 lines
10 KiB
TypeScript
294 lines
10 KiB
TypeScript
import { Utils } from '../../lib';
|
|
import { FS } from '../../lib/fs';
|
|
|
|
const SUSPECTS_FILE = 'config/suspects.json';
|
|
|
|
interface SuspectTest {
|
|
tier: string;
|
|
suspect: string;
|
|
date: string;
|
|
url: string;
|
|
}
|
|
|
|
interface SuspectsFile {
|
|
whitelist: string[];
|
|
suspects: { [format: string]: SuspectTest };
|
|
}
|
|
|
|
export let suspectTests: SuspectsFile = JSON.parse(FS(SUSPECTS_FILE).readIfExistsSync() || "{}");
|
|
|
|
function saveSuspectTests() {
|
|
FS(SUSPECTS_FILE).writeUpdate(() => JSON.stringify(suspectTests));
|
|
}
|
|
|
|
const defaults: SuspectsFile = {
|
|
whitelist: [],
|
|
suspects: {},
|
|
};
|
|
|
|
if (!suspectTests.whitelist && !suspectTests.suspects) {
|
|
const suspects = { ...suspectTests } as unknown as { [format: string]: SuspectTest };
|
|
suspectTests = { ...defaults, suspects };
|
|
saveSuspectTests();
|
|
}
|
|
|
|
function checkPermissions(context: Chat.CommandContext) {
|
|
const user = context.user;
|
|
if (suspectTests.whitelist?.includes(user.id)) return true;
|
|
context.checkCan('gdeclare');
|
|
}
|
|
|
|
export const commands: Chat.ChatCommands = {
|
|
suspect: 'suspects',
|
|
suspects: {
|
|
''(target, room, user) {
|
|
const suspects = suspectTests.suspects;
|
|
if (!Object.keys(suspects).length) {
|
|
throw new Chat.ErrorMessage("There are no suspect tests running.");
|
|
}
|
|
if (!this.runBroadcast()) return;
|
|
|
|
let buffer = '<strong>Suspect tests currently running:</strong>';
|
|
for (const i of Object.keys(suspects)) {
|
|
const test = suspects[i];
|
|
buffer += '<br />';
|
|
buffer += `${Utils.escapeHTML(test.tier)}: <a href="${test.url}">${Utils.escapeHTML(test.suspect)}</a> (${test.date})`;
|
|
}
|
|
return this.sendReplyBox(buffer);
|
|
},
|
|
|
|
edit: 'add',
|
|
async add(target, room, user) {
|
|
checkPermissions(this);
|
|
|
|
const [tier, suspect, date, url, ...reqs] = target.split(',').map(x => x.trim());
|
|
if (!(tier && suspect && date && url && reqs)) {
|
|
return this.parse('/help suspects');
|
|
}
|
|
|
|
const format = Dex.formats.get(tier);
|
|
if (format.effectType !== 'Format') throw new Chat.ErrorMessage(`"${tier}" is not a valid tier.`);
|
|
|
|
const suspectString = suspect.trim();
|
|
|
|
const [month, day] = date.trim().split(date.includes('-') ? '-' : '/');
|
|
const isValidDate = /[0-1]?[0-9]/.test(month) && /[0-3]?[0-9]/.test(day);
|
|
if (!isValidDate) throw new Chat.ErrorMessage("Dates must be in the format MM/DD.");
|
|
const dateActual = `${month}/${day}`;
|
|
|
|
const urlActual = url.trim();
|
|
if (!/^https:\/\/www\.smogon\.com\/forums\/(threads|posts)\//.test(urlActual)) {
|
|
throw new Chat.ErrorMessage("Suspect test URLs must be Smogon threads or posts.");
|
|
}
|
|
|
|
const reqData: Record<string, number> = {};
|
|
if (!reqs.length) {
|
|
return this.errorReply("At least one requirement for qualifying must be provided.");
|
|
}
|
|
for (const req of reqs) {
|
|
let [k, v] = req.split('=');
|
|
k = toID(k);
|
|
if (k === 'b') {
|
|
await this.parse(`/suspects setcoil ${format},${v}`);
|
|
continue;
|
|
}
|
|
if (!['elo', 'gxe', 'coil'].includes(k)) {
|
|
return this.errorReply(`Invalid requirement type: ${k}. Must be 'coil', 'gxe', or 'elo'.`);
|
|
}
|
|
if (k === 'coil' && !reqs.some(x => toID(x).startsWith('b'))) {
|
|
throw new Chat.ErrorMessage("COIL reqs are specified, but you have not provided a B value (with the argument `b=num`)");
|
|
}
|
|
const val = Number(v);
|
|
if (isNaN(val) || val < 0) {
|
|
return this.errorReply(`Invalid value: ${v}`);
|
|
}
|
|
if (reqData[k]) {
|
|
return this.errorReply(`Requirement type ${k} specified twice.`);
|
|
}
|
|
reqData[k] = val;
|
|
}
|
|
const [out, error] = await LoginServer.request(suspectTests.suspects[format.id] ? "suspects/edit" : "suspects/add", {
|
|
format: format.id,
|
|
reqs: JSON.stringify(reqData),
|
|
url: urlActual,
|
|
});
|
|
if (out?.actionerror || error) {
|
|
throw new Chat.ErrorMessage("Error adding suspect test: " + (out?.actionerror || error?.message));
|
|
}
|
|
|
|
this.privateGlobalModAction(`${user.name} ${suspectTests.suspects[format.id] ? "edited the" : "added a"} ${format.name} suspect test.`);
|
|
this.globalModlog('SUSPECTTEST', null, `${suspectTests.suspects[format.id] ? "edited" : "added"} ${format.name}`);
|
|
|
|
suspectTests.suspects[format.id] = {
|
|
tier: format.name,
|
|
suspect: suspectString,
|
|
date: dateActual,
|
|
url: urlActual,
|
|
};
|
|
saveSuspectTests();
|
|
this.sendReply(`Added a suspect test notice for ${suspectString} in ${format.name}.`);
|
|
if (reqData.coil) this.sendReply('Remember to add a B value for your test\'s COIL setting with /suspects setbvalue.');
|
|
},
|
|
|
|
end: 'remove',
|
|
delete: 'remove',
|
|
async remove(target, room, user) {
|
|
checkPermissions(this);
|
|
|
|
const format = toID(target);
|
|
const test = suspectTests.suspects[format];
|
|
if (!test) return this.errorReply(`There is no suspect test for '${target}'. Check spelling?`);
|
|
|
|
const [out, error] = await LoginServer.request('suspects/end', {
|
|
format,
|
|
});
|
|
if (out?.actionerror || error) {
|
|
throw new Chat.ErrorMessage(`Error ending suspect: ${out?.actionerror || error?.message}`);
|
|
}
|
|
|
|
this.privateGlobalModAction(`${user.name} removed the ${test.tier} suspect test.`);
|
|
this.globalModlog('SUSPECTTEST', null, `removed ${test.tier}`);
|
|
|
|
delete suspectTests.suspects[format];
|
|
saveSuspectTests();
|
|
this.sendReply(`Removed a suspect test notice for ${test.suspect} in ${test.tier}.`);
|
|
this.sendReply(`Remember to remove COIL settings with /suspects deletecoil if you had them enabled.`);
|
|
},
|
|
|
|
whitelist(target, room, user) {
|
|
this.checkCan('gdeclare');
|
|
|
|
const userid = toID(target);
|
|
|
|
if (!userid || userid.length > 18) {
|
|
if (suspectTests.whitelist.length) {
|
|
this.sendReplyBox(`Current users with /suspects access: <username>${suspectTests.whitelist.join('</username>, <username>')}</username>`);
|
|
}
|
|
return this.parse(`/help suspects`);
|
|
}
|
|
|
|
if (suspectTests.whitelist.includes(userid)) {
|
|
throw new Chat.ErrorMessage(`${userid} is already whitelisted to add suspect tests.`);
|
|
}
|
|
|
|
this.privateGlobalModAction(`${user.name} whitelisted ${userid} to add suspect tests.`);
|
|
this.globalModlog('SUSPECTTEST', null, `whitelisted ${userid}`);
|
|
|
|
suspectTests.whitelist.push(userid);
|
|
saveSuspectTests();
|
|
},
|
|
|
|
unwhitelist(target, room, user) {
|
|
this.checkCan('gdeclare');
|
|
|
|
const userid = toID(target);
|
|
|
|
if (!userid || userid.length > 18) {
|
|
return this.parse(`/help suspects`);
|
|
}
|
|
|
|
const index = suspectTests.whitelist.indexOf(userid);
|
|
|
|
if (index < 0) {
|
|
throw new Chat.ErrorMessage(`${userid} is not whitelisted to add suspect tests.`);
|
|
}
|
|
|
|
this.privateGlobalModAction(`${user.name} unwhitelisted ${userid} from adding suspect tests.`);
|
|
this.globalModlog('SUSPECTTEST', null, `unwhitelisted ${userid}`);
|
|
|
|
suspectTests.whitelist.splice(index, 1);
|
|
saveSuspectTests();
|
|
},
|
|
|
|
async verify(target, room, user) {
|
|
const formatid = toID(target);
|
|
if (!suspectTests.suspects[formatid]) {
|
|
throw new Chat.ErrorMessage("There is no suspect test running for the given format.");
|
|
}
|
|
const [out, error] = await LoginServer.request("suspects/verify", {
|
|
formatid,
|
|
userid: user.id,
|
|
});
|
|
if (error) {
|
|
throw new Chat.ErrorMessage("Error verifying for suspect: " + error.message);
|
|
}
|
|
if (out?.actionerror) {
|
|
throw new Chat.ErrorMessage(out.actionerror);
|
|
}
|
|
this.sendReply(
|
|
out.result ?
|
|
`You have successfully verified for the ${formatid} suspect test.` :
|
|
`You could not verify for the ${formatid} suspect test, as you do not meet the requirements.`
|
|
);
|
|
},
|
|
|
|
help() {
|
|
return this.parse('/help suspects');
|
|
},
|
|
|
|
deletebvalue: 'setbvalue',
|
|
deletecoil: 'setbvalue',
|
|
sbv: 'setbvalue',
|
|
dbv: 'setbvalue',
|
|
sc: 'setbvalue',
|
|
dc: 'setbvalue',
|
|
setcoil: 'setbvalue',
|
|
async setbvalue(target, room, user, connection, cmd) {
|
|
checkPermissions(this);
|
|
if (!toID(target)) {
|
|
return this.parse(`/help ${cmd}`);
|
|
}
|
|
const [formatStr, source] = this.splitOne(target);
|
|
const format = Dex.formats.get(formatStr);
|
|
let bVal: number | undefined = parseFloat(source);
|
|
if (cmd.startsWith('d')) {
|
|
bVal = undefined;
|
|
} else if (!source || isNaN(bVal) || bVal < 1) {
|
|
throw new Chat.ErrorMessage(`Specify a valid COIL B value.`);
|
|
}
|
|
if (!toID(formatStr) || !format.exists) {
|
|
throw new Chat.ErrorMessage(`Specify a valid format to set a COIL B value for. Check spelling?`);
|
|
}
|
|
this.sendReply(`Updating...`);
|
|
const [res, error] = await LoginServer.request('updatecoil', {
|
|
format: format.id,
|
|
coil_b: bVal,
|
|
});
|
|
if (error) {
|
|
throw new Chat.ErrorMessage(error.message);
|
|
}
|
|
if (!res || res.actionerror) {
|
|
throw new Chat.ErrorMessage(res?.actionerror || "The loginserver is currently disabled.");
|
|
}
|
|
this.globalModlog(`${source ? 'SET' : 'REMOVE'}BVALUE`, null, `${format.id}${bVal ? ` to ${bVal}` : ""}`);
|
|
this.addGlobalModAction(
|
|
`${user.name} ${bVal ? `set B value for ${format.name} to ${bVal}` : `removed B value for ${format.name}`}.`
|
|
);
|
|
if (source) {
|
|
return this.sendReply(`COIL B value for ${format.name} set to ${bVal}.`);
|
|
} else {
|
|
return this.sendReply(`Removed COIL B value for ${format.name}.`);
|
|
}
|
|
},
|
|
setbvaluehelp: [
|
|
`/suspects setbvalue OR /suspects sbv [formatid], [B value] - Activate COIL ranking for the given [formatid] with the given [B value].`,
|
|
`Requires: suspect whitelist ~`,
|
|
],
|
|
},
|
|
|
|
suspectshelp() {
|
|
this.sendReplyBox(
|
|
`Commands to manage suspect tests:<br />` +
|
|
`<code>/suspects</code>: displays currently running suspect tests.<br />` +
|
|
`<code>/suspects add [tier], [suspect], [date], [link], [...reqs]</code>: adds a suspect test. Date in the format MM/DD. ` +
|
|
`Reqs in the format [key]=[value], where valid keys are 'coil', 'elo', and 'gxe', delimited by commas. At least one is required. <br />` +
|
|
`(note that if you are using COIL, you must set a B value indepedently with <code>/suspects setcoil</code>). Requires: ~<br />` +
|
|
`<code>/suspects remove [tier]</code>: deletes a suspect test. Requires: ~<br />` +
|
|
`<code>/suspects whitelist [username]</code>: allows [username] to add suspect tests. Requires: ~<br />` +
|
|
`<code>/suspects unwhitelist [username]</code>: disallows [username] from adding suspect tests. Requires: ~<br />` +
|
|
`<code>/suspects setbvalue OR /suspects sbv [formatid], [B value]</code>: Activate COIL ranking for the given [formatid] with the given [B value].` +
|
|
`Requires: suspect whitelist ~`
|
|
);
|
|
},
|
|
};
|