mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-25 15:40:31 -05:00
78439b4a02
ESLint has a whole new config format, so I figure it's a good time to make the config system saner. - First, we no longer have separate eslint-no-types configs. Lint performance shouldn't be enough of a problem to justify the relevant maintenance complexity. - Second, our base config should work out-of-the-box now. `npx eslint` will work as expected, without any CLI flags. You should still use `npm run lint` which adds the `--cached` flag for performance. - Third, whatever updates I did fixed style linting, which apparently has been bugged for quite some time, considering all the obvious mixed-tabs-and-spaces issues I found in the upgrade. Also here are some changes to our style rules. In particular: - Curly brackets (for objects etc) now have spaces inside them. Sorry for the huge change. ESLint doesn't support our old style, and most projects use Prettier style, so we might as well match them in this way. See https://github.com/eslint-stylistic/eslint-stylistic/issues/415 - String + number concatenation is no longer allowed. We now consistently use template strings for this.
110 lines
5.4 KiB
JavaScript
110 lines
5.4 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Pickup', () => {
|
|
afterEach(() => {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should pick up a consumed item', () => {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', { team: [{ species: 'Gourgeist', ability: 'pickup', moves: ['flamethrower'] }] });
|
|
battle.setPlayer('p2', { team: [{ species: 'Paras', ability: 'dryskin', item: 'sitrusberry', moves: ['endure'] }] });
|
|
battle.makeChoices('move flamethrower', 'move endure');
|
|
assert.holdsItem(battle.p1.active[0], "Pick Up should retrieve consumed Sitrus Berry");
|
|
});
|
|
|
|
it('should pick up flung items', () => {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', { team: [{ species: 'Gourgeist', ability: 'pickup', moves: ['endure'] }] });
|
|
battle.setPlayer('p2', { team: [{ species: 'Clefairy', ability: 'unaware', item: 'airballoon', moves: ['fling'] }] });
|
|
battle.makeChoices('move endure', 'move fling');
|
|
assert.holdsItem(battle.p1.active[0], "Pick Up should retrieve flung Air Balloon");
|
|
});
|
|
|
|
it('should not pick up an item that was knocked off', () => {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', { team: [{ species: 'Ambipom', ability: 'pickup', moves: ['knockoff'] }] });
|
|
battle.setPlayer('p2', { team: [{ species: 'Machamp', ability: 'noguard', item: 'choicescarf', moves: ['bulkup'] }] });
|
|
battle.makeChoices('move knockoff', 'move bulkup');
|
|
assert.false.holdsItem(battle.p1.active[0], "Pick Up should not retrieve knocked off Choice Scarf");
|
|
});
|
|
|
|
it('should not pick up a popped Air Balloon', () => {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', { team: [{ species: 'Ambipom', ability: 'pickup', moves: ['fakeout'] }] });
|
|
battle.setPlayer('p2', { team: [{ species: 'Scizor', ability: 'swarm', item: 'airballoon', moves: ['roost'] }] });
|
|
battle.makeChoices('move fakeout', 'move roost');
|
|
assert.false.holdsItem(battle.p1.active[0], "Pick Up should not retrieve popped Air Balloon");
|
|
});
|
|
|
|
it('should not pick up items from Pokemon that have switched out and back in', () => {
|
|
battle = common.createBattle({ gameType: 'doubles' });
|
|
battle.setPlayer('p1', { team: [
|
|
{ species: 'Gourgeist', ability: 'pickup', moves: ['shadowsneak'] },
|
|
{ species: 'Aggron', ability: 'sturdy', moves: ['rest'] },
|
|
] });
|
|
battle.setPlayer('p2', { team: [
|
|
{ species: 'Ambipom', ability: 'swarm', moves: ['uturn'] },
|
|
{ species: 'Clefable', ability: 'unaware', item: 'ejectbutton', moves: ['followme'] },
|
|
{ species: 'Magikarp', ability: 'rattled', moves: ['splash'] },
|
|
] });
|
|
battle.makeChoices('move shadowsneak 1, move rest', 'move uturn 1, move followme');
|
|
battle.makeChoices('', 'switch 3'); // Eject Button activated
|
|
battle.makeChoices('', 'switch 3');
|
|
assert.false.holdsItem(battle.p1.active[0], "Pick Up should not retrieve Eject Button of returned Clefable");
|
|
});
|
|
|
|
it('should not pick up items from Pokemon that have switched out', () => {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', { team: [{ species: 'Gourgeist', ability: 'pickup', moves: ['shadowsneak', 'synthesis'] }] });
|
|
battle.setPlayer('p2', { team: [
|
|
{ species: 'Ambipom', ability: 'swarm', item: 'buggem', moves: ['uturn'] },
|
|
{ species: 'Dusknoir', ability: 'pressure', item: 'ejectbutton', moves: ['painsplit'] },
|
|
] });
|
|
battle.makeChoices('move synthesis', 'move uturn');
|
|
battle.makeChoices('', 'switch 2');
|
|
assert.false.holdsItem(battle.p1.active[0]);
|
|
battle.makeChoices('move synthesis', 'move painsplit');
|
|
battle.makeChoices('move synthesis', 'switch 2');
|
|
assert.false.holdsItem(battle.p1.active[0]);
|
|
});
|
|
|
|
it('should not pick up items that were already retrieved', () => {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', { team: [{ species: 'Ambipom', ability: 'pickup', moves: ['return'] }] });
|
|
battle.setPlayer('p2', { team: [{ species: 'Aron', level: 1, ability: 'sturdy', item: 'berryjuice', moves: ['recycle'] }] });
|
|
battle.makeChoices('move return', 'move recycle');
|
|
assert.false.holdsItem(battle.p1.active[0]);
|
|
});
|
|
|
|
it('should pick up items from adjacent allies', () => {
|
|
battle = common.createBattle({ gameType: 'doubles' }, [
|
|
[{ species: 'Ambipom', ability: 'pickup', moves: ['protect'] }, { species: 'Aron', level: 1, ability: 'sturdy', item: 'berryjuice', moves: ['followme'] }],
|
|
[{ species: 'Ambipom', ability: 'technician', moves: ['return'] }, { species: 'Arcanine', ability: 'flashfire', moves: ['protect'] }],
|
|
]);
|
|
battle.makeChoices('move protect, move followme', 'move return 1, move protect');
|
|
assert.holdsItem(battle.p1.active[0]);
|
|
});
|
|
|
|
it('should not pick up items from non-adjacent allies and enemies', () => {
|
|
battle = common.gen(5).createBattle({ gameType: 'triples' });
|
|
battle.setPlayer('p1', { team: [
|
|
{ species: 'Ambipom', ability: 'pickup', moves: ['protect'] },
|
|
{ species: 'Regirock', ability: 'sturdy', moves: ['curse'] },
|
|
{ species: 'Arcanine', ability: 'flashfire', item: 'normalgem', moves: ['extremespeed'] },
|
|
] });
|
|
battle.setPlayer('p2', { team: [
|
|
{ species: 'Arcanine', ability: 'flashfire', item: 'firegem', moves: ['flamecharge'] },
|
|
{ species: 'Aggron', ability: 'sturdy', moves: ['rest'] },
|
|
{ species: 'Magikarp', ability: 'swiftswim', moves: ['splash'] },
|
|
] });
|
|
battle.makeChoices('move protect, move curse, move extremespeed 2', 'move flamecharge 2, move rest, move splash');
|
|
assert.false.holdsItem(battle.p1.active[0]);
|
|
});
|
|
});
|