mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-03-21 17:25:10 -05:00
c57fcf25c6
In the past, we used non-type-aware linting in our pre-push hook, as well as in `npm test`. This was for performance reasons. In practice, though, we use an eslint cache, which makes even type-aware incremental linting instantaneous. My rule is that you should be able to make a small change and lint in under 10 seconds, and `npm test` should take under 30 seconds, and linting with no changes (for the pre-push hook) should be under 2 seconds. This is still true for type-aware linting, so there's no actual need for fast linting. We've also switched to using `--max-warnings 0` to convert warnings to errors. This seems to allow them to use the same cache file. A big improvement here is that `npm test` should now be enough for testing. I think everyone ran `npm run full-test` for a while because `npm test` didn't have type-aware lint errors, but now that it does, you'll be able to use it again and have your tests run a lot faster.
48 lines
2.0 KiB
JSON
48 lines
2.0 KiB
JSON
{
|
|
"extends": "./.eslintrc-no-types.json",
|
|
"overrides": [
|
|
{
|
|
"files": ["./config/*.ts", "./data/**/*.ts", "./lib/*.ts", "./server/**/*.ts", "./sim/**/*.ts", "./tools/set-import/*.ts"],
|
|
"parser": "@typescript-eslint/parser",
|
|
"parserOptions": {
|
|
"ecmaVersion": 9,
|
|
"sourceType": "module",
|
|
"tsconfigRootDir": ".",
|
|
"project": ["./tsconfig.json"]
|
|
},
|
|
"extends": [
|
|
"plugin:@typescript-eslint/recommended",
|
|
"plugin:@typescript-eslint/recommended-requiring-type-checking",
|
|
"./.eslintrc-no-types.json"
|
|
],
|
|
"rules": {
|
|
// TODO investigate
|
|
"@typescript-eslint/restrict-plus-operands": "off",
|
|
// "@typescript-eslint/restrict-plus-operands": ["error", {"checkCompoundAssignments": true}],
|
|
// "@typescript-eslint/switch-exhaustiveness-check": "error",
|
|
|
|
// typescript-eslint defaults too strict
|
|
"@typescript-eslint/no-unsafe-assignment": "off",
|
|
"@typescript-eslint/no-unsafe-call": "off",
|
|
"@typescript-eslint/no-unsafe-member-access": "off",
|
|
"@typescript-eslint/no-unsafe-return": "off",
|
|
"@typescript-eslint/restrict-template-expressions": "off",
|
|
|
|
// probably bugs
|
|
"@typescript-eslint/no-floating-promises": "error",
|
|
"@typescript-eslint/no-for-in-array": "error",
|
|
"@typescript-eslint/no-misused-promises": "error",
|
|
"@typescript-eslint/no-throw-literal": "error",
|
|
"@typescript-eslint/no-unnecessary-condition": "off", // sadly, we use not-null assertions so commonly that these are often necessary
|
|
|
|
// syntax style (local syntactical, usually autofixable formatting decisions)
|
|
"@typescript-eslint/no-unnecessary-qualifier": "off",
|
|
"@typescript-eslint/no-unnecessary-type-arguments": "error",
|
|
"@typescript-eslint/no-unnecessary-type-assertion": "error",
|
|
"@typescript-eslint/prefer-regexp-exec": "error",
|
|
"@typescript-eslint/prefer-string-starts-ends-with": "error"
|
|
}
|
|
}
|
|
]
|
|
}
|