mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-24 15:00:11 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
94 lines
3.8 KiB
JavaScript
94 lines
3.8 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Most status moves', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should ignore natural type immunities', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Smeargle", ability: 'prankster', item: 'leftovers', moves: ['gastroacid', 'glare', 'confuseray', 'sandattack']}]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: "Klefki", ability: 'magician', happiness: 0, moves: ['return']},
|
|
{species: "Dusknoir", ability: 'frisk', moves: ['shadowpunch']},
|
|
{species: "Slaking", ability: 'truant', moves: ['shadowclaw']},
|
|
{species: "Tornadus", ability: 'prankster', moves: ['tailwind']},
|
|
{species: "Unown", ability: 'levitate', moves: ['hiddenpower']},
|
|
]});
|
|
battle.makeChoices('move gastroacid', 'move return');
|
|
assert.false.holdsItem(battle.p2.active[0]); // Klefki's Magician suppressed by Gastro Acid.
|
|
battle.makeChoices('move glare', 'switch 2'); // Dusknoir
|
|
assert.equal(battle.p2.active[0].status, 'par');
|
|
battle.makeChoices('move confuseray', 'switch 3'); // Slaking
|
|
assert(battle.p2.active[0].volatiles['confusion']);
|
|
battle.makeChoices('move sandattack', 'switch 4'); // Tornadus
|
|
assert.statStage(battle.p2.active[0], 'accuracy', -1);
|
|
battle.makeChoices('move sandattack', 'switch 5'); // Unown (Levitate)
|
|
assert.statStage(battle.p2.active[0], 'accuracy', -1);
|
|
});
|
|
|
|
it('should fail when the opposing Pokemon is immune to the status effect it sets', function () {
|
|
this.timeout(0);
|
|
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: "Smeargle", ability: 'noguard', item: 'laggingtail', moves: ['thunderwave', 'willowisp', 'poisongas', 'toxic']}]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: "Zapdos", ability: 'pressure', moves: ['charge']},
|
|
{species: "Emboar", ability: 'blaze', moves: ['sleeptalk']},
|
|
{species: "Muk", ability: 'stench', moves: ['shadowsneak']},
|
|
{species: "Aron", ability: 'sturdy', moves: ['magnetrise']},
|
|
]});
|
|
|
|
battle.makeChoices('move thunderwave', 'move charge');
|
|
assert.equal(battle.p2.active[0].status, '');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-immune|'));
|
|
|
|
battle.makeChoices('move willowisp', 'switch 2'); // Emboar
|
|
assert.equal(battle.p2.active[0].status, '');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-immune|'));
|
|
|
|
battle.makeChoices('move poisongas', 'switch 3'); // Muk
|
|
assert.equal(battle.p2.active[0].status, '');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-immune|'));
|
|
|
|
battle.makeChoices('move toxic', 'move shadowsneak');
|
|
assert.equal(battle.p2.active[0].status, '');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-immune|'));
|
|
|
|
battle.makeChoices('move poisongas', 'switch 4'); // Aron
|
|
assert.equal(battle.p2.active[0].status, '');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-immune|'));
|
|
|
|
battle.makeChoices('move toxic', 'move magnetrise');
|
|
assert.equal(battle.p2.active[0].status, '');
|
|
assert(battle.log[battle.lastMoveLine + 1].startsWith('|-immune|'));
|
|
});
|
|
});
|
|
|
|
describe('Poison-inflicting status moves [Gen 2]', function () {
|
|
const POISON_STATUS_MOVES = ['poisonpowder', 'poisongas', 'toxic'];
|
|
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should not ignore type immunities', function () {
|
|
battle = common.gen(2).createBattle([
|
|
[{species: "Smeargle", moves: POISON_STATUS_MOVES}],
|
|
[{species: "Magneton", moves: ['sleeptalk']}],
|
|
]);
|
|
// Set all moves to perfect accuracy
|
|
battle.onEvent('Accuracy', battle.format, true);
|
|
|
|
const target = battle.p2.active[0];
|
|
for (const move of POISON_STATUS_MOVES) {
|
|
assert.constant(() => target.status, () => battle.makeChoices('move ' + move, 'move sleeptalk'));
|
|
}
|
|
});
|
|
});
|