mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-25 15:40:31 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
44 lines
1.4 KiB
JavaScript
44 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Lansat Berry', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should apply a Focus Energy effect when consumed', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Aggron', ability: 'sturdy', item: 'lansatberry', moves: ['sleeptalk']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Lucario', ability: 'adaptability', moves: ['aurasphere']}]});
|
|
const holder = battle.p1.active[0];
|
|
battle.makeChoices('move sleeptalk', 'move aurasphere');
|
|
assert.false.holdsItem(holder);
|
|
assert('focusenergy' in holder.volatiles);
|
|
});
|
|
|
|
it('should start to apply the effect even in middle of an attack', function () {
|
|
battle = common.createBattle([
|
|
[{species: 'Makuhita', ability: 'guts', item: 'lansatberry', moves: ['triplekick']}],
|
|
[{species: 'Muk', ability: 'noguard', item: 'rockyhelmet', moves: ['acidarmor']}],
|
|
]);
|
|
const holder = battle.p1.active[0];
|
|
|
|
let i = 0;
|
|
const expectedRatio = [1, 1, 1, 1, 1, 3];
|
|
battle.onEvent('ModifyCritRatio', battle.format, -99, function (critRatio, pokemon) {
|
|
assert.equal(critRatio, expectedRatio[i++]);
|
|
});
|
|
|
|
battle.makeChoices('move triplekick', 'move acidarmor');
|
|
battle.makeChoices('move triplekick', 'move acidarmor');
|
|
|
|
assert.false.holdsItem(holder);
|
|
assert.equal(holder.hp, 3);
|
|
assert.equal(i, 6);
|
|
});
|
|
});
|