mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-19 17:17:22 -05:00
a65faf263f
It turns out that when I switched us from `assert` to `assert.strict`,
I didn't actually update any existing tests or tell anyone:
0df0d234f2
So apparently everyone else just kept on using `strictEqual`.
This will be a PR and also throw an error if people continue trying to
use it, which should make it much clearer what PS policy is on this.
A lot of the problem may be that TypeScript marks assert.strict.equal
as deprecated when it's not. This was fixed 4 days ago:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48452
But this probably hasn't made it to a thing yet. Until then, you'll
have to deal with TS marking your tests as deprecated, but it shouldn't
be too long.
Accidentally using `assert` instead of `assert.strict` should now show
an error. This protects against the probably much worse mistake of
accidentally using `assert.equal` rather than `assert.strict.equal`.
`assert.ok` is also deprecated now.
35 lines
1.2 KiB
JavaScript
35 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require('./../../assert');
|
|
const common = require('./../../common');
|
|
|
|
let battle;
|
|
|
|
describe('Flame Orb', function () {
|
|
afterEach(function () {
|
|
battle.destroy();
|
|
});
|
|
|
|
it('should not trigger when entering battle', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [
|
|
{species: 'Magikarp', ability: 'swiftswim', item: 'focussash', moves: ['splash']},
|
|
{species: 'Ursaring', ability: 'guts', item: 'flameorb', moves: ['protect']},
|
|
]});
|
|
battle.setPlayer('p2', {team: [
|
|
{species: 'Breloom', ability: 'technician', moves: ['bulletseed']},
|
|
]});
|
|
battle.makeChoices('move splash', 'move bulletseed');
|
|
battle.makeChoices('switch 2', '');
|
|
assert.notEqual(battle.p1.active[0].status, 'brn');
|
|
});
|
|
|
|
it('should trigger after one turn', function () {
|
|
battle = common.createBattle();
|
|
battle.setPlayer('p1', {team: [{species: 'Ursaring', ability: 'guts', item: 'flameorb', moves: ['protect']}]});
|
|
battle.setPlayer('p2', {team: [{species: 'Magikarp', ability: 'swiftswim', moves: ['splash']}]});
|
|
const target = battle.p1.active[0];
|
|
assert.sets(() => target.status, 'brn', () => battle.makeChoices('move protect', 'move splash'));
|
|
});
|
|
});
|