Commit Graph

8 Commits

Author SHA1 Message Date
Guangcong Luo
9d87616176
Add more style linting rules (#7537)
* Lint arrow-body-style

* Lint prefer-object-spread

Object spread is faster _and_ more readable.

This also fixes a few unnecessary object clones.

* Enable no-parameter-properties

This isn't currently used, but this makes clear that it shouldn't be.

* Refactor more Promises to async/await

* Remove unnecessary code from getDataMoveHTML etc

* Lint prefer-string-starts-ends-with

* Stop using no-undef

According to the typescript-eslint FAQ, this is redundant with
TypeScript, and they're not wrong. This will save us from needing to
specify globals in two different places which will be nice.
2020-10-19 02:42:28 -07:00
Ben Davies
6f26265ff9 Tests: simplify Dashycode transcodeWithSets helper 2020-10-19 05:15:02 -03:00
Guangcong Luo
229f5f809d Use assert in strict mode
This makes it so we can use `assert.equal` instead of
`assert.strictEqual`, which I think is more readable.
2020-02-20 00:39:31 -08:00
Ben Davies
eaf4b6001d Add more Dashycode tests 2019-07-20 10:50:02 -03:00
Ben Davies
a135ec214a Correct comment about codepoints in Dashycode unit tests 2019-07-13 04:39:38 -03:00
Ben Davies
f5822d9e9f Remove unused parameter from function in Dashycode's unit tests 2019-07-13 02:53:32 -03:00
Ben Davies
e770a565dd Mention why we don't test codepoints above 0xFFFF with Dashycode 2019-07-13 02:45:23 -03:00
Ben Davies
1375d653f9 Unit test Dashycode 2019-07-13 02:42:57 -03:00