Commit Graph

23714 Commits

Author SHA1 Message Date
The Immortal
9bb97f0228 Random Battle: Update forme generation 2020-05-01 08:18:29 +04:00
Guangcong Luo
826e544b65 Refactor random set generation
The whole `checkBattleForme` system, introduced in 4410843e5a
and currently used in Gen 6 and 7, seems to have always been bugged.

As TI mentions in #5970, we already use `getPokemonPool` for alternate
forme handling.

I've replaced it with a roll for cosmetic formes.
2020-04-30 17:52:04 -07:00
Guangcong Luo
2b83a5ed51 Support Unown formes
This adds Unown formes as true cosmetic formes, and also applies word
filters to them.
2020-04-30 14:16:56 -07:00
Marty-D
15e4d4f2bd
Gen I-IV: Correctly treat both players having no Pokemon left as a tie 2020-04-30 14:01:32 -04:00
Leonard Craft III
7ac868039f
Update VGC and Battle Stadium to Series 4 (#6605) 2020-04-30 21:51:04 +04:00
Marty-D
294a44b943 Gen II: Don't check for secondary effects if the target fainted
This includes self-boost secondaries like Metal Claw.

Thanks again, UPC!
2020-04-30 13:33:21 -04:00
Kirk Scheibelhut
4afdd7b947 Fix otherFormes capitalization in gen7/pokedex.ts 2020-04-29 23:31:45 -07:00
Kirk Scheibelhut
edddcb5c38
Correct Self-Destruct and Explosion base power (#6630)
As confirmed by SadisticMystic, base power cannot be above 255, so
this move data is clearly incorrect and results in downstream users
of the data files such as the Smogon or PS dex or the tooltips
displaying misleading information.
2020-04-29 14:59:59 -07:00
Guangcong Luo
9319f68423 Remove Unown forme from locked users
Apparently our old hack was to prevent Unown formes completely, because
locked users would sometimes use them to spell bad words.

I don't like that approach, so now only locked users can't use Unown
formes.
2020-04-29 14:15:04 -07:00
Guangcong Luo
9209201f1c Improve pokedex changesFrom/battleOnly validation 2020-04-29 14:15:04 -07:00
whales
505643144f Mafia: Bugfixes 2020-04-29 16:30:20 +09:30
Kris Johnson
8b9f24e8c1
Remove redundant code from mods/gen1/pokedex.ts (#6629) 2020-04-28 22:17:07 -07:00
Guangcong Luo
8884e9d377 Fix Alcremie cosmetic forme names 2020-04-28 17:40:41 -07:00
Guangcong Luo
1e9d9ef7c3 Update FORMES.md documentation for changesFrom
(Also clarify Gigantamax information.)
2020-04-28 17:40:23 -07:00
Guangcong Luo
800d8bd8f3 Remove Dex.getForme etc
The server now uses the same approach as the client of treating
cosmetic formes as real formes, as documented in `FORMES.md`.

This eliminates the need for the `.forme` and `.speciesid` properties
of `Pokemon`.

`pokemon.id` has also been removed: useful, since it turns out half
of its uses were bugs that should have used `pokemon.species.id`.
2020-04-28 17:38:54 -07:00
Guangcong Luo
42f949a0ed Remove egg group info from Gen 1 Pokédex 2020-04-28 16:25:35 -07:00
Kris Johnson
1bb842e099
Convert evos/prevo/etc from IDs to names (#6625) 2020-04-28 16:02:50 -07:00
1Mitsuki
c6473abccb
Change the Portuguese translation for groups (#6628) 2020-04-28 11:05:27 -07:00
Kris Johnson
22ee763c02
Add Balanced Hackmons suspect notice (#6627)
https://www.smogon.com/forums/threads/ss-bh-suspect-test-3-break-free.3663202/
2020-04-27 22:42:35 -07:00
urkerab
1ede5508aa
Moxie and Beast Boost should have one combined boost for all fainted Pokémon. (#6557)
In addition, they should not activate for a spread move that ends the game.
(This contrasts with Soul-Heart, which will activate until the last target.)
2020-04-27 15:44:33 -07:00
Kris Johnson
839c835752
Move Venusaur to UUBL (#6626)
https://www.smogon.com/forums/threads/np-ss-uu-stage-3-as-the-world-falls-down-mamoswine-banned.3661513/page-5#post-8445057
2020-04-27 16:47:11 -04:00
urkerab
8476a24318
Shell Trap should not power up if hit by a Z- or Max move (#6622) 2020-04-27 08:04:49 -07:00
Guangcong Luo
5d57aaaedf Fix Imprison test
I'm pretty sure the old Imprison test was straight-up wrong, and based
on the old bugged behavior.
2020-04-26 18:21:02 -07:00
Guangcong Luo
e8e3493c40 Fix Struggle activation conditions
PS wasn't correctly detecting `disabled: 'hidden'` moves as disabled
for the purposes of detecting Struggle activation. This has been fixed.

Thanks to DaWoblefet for unit tests!

Fixes #6620
2020-04-26 17:52:06 -07:00
Guangcong Luo
bfe651bd12 Fix Gen 1 gender
It was apparently broken by the TypeScript refactor.
2020-04-26 17:52:06 -07:00
Guangcong Luo
987eb08ad2 Fix gmaxPower location 2020-04-26 17:52:06 -07:00
Kris Johnson
f7053eb7cd
Update Defog's description (#6624) 2020-04-26 16:27:43 -07:00
Kris Johnson
979be98574
Refactor inheritsFrom to changesFrom (#6611) 2020-04-26 14:44:25 -07:00
urkerab
fce96d8a15
Pass the Transform or Imposter effect to onModifySpecies (#6623) 2020-04-26 14:12:10 -07:00
Austin Couturier
2ea1e00ef2
Mention TypeScript in /git (#6617) 2020-04-26 10:53:16 -07:00
ACakeWearingAHat
c7431fb8cd
Random Doubles update (#6618) 2020-04-26 06:01:10 +04:00
Lusamine
b8885dd360
Update datacenters & ip-tools (#6619) 2020-04-25 17:00:21 -07:00
AnnikaCodes
65fe886111
Don't broadcast errors in !formathelp (#6616) 2020-04-25 14:05:15 -07:00
Kirk Scheibelhut
30defec706
Validate that SpA and SpD EVs match in Gen 2 (#6615)
Pointed out by FOMG in https://www.smogon.com/forums/threads/gen-2-ps-development-post-bugs-here.3524926/post-8439815
2020-04-25 13:01:02 -07:00
Guangcong Luo
c5faebd739 Remove extraneous properties from BasicEffect
BasicEffect always had a `status` property to support the pattern of
testing it to see if it's a move that sets status directly.

This is just a situation that TypeScript is bad at.

Another possibility would be to set `status: undefined` on PureEffect,
Ability, Item, and Species, but I think that's also ugly. Casting to
Move is probably the best approach, so that's what we do now.
2020-04-25 12:57:46 -07:00
Guangcong Luo
549ef7edb1 Fix MoveData interface definition
For historical reasons, move property definitions have been very blurry
across `EffectData`. Fortunately, recent refactors have made it
possible to put them all where they're supposed to be.
2020-04-25 12:57:46 -07:00
Guangcong Luo
e091679408 Support Config.debugvalidatorprocesses
Like Config.debugsimprocesses, this can be used to track down queries causing
infinite loops.
2020-04-25 15:55:05 -04:00
Guangcong Luo
1dada44a2a Support server/chat-plugins/private as symlink 2020-04-25 15:51:11 -04:00
Kirk Scheibelhut
c8b4213e16
Change Clangorous Soul self damage from 1/3 -> 33% (#6608)
Per SadisticMystic:

"https://docs.google.com/spreadsheets/d/15r_-iUngMDoA9ux7tCkUJLJVBeQhpIzEH7rju9fgWOQ/edit
the "Moves" tab is a dump of move data from the game, CS has a "-33"
listed under the Heal% field, just like Double-Edge has under
Drain%"
2020-04-25 13:33:16 -04:00
Guangcong Luo
6a685df8c7 Fix crashes when hotpatching chat
(Also fix a mistaken thing-of-the-day refactor: I blame giving two
different variables the same name.)
2020-04-25 11:11:24 -04:00
Astrid Halberkamp
3bbb36d491 TOTD: small fixes and upgrades 2020-04-25 17:06:39 +02:00
Astrid Halberkamp
008ff20dd8 Use better chatfilter handling in /makegroupchat 2020-04-25 17:06:39 +02:00
asgdf
8eb0c6a904
Fix typo in USM OU banlist link (#6614) 2020-04-25 10:41:53 -04:00
urkerab
554cb570a7
Dancer should not activate if the holder fainted (#6613) 2020-04-25 09:55:13 -04:00
Kirk Scheibelhut
66e4bac94c
Give Struggle 10 PP in Gen 1 (#6609) 2020-04-25 09:53:58 -04:00
The Immortal
d2bd85aede Random Battle improvements 2020-04-25 16:14:50 +04:00
The Immortal
7441eb6ea6 Random Doubles: Update level formula 2020-04-25 15:03:18 +04:00
Kris Johnson
7f3ddf89ad
BW2 PU: Update banlist (#6612)
https://www.smogon.com/forums/threads/pu-old-gens-discussion-bw-pu-revamp-phase-2.3597643/page-2#post-7326932
2020-04-24 22:07:39 -07:00
Jeremy Piemonte
dcfbada1ad
Blackjack: Do not require an autostart to create (#6607)
Bug introduced in 36d6dc8b0c (diff-797aaa7fdf5beb7302351b8ad019da67)
2020-04-24 20:14:19 -07:00
Kris Johnson
0b014096f9
Weezing's hidden ability is released (#6610) 2020-04-25 05:32:52 +04:00