ESLint has a whole new config format, so I figure it's a good time to
make the config system saner.
- First, we no longer have separate eslint-no-types configs. Lint
performance shouldn't be enough of a problem to justify the
relevant maintenance complexity.
- Second, our base config should work out-of-the-box now. `npx eslint`
will work as expected, without any CLI flags. You should still use
`npm run lint` which adds the `--cached` flag for performance.
- Third, whatever updates I did fixed style linting, which apparently
has been bugged for quite some time, considering all the obvious
mixed-tabs-and-spaces issues I found in the upgrade.
Also here are some changes to our style rules. In particular:
- Curly brackets (for objects etc) now have spaces inside them. Sorry
for the huge change. ESLint doesn't support our old style, and most
projects use Prettier style, so we might as well match them in this way.
See https://github.com/eslint-stylistic/eslint-stylistic/issues/415
- String + number concatenation is no longer allowed. We now
consistently use template strings for this.
TypeScript 4.8+ supports Lowercase for lowercase strings, which isn't
exactly what ID is, but can be used to type IDs in object keys and data
entries that previously required string. I'm calling it IDEntry in places
where it should be an ID but TypeScript doesn't support that.
Very conveniently, no additional casts will be needed when using ID
where IDEntry is expected.
It's caught at least a few bugs, which is also why I'm PRing: I didn't
write the code for the bugs it found, and don't know if it's the right
way to fix them.
This ballooned into several other type refactors.
* Protect/Detect/Endure don't exist in gen 1
* Add twoturnmove condition to gen 1
* Gens 1-2: Mirror Move fails immediately after a switch
* Fix first Mirror Move test: Fearow was getting OHKO'd by Hyper Beam
* pokemon.lastMove (for Mirror Move) isn't updated with the charging turn
* Remove unnecessary code
* Add onTryMove for each two-turn move with removeVolatile('twoturnmove')
* Sleep, Freeze, partial trapping, flinch don't stop two turn moves
* Para/confusion stops thrashing moves + copy over lockedmove condition details instead of inheriting
* Remove some unnecessary code
* Add Dig/Fly invulnerability glitch
* Add hint for Dig/Fly invulnerability glitch
* Gen 1 Japanese and Stadium
* put Dig before Fly
* Self-targeted moves (e.g. Recover) will work while semi-invulnerable
* Revert changes to lockedmove, do them in a future patch
* move ends if it fails due to disable
* Two-turn moves use PP in their second turn
* restore mocharc
* Remove unnecessary code
* Fix PP usage for Metronome/Mirror Move calling two-turn moves
* Gen 1: SonicBoom can be Countered
* OHKO moves do 65535 damage (matters for Counter against sub)
* Move damage comparison with target hp outside getDamage()
* Remove a blank line
* Move damage comparison with target hp outside getDamage() (Stadium)
* Add counter test
* Fix Metronome not failing if calling Counter (move setting lastDamage before tryMoveHit)
* Do the same for Stadium
* Start phasing out pokemon.lastDamage from Gen 1 code
* Failed Counter doesn't zero lastDamage
* When a move misses, battle.lastDamage is set to 0
* Remove all pokemon.lastDamage
* Remove a couple of comments
* Gen 1: Fix Wrap against a substitute
* Gen 1: Fix Wrap when it hits Ghosts behind a substitute
* Remove unnecessary 'else' statement
* Fix Stadium as well
* Fix Gen 1 Japanese as well
* Gen 1: Fix Counter interaction with Substitute
* reverse an unintentional empty line delete
* reverse an unintentional empty line delete
* updating a couple of comments
* Update gen 1 Japanese version as well
* Update test/sim/moves/counter.js
Co-authored-by: pyuk-bot <msaimrkon@gmail.com>
* Update test/sim/moves/counter.js
Co-authored-by: pyuk-bot <msaimrkon@gmail.com>
Co-authored-by: pyuk-bot <msaimrkon@gmail.com>
For side conditions, `onStart`/`onRestart`/`onResidual`/`onEnd`
have been renamed `onSideStart`/`onSideRestart`/`onSideResidual`/`onSideEnd`,
with the `onResidualOrder` properties renamed `onSideResidualOrder`.
For field conditions, `onStart`/`onRestart`/`onResidual`/`onEnd`
have been renamed `onFieldStart`/`onFieldRestart`/`onFieldResidual`/`onFieldEnd`,
with the `onResidualOrder` properties renamed `onFieldResidualOrder`.
(The `onField` and `onSide` part helps make it clear to the type system
that the first argument is a Field or Side, not a Pokemon.)
Side and field conditions can now use `onResidual` to tick separately
on each pokemon in Speed order. `onResidualOrder` (the per-pokemon
tick) can be timed separate from `onSideResidualOrder` (the
per-condition tick), allowing conditions to end at a different priority
than they tick per-pokemon.
Relatedly, `onTeamPreview` and `onStart` in formats now need to be
`onFieldTeamPreview` and `onFieldStart`.
Unrelatedly, `effectData` has been renamed `effectState`, and the
corresponding state containers (`pokemon.statusData`,
`pokemon.speciesData`, `pokemon.itemData`, `pokemon.abilityData`,
`field.weatherData`, `field.terrainData`) have been similarly renamed. I
renamed the types a while ago, but I was holding off renaming the fields
because it would be a breaking change. But this is a breaking change
anyway, so we might as well do it now.
Note: `onResidual` will tick even on `onSideEnd` turns, although
`onSideResidual` won't. When refactoring weather, remember to
check `this.state.duration` so you don't deal weather damage on the
ending turn.
Intended as a better fix for #8216
