* POTD: add a broadcast when each battle starts, stating the Pokemon of the Day
* POTD species should be set before getting information about species (affects type counts when generating team)
Gen 3:
some set tweaks
3 Physical attacks + Fire Blast gives Choice Band
Gen 4:
Mismagius: add Trick, so that it can rarely generate choiced sets
Umbreon can now get Wish + Moonlight, but not with Protect
Ditto will get Salac Berry or Sitrus Berry
Pidgeot, Fearow, and Farfetch'd have Heat Wave added, which will result in Life Orb sets for the first two
Gen 5:
Pikachu: remove Thunderbolt, add Volt Tackle
Dugtrio gets a fixed Life Orb set
Gens 6 and 7:
Dusknoir: remove Focus Punch
Pokemon with Rock Head/Water Absorb as possible abilities will never get Swift Swim as their ability, unless they have Rain Dance in their set
Dustox will no longer get Quiver Dance + U-Turn (the change to gen8/random-teams.ts has no effect on any gen 8 sets)
Slow Pokemon (< 90 base speed) will no longer get Life Orb with Volt Switch
Gen 6:
Rework Malamar's set
Kangaskhan-Mega will not get Seismic Toss with Power-Up Punch
Cloyster should always get Icicle Spear with Shell Smash
Focus Sash bulk threshold has been reduced from <= 275 to < 255
remove Cherrim-Sunshine set, add HP Ice to Cherrim
Gen 7:
Reshiram should always get Blue Flare
tweak Ninetales and Ninetales-Alola's sets
* Changes on the pinned list
* Implement other changes
* linting
* 3 Special attacks + U-Turn = Choice
* Toxic Orb if Quick Feet
* Tauros should get Life Orb and Sheer Force
* Add Quick Feet rejection condition
* Update data/mods/gen8bdsp/random-teams.ts
---------
Co-authored-by: Kris Johnson <11083252+KrisXV@users.noreply.github.com>
* Gen 8 Battle Factory: Remove Band set from Ubers Darmanitan-Galar
Credentials: https://cdn.discordapp.com/attachments/1042959218208157696/1067534457160089731/image.png (i am "lost wind's elegy")
Darm-G's firepower is just fine with scarf; there aren't many (if any?) relevant 1hkos or 2hkos you miss out on compared to band. The only one I can think of is missing out on the OHKO vs Sp. Def Necrozma Dusk Mane, and nobody's leaving their NDM in anyway + you probably have like 12 other things to deal with it.
Without scarf, however, you miss out on really good source of offensive checking and revenge killing potential. Scarf outspeeds huge threats like non scarf Yveltal, Eternatus, Calyrex-Shadow, etc.
What sparks had to say about band darm in proper SS Ubers:
sparks — Today at 1:53 PM
not really but with band building needs to be more focused cos the speed over the 90s and etern etc is insane with scarf
sparks — Today at 1:54 PM
while with band you're very much focused on "how to take out ndm and capitalize while not being weak to ho"
As a secondary factor, it would make Ubers in BF a lot better. Currently you have to not only win the coinflip of what move Darm clicks but also the coinflip of what item it is. Both of these are more or less up to random chance.
* Update data/mods/gen8/factory-sets.json
---------
Co-authored-by: Kris Johnson <11083252+KrisXV@users.noreply.github.com>
* Gen 2: revert Mirror Move fix, since it is bugging Encore
* Use a volatile for checking if a Pokemon has a last move for Mirror Move purposes
* conversion2
* Disable
* Mimic
* Spite
* Do mirror move in onTryHit
* Gen 1 shouldn't inherit onTryHit for mirror move and mimic
* Commenting
* Instead of using a volatile, add a new field for a pokemon 'lastMoveEncore' used only in gen 2 and only for Encore
* Add test for Gen 2 Encore
* Gen 1: Fix Tangela's set
* Gen 3: replace Counter with Rest on Politoed, and give Skarmory Whirlwind instead of Roar
* Gen 6-7: Fix Expert Belt condition
* Gen 5: allow Specs Kyogre and Typhlosion
* Gen 5: set changes
* Gen 5: Change Mewtwo set and move enforcement for Psychic types with Calm Mind
* Gen 5: Re-add Ice Shard to Cloyster, only allowed if not Shell Smash
* Gen 5: Reflect and Light Screen should usually be generated together
* Gen 3: Remove Refresh from Latios, allow mono-attacking Latias with Refresh
* Gen 3: Deal with unobtainable moves
* Gen 5: Fix Priority + trick/switcheroo condition
* Gen 2: set changes
* Gen 2: remove unobtainable Zapdos moves
* Gen 3: Return is better on farfetch'd
* Copy everything from Gen 2 thrashing condition and stop inheriting
* Remove residual and MoveAborted events (don't occur in gen 1)
* effectState.duration --> effectState.time, so that thrashing pauses on slp/frz/flinch/partial trapping. Also, confusion is now applied before the final Thrash hits (but after confusion check, so the final Thrash won't be interrupted)
* Confusion is only applied if Thrashing effect ends naturally, not due to full para/confusion
* Thrash should lock the user in, even if it misses/hits a Ghost/etc
* Add Thrash tests: duration and locking in the user when it misses
* Thrash locks in the user even if it breaks a sub
* Remove unnecessary events for thrashing moves
* Thrash is paused when the user is asleep, frozen, partially trapped, or flinching
* Thrash is paused when disabled
* Rage duration is permanent, not 255
* Implement Rage/Thrash accuracy bug (need to change when lockedmove volatile is removed
* Move location of applying thrashing effect, so that the final turn will be subject to accuracy bug
* Add test for Thrash accuracy bug
* Add test for Rage accuracy bug
* Remove useless line
* Use an event for obtaining accuracy of Rage/Thrash
* Revert last change
* Gen 4: remove Unaware from Bibarel
* Gen 4: prevent Dragon Pulse + Draco Meteor
* Gen 2: Gligar and TTar set changes + count Screech as a physical setup move
* Gen 2: Enforce STAB Flying on Gligar (futureproofing for if its movepool is expanded)
* Gens 6-7: give Sunflora Specs set
* Gen 6: Remove Bullet Seed from Mega Heracross
* Gen 6: give Sigilyph Flame Orb
* Gens 6-7: make Light Screen and Reflect equally likely
* more movepool changes in gen 6
* Gen 6: require recovery on support Pokemon
* Guarantee Milk Drink in gen 6 and Moonlight on pure Psychics in gens 6-7
* no Cloud Nine on Altaria (gens 5-6)
* Gen 5: guarantee Milk Drink on Miltank
* Gen 5: guarantee Moonlight on non-TR Musharna and Cresselia
* Gen 5: replace HP fighting with Focus Blast on mrmime
* Gen 5: give Sigilyph Flame Orb
* Fix Trick Room check
* Gen 2 Random Battles update
* Remove some culling conditions that never occur
* Remove illegal moves
* Fix Bellossom: Razor Leaf + Leech Seed is illegal
* Protect/Detect/Endure don't exist in gen 1
* Add twoturnmove condition to gen 1
* Gens 1-2: Mirror Move fails immediately after a switch
* Fix first Mirror Move test: Fearow was getting OHKO'd by Hyper Beam
* pokemon.lastMove (for Mirror Move) isn't updated with the charging turn
* Remove unnecessary code
* Add onTryMove for each two-turn move with removeVolatile('twoturnmove')
* Sleep, Freeze, partial trapping, flinch don't stop two turn moves
* Para/confusion stops thrashing moves + copy over lockedmove condition details instead of inheriting
* Remove some unnecessary code
* Add Dig/Fly invulnerability glitch
* Add hint for Dig/Fly invulnerability glitch
* Gen 1 Japanese and Stadium
* put Dig before Fly
* Self-targeted moves (e.g. Recover) will work while semi-invulnerable
* Revert changes to lockedmove, do them in a future patch
* move ends if it fails due to disable
* Two-turn moves use PP in their second turn
* restore mocharc
* Remove unnecessary code
* Fix PP usage for Metronome/Mirror Move calling two-turn moves
* Prevent same type STAB when undesirable
* Heracross only gets Guts if it has Facade and would get an orb
* Add Roost to Gliscor
* Guarantee recovery on support/defensive mons
* linting
* Implement Heracross condition more efficiently
* easier Gliscor case
* Update data/mods/gen5/random-teams.ts
Co-authored-by: ACakeWearingAHat <45981036+ACakeWearingAHat@users.noreply.github.com>
* linting
Co-authored-by: ACakeWearingAHat <45981036+ACakeWearingAHat@users.noreply.github.com>
