From eaa8b79148c02fa91debfd1068420269b297ad92 Mon Sep 17 00:00:00 2001 From: Ridaz Date: Fri, 1 Aug 2014 01:34:37 +0100 Subject: [PATCH] Optimizing /weakness command Aesthetic changes and smoothing up the code http://i.imgur.com/OIl0Mrd.png --- config/commands.js | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/config/commands.js b/config/commands.js index 0cacaf8b95..df25ad603a 100644 --- a/config/commands.js +++ b/config/commands.js @@ -682,23 +682,12 @@ var commands = exports.commands = { } }); - var buffer = "" + target + " (ignoring abilities):
" - if (!weaknesses.length) { - buffer += " No weaknesses;
"; - } else { - buffer += " Weaknesses: " + weaknesses.join(", ") + ";
" - } - if (!resistances.length) { - buffer += " No resistances;" - } else { - buffer += " Resistances: " + resistances.join(", ") + ";
"; - } - if (!immunities.length) { - buffer += " No immunities."; - } else { - buffer += " Immunities: " + immunities.join(", ") + "
"; - } - this.sendReplyBox(buffer); + var buffer = [] + buffer.push(pokemon.exists ? "" + target + ' (ignoring abilities):' : '' + target + ':') + buffer.push('Weaknesses: ' + (weaknesses.join(', ') || 'None')); + buffer.push('Resistances: ' + (resistances.join(', ') || 'None')); + buffer.push('Immunities: ' + (immunities.join(', ') || 'None')); + this.sendReplyBox(buffer.join('
')); }, eff: 'effectiveness',