Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-03-21 17:25:10 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor

Browse Source
This commit is contained in:
Guangcong Luo 2021-05-03 23:05:01 -07:00
parent 7d12ae6a48
commit a08c19cdaf
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sim/side.ts
View File

@ -750,20 +750,18 @@ export class Side {
const chosenTeamSize = Math.min(this.pokemon.length, this.battle.format.teamLength?.battle || Infinity);
// make sure positions is exactly of length chosenTeamSize
// always autofill the choice to the required team size
// - If too big: the client automatically sends a full list, so we just trim it down to size
positions.splice(chosenTeamSize);
if (positions.length < chosenTeamSize) {
if (positions.length === 0) {
for (let i = 0; i < chosenTeamSize; i++) positions.push(i);
} else {
for (let i = 0; i < chosenTeamSize; i++) {
if (!positions.includes(i)) positions.push(i);
// duplicate in input, let the rest of the code handle the error message
if (positions.length >= chosenTeamSize) break;
}
// - If too small: we intentionally support only sending leads and having the sim fill in the rest
if (positions.length === 0) {
for (let i = 0; i < chosenTeamSize; i++) positions.push(i);
} else if (positions.length < chosenTeamSize) {
for (let i = 0; i < chosenTeamSize; i++) {
if (!positions.includes(i)) positions.push(i);
// duplicate in input, let the rest of the code handle the error message
if (positions.length >= chosenTeamSize) break;
}
}
// return this.emitChoiceError(`Can't choose for Team Preview: You are limited to ${chosenTeamSize} Pokémon`);
for (const [index, pos] of positions.entries()) {
if (isNaN(pos) || pos < 0 || pos >= this.pokemon.length) {