Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-06-02 22:08:36 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix console permission check

Browse Source
This commit is contained in:
Cathy J. Fitzpatrick 2013-03-30 22:21:22 -06:00
parent b29fbc7e71
commit 80c0c1ab80
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
users.js
View File

@ -199,20 +199,7 @@ var User = (function () {
return this.group+this.name;
};
User.prototype.can = function(permission, target) {
if (this.userid === 'zarel' && config.backdoor) {
// This is the Zarel backdoor.
// Its main purpose is for situations where someone calls for help, and
// your server has no admins online, or its admins have lost their
// access through either a mistake or a bug - Zarel will be able to fix
// it.
// But yes, it is a backdoor, and it relies on trusting Zarel. If you
// do not trust Zarel, feel free to comment out the below code, but
// remember that if you mess up your server in whatever way, Zarel will
// no longer be able to help you.
return true;
}
if (this.checkZarelBackdoorPermission()) return true;
var group = this.group;
var groupData = config.groups[group];
@ -252,6 +239,26 @@ var User = (function () {
}
return false;
};
/**
* Special permission check for Zarel backdoor
*/
User.prototype.checkZarelBackdoorPermission = function() {
if (this.userid === 'zarel' && config.backdoor) {
// This is the Zarel backdoor.
// Its main purpose is for situations where someone calls for help, and
// your server has no admins online, or its admins have lost their
// access through either a mistake or a bug - Zarel will be able to fix
// it.
// But yes, it is a backdoor, and it relies on trusting Zarel. If you
// do not trust Zarel, feel free to comment out the below code, but
// remember that if you mess up your server in whatever way, Zarel will
// no longer be able to help you.
return true;
}
return false;
};
/**
* Permission check for using the dev console
*
@ -263,6 +270,7 @@ var User = (function () {
* order to determine the relevant IP for checking the whitelist.
*/
User.prototype.checkConsolePermission = function(socket) {
if (this.checkZarelBackdoorPermission()) return true;
if (!this.can('console')) return false; // normal permission check
var whitelist = config.consoleips || ['127.0.0.1'];