Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-09-14 12:15:44 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor getFormat pattern and ordering for speed

Browse Source 
Even though 31c6a32 added caching to make this method less of a
hotspot, there's no reason to use a pattern which is an order of
magnitude slower (https://jsperf.com/pokemon-showdown-getEffect).
Also, rearranges Format to get checked first as pkmn.cc/optimize
finds it to be the most frequently accessed.
This commit is contained in:
Kirk Scheibelhut
2019-02-21 11:54:22 -08:00
parent fc2eda1cf7
commit 7a2024525a
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
sim/dex.js
View File

@@ -495,19 +495,18 @@ class ModdedDex {
}
let id = toId(name);
if (this.data.Statuses.hasOwnProperty(id)) {
effect = new Data.PureEffect({name}, this.data.Statuses[id]);
} else if (this.data.Movedex.hasOwnProperty(id) && this.data.Movedex[id].effect) {
name = this.data.Movedex[id].name || name;
effect = new Data.PureEffect({name}, this.data.Movedex[id].effect);
} else if (this.data.Abilities.hasOwnProperty(id) && this.data.Abilities[id].effect) {
name = this.data.Abilities[id].name || name;
effect = new Data.PureEffect({name}, this.data.Abilities[id].effect);
} else if (this.data.Items.hasOwnProperty(id) && this.data.Items[id].effect) {
name = this.data.Items[id].name || name;
effect = new Data.PureEffect({name}, this.data.Items[id].effect);
} else if (this.data.Formats.hasOwnProperty(id)) {
effect = new Data.Format({name}, this.data.Formats[id]);
let found;
if ((found = this.data.Formats[id])) {
effect = new Data.Format({name}, found);
} else if ((found = this.data.Statuses[id])) {
effect = new Data.PureEffect({name}, found);
} else if ((found = this.data.Movedex[id]) && found.effect) {
effect = new Data.PureEffect({name: found.name || name}, found.effect);
} else if ((found = this.data.Abilities[id]) && found.effect) {
effect = new Data.PureEffect({name: found.name || name}, found.effect);
} else if ((found = this.data.Items[id]) && found.effect) {
effect = new Data.PureEffect({name: found.name || name}, found.effect);
} else if (id === 'recoil') {
effect = new Data.PureEffect({name: 'Recoil', effectType: 'Recoil'});
} else if (id === 'drain') {