Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-04-26 02:39:38 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix defaultLevel

Browse Source 
defaultLevel should not be set to maxLevel if this would make teams break
maxTotalLevel.

Fixes a bug where level 100 pokemon were automatically set to higher
levels in cases where it didn't make sense.
This commit is contained in:
Guangcong Luo 2021-05-26 01:18:52 -04:00
parent 2d28dc4966
commit 743153ac32
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sim/dex-formats.ts
View File

@ -211,7 +211,7 @@ export class RuleTable extends Map<string, string> {
this.minSourceGen = Number(this.valueRules.get('minsourcegen')) || 1;
this.minLevel = Number(this.valueRules.get('minlevel')) || 1;
this.maxLevel = Number(this.valueRules.get('maxlevel')) || 100;
this.defaultLevel = Number(this.valueRules.get('defaultlevel')) || this.maxLevel;
this.defaultLevel = Number(this.valueRules.get('defaultlevel')) || 0;
this.adjustLevel = Number(this.valueRules.get('adjustlevel')) || null;
this.adjustLevelDown = Number(this.valueRules.get('adjustleveldown')) || null;
this.evLimit = Number(this.valueRules.get('evlimit')) || null;
@ -249,6 +249,16 @@ export class RuleTable extends Map<string, string> {
throw new Error(`Max move count ${this.maxMoveCount}${this.blame('maxmovecount')} is unsupported (we only support up to 24)`);
}
if (!this.defaultLevel) {
// defaultLevel will set level 100 pokemon to the default level, which can break
// Max Total Level if Max Level is above 100.
const maxTeamSize = this.pickedTeamSize || this.maxTeamSize;
if (this.maxTotalLevel && this.maxLevel > 100 && this.maxLevel * maxTeamSize > this.maxTotalLevel) {
this.defaultLevel = 100;
} else {
this.defaultLevel = this.maxLevel;
}
}
if (this.minTeamSize && this.minTeamSize < gameTypeMinTeamSize) {
throw new Error(`Min team size ${this.minTeamSize}${this.blame('minteamsize')} must be at least ${gameTypeMinTeamSize} for a ${format.gameType} game.`);
}