Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-05-31 21:02:23 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Pokémon cannot megaevolve to themselves

Browse Source 
- Rename randbats helper function `canMegaEvo` to `hasMegaEvo`.
- Move duplicate mega evolution possibility checks from `runMegaEvo` and BattlePokemon constructor to `canMegaEvo` battle script.
This commit is contained in:
Ivo Julca 2015-01-30 20:54:34 -05:00
parent cb5333a025
commit 6607d1c53b
3 changed files with 31 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
battle-engine.js
View File

@ -202,9 +202,6 @@ BattlePokemon = (function () {
this.baseAbility = toId(set.ability);
this.ability = this.baseAbility;
this.item = toId(set.item);
var forme;
if (this.baseTemplate.otherFormes) forme = this.battle.getTemplate(this.baseTemplate.otherFormes[0]);
this.canMegaEvo = ((this.battle.getItem(this.item).megaEvolves === this.baseTemplate.baseSpecies) || (forme && forme.isMega && forme.requiredMove && this.set.moves.indexOf(toId(forme.requiredMove)) > -1));
this.abilityData = {id: this.ability};
this.itemData = {id: this.item};
this.speciesData = {id: this.speciesid};
@ -243,6 +240,8 @@ BattlePokemon = (function () {
}
}
this.canMegaEvo = this.battle.canMegaEvo(this);
if (!this.set.evs) {
this.set.evs = {hp: 84, atk: 84, def: 84, spa: 84, spd: 84, spe: 84};
}
@ -1333,7 +1332,7 @@ BattleSide = (function () {
baseAbility: pokemon.baseAbility,
item: pokemon.item,
pokeball: pokemon.pokeball,
canMegaEvo: pokemon.canMegaEvo
canMegaEvo: !!pokemon.canMegaEvo
});
}
return data;
@ -3355,7 +3354,7 @@ Battle = (function () {
this.runMove(decision.move, decision.pokemon, this.getTarget(decision), decision.sourceEffect);
break;
case 'megaEvo':
if (this.runMegaEvo) this.runMegaEvo(decision.pokemon);
if (decision.pokemon.canMegaEvo) this.runMegaEvo(decision.pokemon);
break;
case 'beforeTurnMove':
if (!decision.pokemon.isActive) return false;

11
data/moves.js
View File

@ -10673,11 +10673,14 @@ exports.BattleMovedex = {
this.cancelMove(sources[i]);
// Run through each decision in queue to check if the Pursuit user is supposed to mega evolve this turn.
// If it is, then mega evolve before moving.
var willMegaEvo = false;
for (var j = 0; j < this.queue.length; j++) {
if (this.queue[j].pokemon === sources[i] && this.queue[j].choice === 'megaEvo') willMegaEvo = true;
if (sources[i].canMegaEvo) {
for (var j = 0; j < this.queue.length; j++) {
if (this.queue[j].pokemon === sources[i] && this.queue[j].choice === 'megaEvo') {
this.runMegaEvo(sources[i]);
break;
}
}
}
if (willMegaEvo) this.runMegaEvo(sources[i]);
this.runMove('pursuit', sources[i], pokemon);
}
}

45
data/scripts.js
View File

@ -532,25 +532,19 @@ exports.BattleScripts = {
return damage;
},
canMegaEvo: function (pokemon) {
var altForme = pokemon.baseTemplate.otherFormes && this.getTemplate(pokemon.baseTemplate.otherFormes[0]);
if (altForme && altForme.isMega && altForme.requiredMove && pokemon.moves.indexOf(toId(altForme.requiredMove)) > -1) return altForme.species;
var item = pokemon.getItem();
if (item.megaEvolves !== pokemon.baseTemplate.baseSpecies || item.megaStone === pokemon.species) return false;
return item.megaStone;
},
runMegaEvo: function (pokemon) {
if (!pokemon.canMegaEvo) return false;
var otherForme;
var template;
var item;
if (pokemon.baseTemplate.otherFormes) otherForme = this.getTemplate(pokemon.baseTemplate.otherFormes[0]);
if (otherForme && otherForme.isMega && otherForme.requiredMove) {
if (pokemon.moves.indexOf(toId(otherForme.requiredMove)) < 0) return false;
template = otherForme;
} else {
item = this.getItem(pokemon.item);
if (!item.megaStone) return false;
template = this.getTemplate(item.megaStone);
if (pokemon.baseTemplate.baseSpecies !== template.baseSpecies) return false;
}
if (!template.isMega) return false;
var template = this.getTemplate(pokemon.canMegaEvo);
var side = pokemon.side;
// Pokémon affected by Sky Drop cannot mega evolve. Enforce it here for now.
var foeActive = side.foe.active;
for (var i = 0; i < foeActive.length; i++) {
if (foeActive[i].volatiles['skydrop'] && foeActive[i].volatiles['skydrop'].source === pokemon) {
@ -558,17 +552,18 @@ exports.BattleScripts = {
}
}
// okay, mega evolution is possible
pokemon.formeChange(template);
pokemon.baseTemplate = template; // mega evolution is permanent :o
pokemon.baseTemplate = template; // mega evolution is permanent
pokemon.details = template.species + (pokemon.level === 100 ? '' : ', L' + pokemon.level) + (pokemon.gender === '' ? '' : ', ' + pokemon.gender) + (pokemon.set.shiny ? ', shiny' : '');
this.add('detailschange', pokemon, pokemon.details);
this.add('-mega', pokemon, template.baseSpecies, item);
var oldAbility = pokemon.ability;
this.add('-mega', pokemon, template.baseSpecies, template.requiredItem);
pokemon.setAbility(template.abilities['0']);
pokemon.baseAbility = pokemon.ability;
for (var i = 0; i < side.pokemon.length; i++) side.pokemon[i].canMegaEvo = false;
// Limit one mega evolution
for (var i = 0; i < side.pokemon.length; i++) {
side.pokemon[i].canMegaEvo = false;
}
return true;
},
@ -594,7 +589,7 @@ exports.BattleScripts = {
if (!isValid) selectedAbilities.push(selectedAbility);
return isValid;
},
canMegaEvo: function (template) {
hasMegaEvo: function (template) {
if (template.otherFormes) {
var forme = this.getTemplate(template.otherFormes[0]);
if (forme.requiredItem) {
@ -900,7 +895,7 @@ exports.BattleScripts = {
}
// Decide if the Pokemon can mega evolve early, so viable moves for the mega can be generated
if (!noMega && this.canMegaEvo(template)) {
if (!noMega && this.hasMegaEvo(template)) {
// If there's more than one mega evolution, randomly pick one
template = this.getTemplate(template.otherFormes[(template.otherFormes[1]) ? Math.round(Math.random()) : 0]);
}
@ -1984,7 +1979,7 @@ exports.BattleScripts = {
}
// Decide if the Pokemon can mega evolve early, so viable moves for the mega can be generated
if (!noMega && this.canMegaEvo(template)) {
if (!noMega && this.hasMegaEvo(template)) {
// If there's more than one mega evolution, randomly pick one
template = this.getTemplate(template.otherFormes[(template.otherFormes[1]) ? Math.round(Math.random()) : 0]);
}