Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-04-24 23:09:10 -05:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Gen I: Fix recovery move failure edge case (#9603)

Browse Source
This commit is contained in:
Nigel Robbins 2023-06-22 20:40:38 -07:00 committed by GitHub
parent a17c4c98fb
commit 4ffcdecbfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
data/mods/gen1/moves.ts
View File

@ -627,9 +627,15 @@ export const Moves: {[k: string]: ModdedMoveData} = {
heal: null,
onHit(target) {
if (target.hp === target.maxhp) return false;
// Fail when health is 255 or 511 less than max
if (target.hp === (target.maxhp - 255) || target.hp === (target.maxhp - 511) || target.hp === target.maxhp) {
this.hint("In Gen 1, recovery moves fail if (user's maximum HP - user's current HP + 1) is divisible by 256.");
// Fail when health is 255 or 511 less than max, unless it is divisible by 256
if (
target.hp === target.maxhp ||
((target.hp === (target.maxhp - 255) || target.hp === (target.maxhp - 511)) && target.hp % 256 !== 0)
) {
this.hint(
"In Gen 1, recovery moves fail if (user's maximum HP - user's current HP + 1) is divisible by 256, " +
"unless the current hp is also divisible by 256."
);
return false;
}
this.heal(Math.floor(target.maxhp / 2), target, target);
@ -664,9 +670,15 @@ export const Moves: {[k: string]: ModdedMoveData} = {
onTry() {},
onHit(target, source, move) {
if (target.hp === target.maxhp) return false;
// Fail when health is 255 or 511 less than max
if (target.hp === (target.maxhp - 255) || target.hp === (target.maxhp - 511)) {
this.hint("In Gen 1, recovery moves fail if (user's maximum HP - user's current HP + 1) is divisible by 256.");
// Fail when health is 255 or 511 less than max, unless it is divisible by 256
if (
target.hp === target.maxhp ||
((target.hp === (target.maxhp - 255) || target.hp === (target.maxhp - 511)) && target.hp % 256 !== 0)
) {
this.hint(
"In Gen 1, recovery moves fail if (user's maximum HP - user's current HP + 1) is divisible by 256, " +
"unless the current hp is also divisible by 256."
);
return false;
}
if (!target.setStatus('slp', source, move)) return false;
@ -762,9 +774,15 @@ export const Moves: {[k: string]: ModdedMoveData} = {
heal: null,
onHit(target) {
if (target.hp === target.maxhp) return false;
// Fail when health is 255 or 511 less than max
if (target.hp === (target.maxhp - 255) || target.hp === (target.maxhp - 511) || target.hp === target.maxhp) {
this.hint("In Gen 1, recovery moves fail if (user's maximum HP - user's current HP + 1) is divisible by 256.");
// Fail when health is 255 or 511 less than max, unless it is divisible by 256
if (
target.hp === target.maxhp ||
((target.hp === (target.maxhp - 255) || target.hp === (target.maxhp - 511)) && target.hp % 256 !== 0)
) {
this.hint(
"In Gen 1, recovery moves fail if (user's maximum HP - user's current HP + 1) is divisible by 256, " +
"unless the current hp is also divisible by 256."
);
return false;
}
this.heal(Math.floor(target.maxhp / 2), target, target);