POSTing JSON data is now supported, since apparently Axios does that by
default: #1160
In addition, error messages should be more informative, for anyone else
trying to write a third-party client.
Allows login server requests from non-matching IPs to go through when
the request is using token auth.
Affects certain request-proxying Node hosts such as c9.
See Zarel/Pokemon-Showdown@d5c622b493
New system is backwards-compatible with old one. This also slightly
refactors some other stuff, for an overall simpler system.
Right now, unregistered servers often get unclear error messages
about why laddering and replay saving doesn't work. This commit
attempts to clarify those error messages.
In addition, servers that make requests from different IPs from
their registered IP didn't have an easy way to fix. Reporting
IPs should make it clearer which IP they need to register.
This drops support for the pre-challenge-response authentication scheme
(i.e. the scheme in use before Zarel/Pokemon-Showdown@7dbd8cfec5 on
February 8, 2013), and, by doing so, simplifies quite a bit of the
authentication code.
In particular, it is no longer necessary to make any database queries in
index.php, which reduces our database use significantly and also moves us
closer to the goal of the index page being static HTML.
Previously, a bug prevented a replay from being re-uploaded if the
first replay upload failed, or if the battle continued after a
replay was uploaded. This has been fixed.
The replay upload system should be a lot less brittle now. Errors
should be rarer, and when they do happen, the error message will
be clearer.
For instance, 'hash mismatch' will happen much less often, and
when it does happen it will give the message: "Someone else is already
uploading a replay. Try again in five seconds."
