diff --git a/src/battle-animations.ts b/src/battle-animations.ts
index 251257001..3019dd693 100644
--- a/src/battle-animations.ts
+++ b/src/battle-animations.ts
@@ -746,10 +746,9 @@ class BattleScene {
// if (this.paused) url.replace('/xyani', '/xy').replace('.gif', '.png');
buf += '
';
buf2 += '
';
- if (pokemon.gender === 'F') {
- buf2 += '

';
- } else if (pokemon.gender === 'M') {
- buf2 += '

';
+ const gender = pokemon.gender;
+ if (gender === 'M' || gender === 'F') {
+ buf2 += `
}.png)
`;
}
if (pokemon.level !== 100) {
buf2 += '
L' + pokemon.level + '';
@@ -2427,9 +2426,9 @@ class PokemonSprite extends Sprite {
let buf = '
';
const ignoreNick = this.siden && (this.scene.battle.ignoreOpponent || this.scene.battle.ignoreNicks);
buf += `
${BattleLog.escapeHTML(ignoreNick ? pokemon.species : pokemon.name)}`;
- let gender = pokemon.gender;
- if (gender) {
- buf += `
`;
+ const gender = pokemon.gender;
+ if (gender === 'M' || gender === 'F') {
+ buf += `
`;
}
buf += (pokemon.level === 100 ? `` : ` L${pokemon.level}`);
diff --git a/src/battle-tooltips.ts b/src/battle-tooltips.ts
index bafbac2cc..d63a764b7 100644
--- a/src/battle-tooltips.ts
+++ b/src/battle-tooltips.ts
@@ -668,8 +668,9 @@ class BattleTooltips {
const pokemon = clientPokemon || serverPokemon!;
let text = '';
let genderBuf = '';
- if (pokemon.gender) {
- genderBuf = `
`;
+ const gender = pokemon.gender;
+ if (gender === 'M' || gender === 'F') {
+ genderBuf = `
`;
}
let name = BattleLog.escapeHTML(pokemon.name);
diff --git a/src/battle.ts b/src/battle.ts
index 04475e26d..a996043ac 100644
--- a/src/battle.ts
+++ b/src/battle.ts
@@ -706,10 +706,10 @@ class Side {
this.battle.scene.removeSideCondition(this.n, id);
}
addPokemon(name: string, ident: string, details: string, replaceSlot = -1) {
- const oldItem = replaceSlot ? this.pokemon[replaceSlot].item : undefined;
+ const oldItem = replaceSlot >= 0 ? this.pokemon[replaceSlot].item : undefined;
const data = this.battle.parseDetails(name, ident, details);
- let poke = new Pokemon(data, this);
+ const poke = new Pokemon(data, this);
if (oldItem) poke.item = oldItem;
if (!poke.ability && poke.baseAbility) poke.ability = poke.baseAbility;
@@ -2993,7 +2993,7 @@ class Battle {
}
if (!pokemon.searchid && pokemon.checkDetails(details)) {
// switch-in matches Team Preview entry
- pokemon = this.p1.addPokemon(name, pokemonid, details, i);
+ pokemon = side.addPokemon(name, pokemonid, details, i);
if (slot >= 0) pokemon.slot = slot;
return pokemon;
}
@@ -3025,7 +3025,7 @@ class Battle {
pokemonid = parsedPokemonid;
/** if true, don't match an active pokemon */
- const isInactive = (slot >= 0);
+ const isInactive = (slot < 0);
const side = this.sides[siden];
// search player's pokemon