Leahnaya/pokemon-showdown-client
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown-client.git synced 2026-10-03 16:22:48 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Auto-link URLs without closing parenthesis at end

Browse Source 
Currently Pokémon Showdown doesn't auto-link URLs properly in the
following form.

    (Check out http://play.pokemonshowdown.com/)

In this case, it's obvious that `)` not part of an URL, but the current
auto-linker believes that it is. Making `)` illegal character at end of
URL doesn't solve the problem, as sometimes URLs actually do contain
parenthesis. The new URL regex supports one level of parenthesis
(regexes don't support recursion, but if you have more than one layer
of parenthesis in an URL, you are doing something wrong). This is a
case with URLs on Wikipedia.

    https://en.wikipedia.org/wiki/Pokémon_(disambiguation)
This commit is contained in:
Konrad Borowski
2015-01-23 19:03:15 +01:00
parent 1255bfa0b0
commit 6b8b68d4ef
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/battledata.js
View File

@@ -330,7 +330,7 @@ var Tools = {
options.hidestrikethrough ? '$1' : '<s>$1</s>');
// linking of URIs
if (!options.hidelinks) {
str = str.replace(/https?\:\/\/[a-z0-9-.]+(?:\:[0-9]+)?(?:\/(?:[^\s]*[^\s?.,])?)?|[a-z0-9.]+\@[a-z0-9.]+\.[a-z0-9]{2,3}|(?:[a-z0-9](?:[a-z0-9-\.]*[a-z0-9])?\.(?:com|org|net|edu|us|jp)(?:\:[0-9]+)?|qmark\.tk)(?:(?:\/(?:[^\s]*[^\s?.,])?)?)\b/ig, function(uri) {
str = str.replace(/https?\:\/\/[a-z0-9-.]+(?:\:[0-9]+)?(?:\/(?:\([^\s()]*\)|[^\s?.,()])*)?|[a-z0-9.]+\@[a-z0-9.]+\.[a-z0-9]{2,3}|(?:[a-z0-9](?:[a-z0-9-\.]*[a-z0-9])?\.(?:com|org|net|edu|us|jp)(?:\:[0-9]+)?|qmark\.tk)\b(?:(?:\/(?:\([^\s()]*\)|[^\s?.,()])*)?)/ig, function(uri) {
if (/[a-z0-9.]+\@[a-z0-9.]+\.[a-z0-9]{2,3}/ig.test(uri)) {
return '<a href="mailto:'+uri+'" target="_blank">'+uri+'</a>';
}