Leahnaya/pokemon-showdown-client
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown-client.git synced 2026-05-09 04:23:01 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: defer ChatUserList subscription to prevent backlog loss and race conditions

Browse Source
This commit is contained in:
TurboRx 2026-04-14 08:43:11 +00:00
parent 6591e699d9
commit 60868a2d9f
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
play.pokemonshowdown.com/src/panel-chat.tsx
View File

@ -1428,12 +1428,18 @@ export class ChatUserList extends preact.Component<{
room: ChatRoom, left?: number, top?: number, minimized?: boolean, static?: boolean,
}> {
subscription: PSSubscription | null = null;
subscribeTimeout: number | null = null;
override componentDidMount() {
this.subscription = this.props.room.subscribe(args => {
if (!args) this.forceUpdate();
});
this.subscribeTimeout = window.setTimeout(() => {
this.subscribeTimeout = null;
this.subscription = this.props.room.subscribe(args => {
if (!args) this.forceUpdate();
});
this.forceUpdate();
}, 0);
}
override componentWillUnmount() {
if (this.subscribeTimeout !== null) window.clearTimeout(this.subscribeTimeout);
this.subscription?.unsubscribe();
}
render() {