Leahnaya/pokemon-showdown-client
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown-client.git synced 2026-03-21 17:50:29 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Storage: Unpack team natures properly

Browse Source 
This object is specifically indexed by name instead of ID - remote teams are sometimes lowercase. To be most comprehensive, we handle this at team unpack rather than whack-a-moling callsites.
This commit is contained in:
Mia 2025-08-08 21:57:46 -05:00
parent a24ddeb4fa
commit 10912eba24
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
play.pokemonshowdown.com/js/storage.js
View File

@ -920,6 +920,11 @@ Storage.fastUnpackTeam = function (buf) {
j = buf.indexOf('|', i);
set.nature = buf.substring(i, j);
if (set.nature === 'undefined') set.nature = undefined;
if (set.nature) {
// BattleNatures is case sensitive, so if we don't do this
// sometimes stuff breaks. goody.
set.nature = set.nature.charAt(0).toUpperCase() + set.nature.slice(1);
}
i = j + 1;
// evs
@ -1038,6 +1043,11 @@ Storage.unpackTeam = function (buf) {
j = buf.indexOf('|', i);
set.nature = buf.substring(i, j);
if (set.nature === 'undefined') set.nature = undefined;
if (set.nature) {
// BattleNatures is case sensitive, so if we don't do this
// sometimes stuff breaks. goody.
set.nature = set.nature.charAt(0).toUpperCase() + set.nature.slice(1);
}
i = j + 1;
// evs