PikalaxALT
99ec579deb
Name symbols in battle_anim_special.c
2021-03-14 16:29:33 -04:00
Deokishisu
0589bd5827
Fix Typos / Use Box Constants
...
The Celadon City scripts that give Eevee misspelled it as Eeevee. Fixed.
The comment explaining `boxRSEggsUnlocked` in the `ExternalEventFlags` struct had an incorrect deposit requirement listed and was fixed.
Also, replaced the literals with the `TOTAL_BOXES_COUNT` and `IN_BOX_COUNT` constants in `pokemon.c`'s `IsPokemonStorageFull` function. Thanks hjk321 for pointing that out.
2021-03-10 16:22:08 -05:00
Deokishisu
57e3f5e0f8
Mirror pokeemerald PR#1329 & PR#1335 to pokefirered
...
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.
The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
2021-02-16 16:56:31 -05:00
GriffinR
515dde69af
Use more LOCALID constants
2021-02-10 20:20:15 -05:00
Deokishisu
ee0fb9ea5a
Fix TM34 Transposition Typo
...
The script labels for being given TM34 from Lt. Surge are mistakenly typoed as TM43. This commit fixes this error.
2021-02-03 19:54:45 -05:00
GriffinR
66e9059578
Move pokedex_screen data from asm to C
2020-11-11 23:44:30 -05:00
Ashley Coleman
2745ac3445
Give meaningfull names to globals in pokedex_screen.s
2020-11-11 13:40:18 -08:00
GriffinR
b7a88180d3
Fix Fuchsica typo
2020-08-31 21:37:59 -04:00
GriffinR
bb56d4a3f4
Give songs meaningful english names
2020-08-29 03:11:03 -04:00
luckytyphlosion
1ad6f5270c
Port over PSS data to src.
2020-07-04 20:32:44 -04:00
luckytyphlosion
91fea55a24
pokemon_summary_screen.c, part 6.
2020-06-25 12:59:37 -04:00
PikalaxALT
94b68c54e8
Merge pull request #337 from GriffinRichards/fix-scriptlabel
...
Fix mislabeled starter script
2020-05-27 07:51:13 -04:00
GriffinR
d6a494551a
Fix corresponding mislabeled rival script
2020-05-04 14:45:07 -04:00
GriffinR
5bd2c0ef5c
Fix mislabeled starter script
2020-05-04 14:34:45 -04:00
Evan
87ba2b8bde
battle anim documentation
2020-04-23 22:40:13 -06:00
fieldy101
9634b58d7a
Port emerald water functions into firered
2020-04-22 23:30:44 +10:00
PikalaxALT
b22d3a821d
Merge branch 'master' of github.com:pret/pokefirered into modern_gcc
2020-04-10 13:10:44 -04:00
PikalaxALT
fedb2f5c0b
Merge branch 'master' of github.com:pret/pokefirered into modern_gcc
2020-04-07 11:05:48 -04:00
PikalaxALT
31ecdcdd0a
Merge branch 'master' of github.com:pret/pokefirered into various_documentation
2020-04-07 07:50:06 -04:00
PikalaxALT
c78101535b
Split quest_log.c
2020-04-06 17:58:24 -04:00
GriffinR
100188ac43
Move gfx out of data
2020-04-06 10:02:14 -04:00
PikalaxALT
a622448029
More quest log documentation amid other stuff
2020-04-05 20:30:45 -04:00
PikalaxALT
98c2df354f
Fix alignment-related crashes
2020-04-04 15:09:22 -04:00
PikalaxALT
af32535610
Name all specials
2020-03-31 08:49:47 -04:00
PikalaxALT
4134baf3eb
Some more docs in battle anims
2020-03-31 07:55:32 -04:00
PikalaxALT
b31317889d
Partial doc of battle anim utility funcs
2020-03-30 08:52:49 -04:00
PikalaxALT
19812c9d18
Decoration data to C
2020-03-29 11:42:08 -04:00
PikalaxALT
0f618efb15
Finish overworld.c
2020-03-28 21:39:28 -04:00
PikalaxALT
781aa8949c
Merge branch 'master' of github.com:pret/pokefirered into overworld
2020-03-28 18:04:45 -04:00
PikalaxALT
d8c9214e0a
Merge pull request #314 from jiangzhengwenjz/bike
...
bike
2020-03-28 16:32:09 -04:00
PikalaxALT
f5f4d6bc1f
through InitCurrentFlashLevelScanlineEffect
2020-03-28 14:40:25 -04:00
PikalaxALT
9bcc82856d
Merge branch 'master' of github.com:pret/pokefirered into overworld
2020-03-28 12:26:00 -04:00
PikalaxALT
24ac46856a
through sub_805644C
2020-03-28 12:20:20 -04:00
PikalaxALT
816e7ad1f8
through ChooseAmbientCrySpecies
2020-03-28 10:42:23 -04:00
jiangzhengwenjz
fd7abb3d73
bike
2020-03-28 10:11:45 +08:00
GriffinR
eebe7f2233
Use trainer type constants
2020-03-27 10:21:26 -04:00
PikalaxALT
71c003dcdb
through LoadSaveblockMapHeader
2020-03-26 21:30:58 -04:00
PikalaxALT
84a69bf140
through Overworld_ResetStateAfterFly
2020-03-26 18:29:48 -04:00
PikalaxALT
402f2643bd
Merge branch 'master' of github.com:pret/pokefirered into field_player_avatar
2020-03-26 17:07:52 -04:00
GriffinR
6cf4bc4101
Label object event graphics
2020-03-26 13:39:40 -04:00
PikalaxALT
302c6bfe6b
finish field_player_avatar
2020-03-25 18:00:26 -04:00
PikalaxALT
c032dc0231
through AlignFishingAnimationFrames
2020-03-25 17:37:07 -04:00
PikalaxALT
f1841ef24d
through sub_805D1A8
2020-03-25 08:57:52 -04:00
GriffinR
f6d0a14e7f
Move remaining event_object_movement data to src
2020-03-25 01:21:31 -04:00
GriffinR
0da7681d8f
Move object event graphics to src
2020-03-25 01:14:16 -04:00
GriffinR
5b612393eb
Move data up to object event graphics to src
2020-03-25 00:57:23 -04:00
GriffinR
970717ee2c
Move object event graphics info pointers to src
2020-03-25 00:46:27 -04:00
PikalaxALT
6c964a6350
through InitPlayerAvatar
2020-03-24 20:59:37 -04:00
GriffinR
d50ce48776
Move field effect object template pointers to src
2020-03-24 20:36:52 -04:00
GriffinR
936529b3cb
Move object event pic tables to src
2020-03-24 20:31:12 -04:00
