Leahnaya/pokefirered
1
0
Fork 0
mirror of https://github.com/pret/pokefirered.git synced 2026-04-25 07:19:36 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix key repeat issue for L button in remapping

Browse Source 
Fix key repeat logic for L button in A button mode by comparing raw held keys.
This commit is contained in:
AZero13 2026-02-20 13:03:52 -05:00
parent 338ec9d956
commit 647f1f875f
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/main.c
View File

@ -277,13 +277,14 @@ static void ReadKeys(void)
// BUG: Key repeat won't work when pressing L using L=A button mode
// because it compares the raw key input with the remapped held keys.
// Note that newAndRepeatedKeys is never remapped either.
// This was fixed in later generations by comparing the raw held keys.
#ifdef BUGFIX
if (keyInput != 0 && gMain.heldKeysRaw == keyInput)
#else
if (keyInput != 0 && gMain.heldKeys == keyInput)
#endif
{
gMain.keyRepeatCounter--;
if (gMain.keyRepeatCounter == 0)
if (--gMain.keyRepeatCounter == 0)
{
gMain.newAndRepeatedKeys = keyInput;
gMain.keyRepeatCounter = gKeyRepeatContinueDelay;
@ -306,6 +307,10 @@ static void ReadKeys(void)
if (JOY_HELD(L_BUTTON))
gMain.heldKeys |= A_BUTTON;
// newAndRepeatedKeys is never remapped, but this doesn't matter in vanilla
// as it is only ever checked for D-Pad keys.
// But if you need to remap it, you can do so here.
}
if (JOY_NEW(gMain.watchedKeysMask))