Leahnaya/pokeemerald
1
0
Fork 0
mirror of https://github.com/pret/pokeemerald.git synced 2026-05-06 13:28:21 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
d1a69d7e04
pokeemerald/graphics
History
psf fe16a2cdee
Port pokefirered's Vs. Seeker to pokeemerald (#3256) 
* First version of Vs. Seeker

* Update movement.inc

98f7e9978d (r1306721924)

* Update field_effect_scripts.s

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722004

* Update field_effect_scripts.s

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722024

* Update item_use.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722401

* Update movement_action_func_tables.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722828

* Update event_object_movement.c

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306722887

* Update overworld.c

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306723396

* Update vs_seeker.h

https://github.com/rh-hideout/pokeemerald-expansion/pull/3256/files#r1306724158

* Update vs_seeker.c

Addressed some cleanup comments from SBird

* Update UpdateRandomTrainerRematches
Fixed typo in ClearAllTrainerRematchStates
Fixed types in GetRematchableTrainerLocalId

* Updated UseVsSeekerEffect_2

* Updated UseVsSeekerEffect_3

* Updated UseVsSeekerEffect_4

* Fixed bug that allowed Vs Seeker to be used indoors in correct places
Moved VsSeeker function declarations into header

* Refactored FieldUseFunc_VsSeeker

* Added curly braces to else case in FieldUseFunc_VsSeeker

* renamed data[x] in Task_ResetObjectsRematchWantedState

* Refactored Task_ResetObjectsRematchWantedState

* Refactored VsSeekerResetObjectMovementAfterChargeComplete

* Refactored ResetMovementOfRematchableTrainers

* Refactored GatherNearbyTrainerInfo

* Refactored Task_VsSeeker_3

* CanUseVsSeeker

* Refactored GetVsSeekerResponseInArea

* GetCurVsSeekerResponse refactored

* Cleaned up GetTrainerFlagFromScript

* Gave sensible names to Task_VsSeeker

* Fixed two bugs where player would not have the right gfx state after using VsSeeker on a Bike or Underwater

* Renamed UseVsSeeker Functions

* Added I_VS_SEEKER_CHARGING to make Vs. Seeker broken until flag is assigned
Removed extra VsSeeker animation code

* Addressed PR feedback

* Fixed issue with building non-modern

* Refactored GetRunningBehaviorFromGraphicsId and renamed to GetResponseMovementTypeFromTrainerGraphicsId

* Addresses Lunos's PR feedback: https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1623547850
Removed the check to see if a map was not indoors to improve readability
Made IsValidLocationForVsSeeker into a static function

* Added changes in response to Jasper's feedback
https://github.com/rh-hideout/pokeemerald-expansion/pull/3256\#pullrequestreview-1725276522

* Updated with Edu's discord feedback https://discord.com/channels/419213663107416084/1135040810082123907/1176872015085453392

* Removed ifdef tags around the repo unless needed
b5dc744ced
2023-11-26 18:58:43 +01:00
..
bag Colorize bag select button 2023-05-10 00:33:43 -04:00
balls Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
battle_anims Adds combined pledge move effects (#3336) 2023-11-21 16:23:22 +01:00
battle_frontier Fix some frontier gfx, adjacent cleanup 2023-08-03 11:15:15 -04:00
battle_interface Merge branch 'RHH/upcoming' into RHH/pr/upcoming/dynamax 2023-10-09 16:51:41 -03:00
battle_terrain
battle_transitions Fix some compressed tilemaps 2023-06-01 15:31:12 -04:00
berries Purged the bKGD warning once and for all 2023-02-24 02:01:55 -03:00
berry_blender
berry_crush Fix some colors in crusher.png 2023-01-12 19:04:49 -05:00
berry_fix Correct berry fix graphics colors, more PLTT constant use (#1892) 2023-08-09 12:49:21 -04:00
birch_speech Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
cable_car Use tilemap file for cable car pylons 2023-03-31 00:44:22 -04:00
cave_transition Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
contest Fix results_screen/tiles.png colors 2023-01-15 12:04:29 -05:00
credits Document some credits 2021-03-29 08:52:40 -04:00
decorations Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
diploma Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
dodrio_berry_picking Fix swapped Dodrio Berry Picking palettes 2023-06-05 19:53:59 -04:00
door_anims Colorize door animations that use multiple palettes 2023-01-11 13:31:17 -05:00
easy_chat Delete unreferenced palette 2021-04-01 14:32:23 -04:00
evolution_scene
expansion_intro Purged the bKGD warning once and for all 2023-02-24 02:01:55 -03:00
field_effects Port pokefirered's Vs. Seeker to pokeemerald (#3256) 2023-11-26 18:58:43 +01:00
fonts Merge branch 'master' of https://github.com/pret/pokeemerald into tx_pokedexPlus_hgss 2021-11-18 16:48:49 +01:00
frontier_pass Correct colors for frontier_pass 2023-01-13 02:25:23 -05:00
interface Add Frostbite status 2023-04-22 18:23:08 +02:00
intro Fix intro/scene_1 tiles 2023-01-14 00:48:58 -05:00
items Includes older item and move names as variants (#3580) 2023-11-20 18:35:00 +01:00
link Sync wireless improvements 2022-11-09 15:14:18 -05:00
mail
map_popup Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
misc Colorize mirage_tower.png 2023-01-12 11:40:15 -05:00
naming_screen Split naming screen palettes/graphics, use correct image palettes, clean up 2022-08-09 09:27:28 -04:00
object_events Purged the bKGD warning once and for all 2023-02-24 02:01:55 -03:00
party_menu Fix party_menu/bg colors 2023-01-14 12:32:54 -05:00
picture_frame Colorize picture_frame tiles 2023-01-13 15:30:57 -05:00
pokeblock Fix some compressed tilemaps 2023-06-01 15:31:12 -04:00
pokedex Merge branch 'RHH/pr/upcoming/reorderMonGraphics' into RHH/review/gen9mon-4 2023-11-02 21:32:23 -04:00
pokemon Gen 6 Sprites/Animations For Species (#3543) 2023-11-18 23:48:02 +01:00
pokemon_jump
pokemon_storage Added Japan-only Walda PC icons (#3550) 2023-11-18 00:54:13 +01:00
pokenav Move remaining region map graphics to region map folder 2022-02-22 18:43:23 -05:00
rayquaza_scene Colorize rayquaza_scene/scene_1/clouds.png 2023-01-12 14:56:44 -05:00
reset_rtc_screen
rotating_gates Color rotating gate pngs 2022-10-12 19:19:42 -04:00
roulette
shop Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
slot_machine Fix slot_machine/menu colors 2023-01-14 16:34:14 -05:00
spinda_spots Support plain pixel conversion, convert spinda spots to .png 2023-05-11 13:41:38 -04:00
starter_choose Colorize and combine birch_bag/birch_grass 2023-01-12 15:22:23 -05:00
summary_screen Correct colors in summary_screen/tiles.png 2023-01-12 21:41:06 -05:00
text_window
title_screen Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
trade Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
trainer_card Move FRLG trainer card gfx to own folder, fix tiles 2023-01-13 13:40:13 -05:00
trainer_hill Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
trainers Generate trainer pic palettes from image 2022-09-05 16:09:45 -04:00
types Update fairy.png 2022-08-27 22:42:05 -04:00
union_room_chat Correct some union room chat documentation 2023-02-02 11:41:02 -05:00
unused Merge branch 'battle_engine' of https://github.com/rh-hideout/pokeemerald-expansion into HEAD 2022-04-02 18:45:18 -03:00
wallclock
weather
wireless_status_screen Sync wireless improvements 2022-11-09 15:14:18 -05:00
wonder_card Fix leftover icon_shadow names 2021-10-17 03:22:55 -04:00
wonder_news Start wonder card/news documenting 2021-10-14 13:24:20 -04:00