Leahnaya/pokeemerald
1
0
Fork 0
mirror of https://github.com/pret/pokeemerald.git synced 2026-05-09 04:13:03 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix off-by-one in gbagfx

Browse Source 
We malloc one byte too little. We need to account for the null terminator.
This commit is contained in:
AZero13 2026-04-02 17:41:05 -04:00
parent 61674ecd4b
commit ccf994643b
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tools/gbagfx/main.c
View File

@ -641,22 +641,16 @@ int main(int argc, char **argv)
if (*outputFileExtension == 0)
FATAL_ERROR("Output file \"%s\" has no extension.\n", outputPath);
size_t newOutputPathSize = strlen(inputPath) - strlen(inputFileExtension) + strlen(outputFileExtension);
int prefixLen = inputFileExtension - inputPath;
size_t newOutputPathSize = prefixLen + strlen(outputFileExtension) + 1;
outputPath = malloc(newOutputPathSize);
if (outputPath == NULL)
FATAL_ERROR("Failed to allocate memory for new output path.\n");
for (int i = 0; i < newOutputPathSize; i++)
{
outputPath[i] = inputPath[i];
if (outputPath[i] == '.')
{
strcpy(&outputPath[i + 1], outputFileExtension);
break;
}
}
if (snprintf(outputPath, newOutputPathSize, "%.*s%s", prefixLen, inputPath, outputFileExtension) >= (int)newOutputPathSize)
FATAL_ERROR("Failed to build output path.\n");
}
for (int i = 0; handlers[i].function != NULL; i++)