Leahnaya/pokeemerald-expansion
1
0
Fork 0
mirror of https://github.com/rh-hideout/pokeemerald-expansion.git synced 2026-03-21 18:04:50 -05:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Remove bounds check in IsBattlerAlive

Browse Source 
There is no reason for us to check for `battler > gBattlersCount` since it would return false positives half the time. 

But also if you pass `battler > gBattlersCount` then something massively wrong happened and you would get a bug either way.
This commit is contained in:
Alex 2026-01-04 21:22:44 +01:00 committed by GitHub
parent 52455d2c59
commit d50fb2dae6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/battle.h
View File

@ -1074,9 +1074,7 @@ extern u8 gCategoryIconSpriteId;
static inline bool32 IsBattlerAlive(u32 battler)
{
if (battler >= gBattlersCount)
return FALSE;
else if (gBattleMons[battler].hp == 0)
if (gBattleMons[battler].hp == 0)
return FALSE;
else if (gAbsentBattlerFlags & (1u << battler))
return FALSE;