Leahnaya/pokecrystal
1
0
Fork 0
mirror of https://github.com/pret/pokecrystal.git synced 2026-04-25 07:24:02 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Rangi 2026-02-04 10:52:42 -05:00 committed by GitHub
parent 84fca3ad14
commit 5625f9d735
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
constants/charmap.asm
View File

@ -34,7 +34,7 @@
charmap "<TM>", $5c ; "TM"
charmap "<TRAINER>", $5d ; "TRAINER"
charmap "<ROCKET>", $5e ; "ROCKET"
charmap "<DEXEND>", $5f ; unused
charmap "<DEXEND>", $5f ; "." to end a Gen 1 Pokédex entry
; Actual characters (from gfx/font/font_extra.png)

2
engine/menus/naming_screen.asm
View File

@ -1,4 +1,4 @@
DEF NAMINGSCREEN_CURSOR EQU "┘" ; $7e
DEF NAMINGSCREEN_CURSOR EQU '┘' ; $7e
DEF NAMINGSCREEN_BORDER EQU '■' ; $60
DEF NAMINGSCREEN_MIDDLELINE EQU '→' ; $eb

13
engine/pokemon/correct_nick_errors.asm
View File

@ -60,19 +60,8 @@ CorrectNickErrors::
pop bc
ret
; Valid character ranges:
; $05 - $13, $19 - $1c, $26 - $34, $3a - $3e, $40 - $48, $5d, $7f - $ff
; Similar to CheckStringForErrors (mobile/mobile_5f.asm),
; but there are some differences in which characters are considered valid.
; In this list:
; • $00 ('<NULL>') is treated as invalid
; • $4e ('<NEXT>') is treated as invalid
; • $5d ('<TRAINER>') is treated as valid (since it appears in OT names)
; • $60 - $7e are treated as invalid
.textcommands
; table defining which characters are not valid characters in names
; table defining which characters are not valid in nicknames
; format:
; ≥ <