From 4de3856a255fac9a102ced4a9ccba0d045a89a8e Mon Sep 17 00:00:00 2001
From: Jonathan Barrow <jonbarrow1998@gmail.com>
Date: Mon, 24 Apr 2023 11:12:44 -0400
Subject: [PATCH] use response.status() method and not response.statusCode
 setter

---
 src/middleware/auth.ts                     | 4 ++--
 src/server.ts                              | 4 ++--
 src/services/api/routes/posts.ts           | 6 +++---
 src/services/discovery/routes/discovery.ts | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/middleware/auth.ts b/src/middleware/auth.ts
index e0e2440..aeb3324 100644
--- a/src/middleware/auth.ts
+++ b/src/middleware/auth.ts
@@ -79,7 +79,7 @@ async function auth(request: express.Request, response: express.Response, next:
 
 function badAuth(response: express.Response): void {
 	response.type('application/xml');
-	response.statusCode = 400;
+	response.status(400);
 
 	response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 		result: {
@@ -132,7 +132,7 @@ function serverError(response: express.Response, discovery: HydratedEndpointDocu
 	}
 
 	response.type('application/xml');
-	response.statusCode = 400;
+	response.status(400);
 
 	response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 		result: {
diff --git a/src/server.ts b/src/server.ts
index e753c75..ccaefb8 100644
--- a/src/server.ts
+++ b/src/server.ts
@@ -40,7 +40,7 @@ app.use(api);
 LOG_INFO('Creating 404 status handler');
 app.use((_request: express.Request, response: express.Response) => {
 	response.type('application/xml');
-	response.statusCode = 404;
+	response.status(404);
 
 	return response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 		result: {
@@ -57,7 +57,7 @@ LOG_INFO('Creating non-404 status handler');
 app.use((error: any, _request: express.Request, response: express.Response, _next: express.NextFunction) => {
 	const status: number = error.status || 500;
 	response.type('application/xml');
-	response.statusCode = 404;
+	response.status(404);
 
 	return response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 		result: {
diff --git a/src/services/api/routes/posts.ts b/src/services/api/routes/posts.ts
index fa9ff2d..d05e2a9 100644
--- a/src/services/api/routes/posts.ts
+++ b/src/services/api/routes/posts.ts
@@ -155,7 +155,7 @@ router.get('/', async function (request: express.Request, response: express.Resp
 
 	if (!postID) {
 		response.type('application/xml');
-		response.statusCode = 404;
+		response.status(404);
 		response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 			result: {
 				has_error: 1,
@@ -170,7 +170,7 @@ router.get('/', async function (request: express.Request, response: express.Resp
 	const post: HydratedPostDocument | null = await getPostByID(postID);
 
 	if (!post) {
-		response.statusCode = 404;
+		response.status(404);
 		response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 			result: {
 				has_error: 1,
@@ -348,7 +348,7 @@ async function newPost(request: express.Request, response: express.Response): Pr
 	const duplicatePost = await getDuplicatePosts(request.pid, document);
 
 	if (duplicatePost) {
-		response.statusCode = 400;
+		response.status(400);
 		response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 			result: {
 				has_error: 1,
diff --git a/src/services/discovery/routes/discovery.ts b/src/services/discovery/routes/discovery.ts
index 2cf464e..0af01dc 100644
--- a/src/services/discovery/routes/discovery.ts
+++ b/src/services/discovery/routes/discovery.ts
@@ -80,7 +80,7 @@ router.get('/', async function (request: express.Request, response: express.Resp
 			break;
 	}
 
-	response.statusCode = 400;
+	response.status(400);
 	response.send('<?xml version="1.0" encoding="UTF-8"?>\n' + xml({
 		result: {
 			has_error: 1,