From ea6736681bf283896f5b6c01a6cd22c41d71c925 Mon Sep 17 00:00:00 2001 From: Darius Kazemi Date: Wed, 28 May 2025 05:39:55 -0400 Subject: [PATCH] Fix `NoMethodError` in edge case of emoji cache handling (#34749) Co-authored-by: Claire --- app/lib/entity_cache.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/lib/entity_cache.rb b/app/lib/entity_cache.rb index e647dcab7f8..b0c113afd32 100644 --- a/app/lib/entity_cache.rb +++ b/app/lib/entity_cache.rb @@ -26,7 +26,9 @@ class EntityCache uncached_ids << shortcode unless cached.key?(to_key(:emoji, shortcode, domain)) end - unless uncached_ids.empty? + if uncached_ids.empty? + uncached = {} + else uncached = CustomEmoji.enabled.where(shortcode: shortcodes, domain: domain).index_by(&:shortcode) uncached.each_value { |item| Rails.cache.write(to_key(:emoji, item.shortcode, domain), item, expires_in: MAX_EXPIRATION) } end