From e8e23847d4ba30d2efc1da63cd1b91c68ed4d873 Mon Sep 17 00:00:00 2001 From: Claire Date: Wed, 15 Jul 2026 16:41:20 +0200 Subject: [PATCH] Rename `ASSOCIATIONS_ON_SUSPEND` to `ASSOCIATIONS_ON_PURGE` (#39831) --- app/services/delete_account_service.rb | 6 +++--- spec/services/delete_account_service_spec.rb | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/app/services/delete_account_service.rb b/app/services/delete_account_service.rb index b422d5e15b1..1790a1d5daf 100644 --- a/app/services/delete_account_service.rb +++ b/app/services/delete_account_service.rb @@ -3,7 +3,7 @@ class DeleteAccountService < BaseService include Payloadable - ASSOCIATIONS_ON_SUSPEND = %w( + ASSOCIATIONS_ON_PURGE = %w( account_notes account_pins active_relationships @@ -303,9 +303,9 @@ class DeleteAccountService < BaseService def associations_for_destruction if keep_account_record? - ASSOCIATIONS_ON_SUSPEND + ASSOCIATIONS_ON_PURGE else - ASSOCIATIONS_ON_SUSPEND + ASSOCIATIONS_ON_DESTROY + ASSOCIATIONS_ON_PURGE + ASSOCIATIONS_ON_DESTROY end end diff --git a/spec/services/delete_account_service_spec.rb b/spec/services/delete_account_service_spec.rb index da02d2bd59c..16eba93449e 100644 --- a/spec/services/delete_account_service_spec.rb +++ b/spec/services/delete_account_service_spec.rb @@ -62,6 +62,12 @@ RSpec.describe DeleteAccountService do end end + describe 'ASSOCIATIONS_WITHOUT_SIDE_EFFECTS' do + it 'is a subset of ASSOCIATIONS_ON_PURGE' do + expect(described_class::ASSOCIATIONS_WITHOUT_SIDE_EFFECTS - described_class::ASSOCIATIONS_ON_PURGE).to eq [] + end + end + describe '#call on local account', :inline_jobs do before do stub_request(:post, remote_alice.inbox_url).to_return(status: 201)