diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb index 0ed0a10f377..456f4658b74 100644 --- a/app/lib/activitypub/activity/create.rb +++ b/app/lib/activitypub/activity/create.rb @@ -36,6 +36,9 @@ class ActivityPub::Activity::Create < ActivityPub::Activity if @status.nil? process_status + elsif @status.account_id != @account.id + Rails.logger.debug { "Not processing #{object_uri}: authorship change is not supported" } + return reject_payload! elsif @options[:delivered_to_account_id].present? postprocess_audience_and_deliver end @@ -91,7 +94,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity def find_existing_status status = status_from_uri(object_uri) status ||= Status.find_by(uri: @object['atomUri']) if @object['atomUri'].present? - status if status&.account_id == @account.id + status end def process_status_params diff --git a/spec/lib/activitypub/activity/create_spec.rb b/spec/lib/activitypub/activity/create_spec.rb index dac1b2a33e4..2b3c040fa28 100644 --- a/spec/lib/activitypub/activity/create_spec.rb +++ b/spec/lib/activitypub/activity/create_spec.rb @@ -459,6 +459,30 @@ RSpec.describe ActivityPub::Activity::Create do end end + context 'when the status is already known' do + let(:recipient) { Fabricate(:account) } + + let(:object_json) do + build_object( + to: ActivityPub::TagManager.instance.uri_for(recipient) + ) + end + + let!(:status) { Fabricate(:status, uri: object_json[:id], account: sender, text: object_json[:content]) } + + it 'keeps the status intact' do + expect(subject.perform).to eq status + end + + context 'when the known status is attributed to a different actor' do + let!(:status) { Fabricate(:status, uri: object_json[:id], account: Fabricate(:remote_account)) } + + it 'returns nil' do + expect(subject.perform).to be_nil + end + end + end + context 'when direct' do let(:recipient) { Fabricate(:account) } @@ -1378,7 +1402,7 @@ RSpec.describe ActivityPub::Activity::Create do def build_object(options = {}) { - id: [ActivityPub::TagManager.instance.uri_for(sender), '#bar'].join, + id: [ActivityPub::TagManager.instance.uri_for(sender), '/bar'].join, type: 'Note', content: 'Lorem ipsum', }.merge(options)