From 97ddfc7edc9fe49e6501d12a9dabc454e2bec030 Mon Sep 17 00:00:00 2001 From: Rodrigo Alfonso Date: Sun, 26 Jan 2025 23:16:56 -0300 Subject: [PATCH] didQueueOverflow(...) shouldn't be [[nodiscard]] --- lib/LinkCable.hpp | 2 +- lib/LinkCube.hpp | 2 +- lib/LinkUniversal.hpp | 2 +- lib/LinkWireless.hpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/LinkCable.hpp b/lib/LinkCable.hpp index 8c5b734..dfcc3d3 100644 --- a/lib/LinkCable.hpp +++ b/lib/LinkCable.hpp @@ -268,7 +268,7 @@ class LinkCable { * this call, the overflow flag is cleared if `clear` is `true` (default * behavior). */ - [[nodiscard]] bool didQueueOverflow(bool clear = true) { + bool didQueueOverflow(bool clear = true) { bool overflow = false; for (u32 i = 0; i < LINK_CABLE_MAX_PLAYERS; i++) { diff --git a/lib/LinkCube.hpp b/lib/LinkCube.hpp index 0b6e361..87b7cfd 100644 --- a/lib/LinkCube.hpp +++ b/lib/LinkCube.hpp @@ -162,7 +162,7 @@ class LinkCube { * this call, the overflow flag is cleared if `clear` is `true` (default * behavior). */ - [[nodiscard]] bool didQueueOverflow(bool clear = true) { + bool didQueueOverflow(bool clear = true) { bool overflow = newIncomingQueue.overflow; if (clear) newIncomingQueue.overflow = false; diff --git a/lib/LinkUniversal.hpp b/lib/LinkUniversal.hpp index 99244f0..a539d55 100644 --- a/lib/LinkUniversal.hpp +++ b/lib/LinkUniversal.hpp @@ -369,7 +369,7 @@ class LinkUniversal { * this call, the overflow flag is cleared if `clear` is `true` (default * behavior). */ - [[nodiscard]] bool didQueueOverflow(bool clear = true) { + bool didQueueOverflow(bool clear = true) { bool overflow = mode == Mode::LINK_CABLE ? linkCable.didQueueOverflow() : linkWireless.didQueueOverflow(); diff --git a/lib/LinkWireless.hpp b/lib/LinkWireless.hpp index e8b77b3..063eee2 100644 --- a/lib/LinkWireless.hpp +++ b/lib/LinkWireless.hpp @@ -691,7 +691,7 @@ class LinkWireless { * this call, the overflow flag is cleared if `clear` is `true` (default * behavior). */ - [[nodiscard]] bool didQueueOverflow(bool clear = true) { + bool didQueueOverflow(bool clear = true) { bool overflow = sessionState.newIncomingMessages.overflow; if (clear) sessionState.newIncomingMessages.overflow = false;