Leahnaya/gba-link-connection
1
0
Fork 0
mirror of https://github.com/afska/gba-link-connection.git synced 2026-04-25 08:07:59 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Not checking for 0xD2 at all in the mobile adapter

Browse Source
This commit is contained in:
Rodrigo Alfonso 2024-08-21 04:32:21 -03:00
parent 0bdd88018f
commit 576d8047ff
2 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/LinkMobile_demo/src/main.cpp
View File

@ -561,8 +561,6 @@ std::string getResultString(LinkMobile::CommandResult cmdResult) {
return "PENDING";
case LinkMobile::CommandResult::SUCCESS:
return "SUCCESS";
case LinkMobile::CommandResult::NOT_WAITING:
return "NOT_WAITING";
case LinkMobile::CommandResult::INVALID_DEVICE_ID:
return "INVALID_DEVICE_ID";
case LinkMobile::CommandResult::INVALID_COMMAND_ACK:

20
lib/LinkMobile.hpp
View File

@ -228,7 +228,6 @@ class LinkMobile {
enum CommandResult {
PENDING,
SUCCESS,
NOT_WAITING,
INVALID_DEVICE_ID,
INVALID_COMMAND_ACK,
INVALID_MAGIC_BYTES,
@ -1624,16 +1623,6 @@ class LinkMobile {
const u8* commandBytes = (const u8*)&asyncCommand.cmd;
u32 mainSize = PREAMBLE_SIZE + asyncCommand.cmd.header.size;
// (first packet is garbage)
bool didFullyTransferFirstPacket = asyncCommand.transferred >= 2;
bool isAcknowledgement =
asyncCommand.transferred >= mainSize + CHECKSUM_SIZE + 1;
if (didFullyTransferFirstPacket && !isAcknowledgement &&
newData != ADAPTER_WAITING) {
_LMLOG_("!! not waiting: %X", newData);
return asyncCommand.fail(CommandResult::NOT_WAITING);
}
if (asyncCommand.transferred < mainSize) {
// Magic Bytes (2) + Packet Header + Packet Data
advance8(commandBytes[asyncCommand.transferred]);
@ -1663,15 +1652,6 @@ class LinkMobile {
u32 padding = alignment != 0 ? 4 - alignment : 0;
u32 mainSize = PREAMBLE_SIZE + dataSize + padding;
// (first packet is garbage)
bool didFullyTransferFirstPacket = asyncCommand.transferred >= 8;
bool isAcknowledgement = asyncCommand.transferred >= mainSize;
if (didFullyTransferFirstPacket && !isAcknowledgement &&
newData != ADAPTER_WAITING && newData != ADAPTER_WAITING_32BIT) {
_LMLOG_("!! not waiting: %X", newData);
return asyncCommand.fail(CommandResult::NOT_WAITING);
}
if (asyncCommand.transferred == 4) {
// Header+Data || Header+Checksum
advance32(dataSize > 0