JosJuice 09f3f9b41a Remove NonCopyable ... The class NonCopyable is, like the name says, supposed to disallow copying. But should it allow moving? For a long time, NonCopyable used to not allow moving. (It declared a deleted copy constructor and assigment operator without declaring a move constructor and assignment operator, making the compiler implicitly delete the move constructor and assignment operator.) That's fine if the classes that inherit from NonCopyable don't need to be movable or if writing the move constructor and assignment operator by hand is fine, but that's not the case for all classes, as I discovered when I was working on the DirectoryBlob PR. Because of that, I decided to make NonCopyable movable in c7602cc, allowing me to use NonCopyable in DirectoryBlob.h. That was however an unfortunate decision, because some of the classes that inherit from NonCopyable have incorrect behavior when moved by default- generated move constructors and assignment operators, and do not explicitly delete the move constructors and assignment operators, relying on NonCopyable being non-movable. So what can we do about this? There are four solutions that I can think of: 1. Make NonCopyable non-movable and tell DirectoryBlob to suck it. 2. Keep allowing moving NonCopyable, and expect that classes that don't support moving will delete the move constructor and assignment operator manually. Not only is this inconsistent (having classes disallow copying one way and disallow moving another way), but deleting the move constructor and assignment operator manually is too easy to forget compared to how tricky the resulting problems are. 3. Have one "MovableNonCopyable" and one "NonMovableNonCopyable". It works, but it feels rather silly... 4. Don't have a NonCopyable class at all. Considering that deleting the copy constructor and assignment operator only takes two lines of code, I don't see much of a reason to keep NonCopyable. I suppose that there was more of a point in having NonCopyable back in the pre-C++11 days, when it wasn't possible to use "= delete". I decided to go with the fourth one (like the commit title says). The implementation of the commit is fairly straight-forward, though I would like to point out that I skipped adding "= delete" lines for classes whose only reason for being uncopyable is that they contain uncopyable classes like File::IOFile and std::unique_ptr, because the compiler makes such classes uncopyable automatically.		2017-08-22 16:40:34 +02:00
..
Interpreter	DSPIntMultiplier: Place translation unit local functions in an anonymous namespace	2017-03-26 16:42:35 -04:00
Jit	Merge pull request #5097 from MerryMage/pic	2017-03-17 22:24:03 +01:00
DSPAccelerator.cpp	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPAccelerator.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPAnalyzer.cpp	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPAnalyzer.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPAssembler.cpp	Core: include what you use	2017-06-07 01:20:48 -04:00
DSPAssembler.h	DSPAssembler: make ORG directive correctly seek forward	2017-05-19 19:53:38 -07:00
DSPBreakpoints.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPCaptureLogger.cpp	Core: Remove unnecessary includes	2017-06-15 18:52:22 -04:00
DSPCaptureLogger.h	Remove NonCopyable	2017-08-22 16:40:34 +02:00
DSPCodeUtil.cpp	DSPDisassembler: remove unused base_addr parameter	2017-06-30 01:47:02 -07:00
DSPCodeUtil.h	Move DSP::CodesToHeader to DSPTool	2017-06-05 19:28:40 -07:00
DSPCommon.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPCore.cpp	dsp_rom: skip bootucode_ax when running from entrypoint	2017-08-10 10:53:12 -07:00
DSPCore.h	DSPCore: Make g_cycles_left a regular member variable of DSPEmitter	2017-02-07 21:56:57 -05:00
DSPDisassembler.cpp	DSPDisassembler: fail when buffer too large	2017-06-30 01:47:02 -07:00
DSPDisassembler.h	DSPDisassembler: remove unused base_addr parameter	2017-06-30 01:47:02 -07:00
DSPHost.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPHWInterface.cpp	Core: include what you use	2017-06-07 01:20:48 -04:00
DSPHWInterface.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPMemoryMap.cpp	DSPTables: Hide main opcode tables	2017-01-19 17:46:07 -05:00
DSPMemoryMap.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00
DSPStacks.cpp	DSPCore: Convert DSP stack register enum into an enum class	2017-01-28 09:17:27 -05:00
DSPStacks.h	DSPCore: Convert DSP stack register enum into an enum class	2017-01-28 09:17:27 -05:00
DSPTables.cpp	DSPTables: Hide remaining exposed opcode tables	2017-01-26 05:17:01 -05:00
DSPTables.h	DSPAssembler: fix handling of P_REG1C	2017-06-03 15:16:39 -07:00
LabelMap.cpp	Core: include what you use	2017-06-07 01:20:48 -04:00
LabelMap.h	DSP: Namespace remaining un-namespaced DSP code	2016-12-31 17:20:14 -05:00