32768 Commits

Author	SHA1	Message	Date
JMC47	42d5f2b705	Merge pull request #13702 from CostPerUnit/master ... MappingWidget: Add Advanced Configuration Button to Point And Point Passthrough "Enable" boxes	2025-06-09 00:09:35 -04:00
JMC47	5064b615ba	Merge pull request #13737 from LillyJadeKatrin/retroachievements-gamecube-bulk-fix ... AchievementManager - Fix Gamecube Bulk Copy	2025-06-08 13:08:02 -04:00
JMC47	33b529a510	Merge pull request #13719 from LillyJadeKatrin/retroachievements-wii-menu-fix ... AchievementManager - Block Wii Menu Exploits	2025-06-08 13:04:27 -04:00
JMC47	8c3ca46988	Merge pull request #13676 from LillyJadeKatrin/retroachievements-allowlist-test-improvements ... RetroAchievements: Updated PatchAllowlistTest to generate new allowlist	2025-06-08 12:56:19 -04:00
JosJuice	1b7d42f775	AudioCommon: Re-add missing includes ... 7c237bb ("AudioCommon: Remove unused includes") removed some includes that were in fact in use.	2025-06-08 11:35:02 +02:00
JMC47	24b0bf01d5	Merge pull request #12836 from JosJuice/opensles-buffer-size ... Android: Ask system for optimal audio buffer size and sample rate	2025-06-07 23:07:37 -04:00
Tilka	19fbbf0dba	Merge pull request #13727 from JoshuaVandaele/fmt-11.2.0-localtime-deprec ... fmt: Replace deprecated `fmt::localtime` usage with `Common::LocalTime`	2025-06-08 04:04:37 +01:00
Jordan Woyak	1786e34bd3	Merge pull request #13665 from jordan-woyak/dark-mode-filter ... DolphinQt: Replace widespread SetQWidgetWindowDecorations calls with an event filter.	2025-06-07 18:19:13 -05:00
Jordan Woyak	65f3ba70f5	Merge pull request #13522 from tygyh/Enforce-overriding-destructor-style-Core&UnitTests ... Core & UnitTests: Make overriding explicit and remove redundant virtual specifiers on overriding destructors	2025-06-07 17:55:14 -05:00
Jordan Woyak	8b7669550f	Merge pull request #13454 from tygyh/Use-constants-DolphinQt-FifoAnalyzer ... DolphinQt/FIFO/FIFOAnalyzer: Make parameters, arguments etc. constant	2025-06-07 17:50:08 -05:00
Jordan Woyak	46e66fe945	Merge pull request #13544 from tygyh/DolphinNoGUI-Replace-deprecated-signal-header ... DolphinNoGUI: Apply style-alignment refactorings	2025-06-07 17:47:11 -05:00
Jordan Woyak	056ece6f29	Merge pull request #13697 from tygyh/AudioCommon/Remove-unused-includes ... AudioCommon: Remove unused includes	2025-06-07 17:45:50 -05:00
Jordan Woyak	a07a2fe398	Merge pull request #13698 from tygyh/AudioCommon/Remove-unused-qualifiers-and-make-variables-constant ... AudioCommon: Remove unused qualifiers and make variables constant	2025-06-07 17:45:33 -05:00
Tillmann Karras	61e8fa060b	QtUtils/ImageConverter: simplify	2025-06-07 23:06:07 +01:00
Jordan Woyak	6da3f5f26a	InputCommon: Update to use SDL3 and bump the SDL submodule in Externals to release-3.2.16.	2025-06-07 16:27:54 -05:00
Jordan Woyak	5906512847	DolphinQt: Replace widespread SetQWidgetWindowDecorations calls with an event filter.	2025-06-07 16:15:34 -05:00
JMC47	52fcdde485	Merge pull request #13386 from iwubcode/resource_manager_system ... VideoCommon: add resource manager, tracks resources to load assets in optimal way and manage memory	2025-06-07 15:51:34 -04:00
JMC47	5eb61024c6	Merge pull request #13740 from JoshuaVandaele/bsod-fix-i-hope ... Host: Clean up device handle in all cases	2025-06-07 12:27:49 -04:00
Admiral H. Curtiss	a27b845514	Merge pull request #13710 from TryTwo/UI_Sliders_Update ... Advanced Panel convert QSliders into ConfigSliders	2025-06-07 17:39:40 +02:00
Admiral H. Curtiss	1b1ca019a4	Merge pull request #13724 from SuperSamus/gamelist-properties-noduplicates ... GameList: Prevent opening Properties multiple times for the same game	2025-06-07 17:24:50 +02:00
Joshua Vandaële	241834709b	Host: Clean up device handle	2025-06-07 16:55:45 +02:00
LillyJadeKatrin	c68549e9ef	AchievementManager - Load unknown games ... Prior to this change, any game unrecognized by RetroAchievements would ultimately result in the game being "Closed" by AchievementManager. As a result, if any game was run while in this state without any other closing being done, AchievementManager would simply load it like a new game, despite memory already being accessed. However, testing and documentation determined that the rcheevos client doesn't actually complain when it fails to hash a game; it just runs this as "Unidentified Game" with RA ID = 0. As such, this change utilizes that in AchievementManager to differentiate between no software running and unidentified software running. As a result of this, now LoadGame needs to be called for every piece of runnable software, supported format or otherwise. If a supported format is not available, LoadGame can now be called with a nullptr to ensure that rcheevos still properly sets up an unidentified game.	2025-06-07 07:02:24 -04:00
LillyJadeKatrin	5545a386cf	AchievementManager - Fix Gamecube Bulk Copy ... The memory copy algorithm (only needed for RetroAchievements devs) was broken for Gamecube as it assumed EXRAM size was zero when in reality it's using ARAM. For the time being, we do not need to use or access ARAM so instead this sets that value to zero for Gamecube titles.	2025-06-07 07:00:47 -04:00
JosJuice	185b080f03	Merge pull request #13142 from JosJuice/fifo-window-starting-stopping ... DolphinQt: Call FIFOPlayerWindow::UpdateControls for Starting/Stopping	2025-06-07 10:43:19 +02:00
JosJuice	43b254aaad	Android: Update advanced mapping dialog when devices change ... Without this, there was a bug where if you turned the device's screen off and on again while in the advanced mapping dialog, the input indicators would stop updating. This is because turning the screen on again causes devices to refresh, which causes all devices to be recreated, leaving the AdvancedMappingControlViewHolders stuck referencing controls belonging to devices that are no longer being updated.	2025-06-07 10:20:21 +02:00
JosJuice	4214cb6eb8	Android: Make input state changes observable	2025-06-07 10:20:18 +02:00
iwubcode	c3d3b81533	VideoCommon: remove 'GetByteSizeInMemory()' from custom asset, it is not needed anymore	2025-06-06 23:03:02 -05:00
iwubcode	774a84a953	VideoCommon: avoid race conditions with asset load/unload by moving the lock to the entire function, favor atomics for the memory/time getters	2025-06-06 23:03:02 -05:00
iwubcode	b3f50c969e	VideoCommon: rename m_bytes_loaded in asset library to bytes_loaded	2025-06-06 23:03:02 -05:00
iwubcode	3b83907b88	VideoCommon: update CustomAsset's load time to be before the load occurs (this prevents issues where the load time might be incorrectly inflated by long load operations) ... Co-authored-by: Jordan Woyak <jordan.woyak@gmail.com>	2025-06-06 23:03:02 -05:00
iwubcode	d940d62cae	VideoCommon: watch texture pack folder for texture reloads (from dynamic input textures)	2025-06-06 23:03:02 -05:00
iwubcode	7afa9e6c6f	VideoCommon: use CustomResourceManager in the texture cache and hook up to our hires textures	2025-06-06 23:03:02 -05:00
iwubcode	12d178a8df	VideoCommon: initialize and shutdown the CustomResourceManager when the video thread initializes and shuts down	2025-06-06 23:03:02 -05:00
iwubcode	f910c1d934	Core: add CustomResourceManager to System	2025-06-06 23:03:02 -05:00
iwubcode	70abcb2030	VideoCommon: add resource manager and new asset loader; the resource manager uses a least recently used cache to determine which assets get priority for loading. Additionally, if the system is low on memory, assets will be purged with the less requested assets being the first to go. The loader is multithreaded now and loads assets as quickly as possible as long as memory is available ... Co-authored-by: Jordan Woyak <jordan.woyak@gmail.com>	2025-06-06 23:03:02 -05:00
iwubcode	d8ea31ca46	VideoCommon: rename GameTextureAsset into TextureAsset and make it only contain CustomTextureData. Move validation and load logic to individual functions	2025-06-06 23:03:02 -05:00
iwubcode	2ae43324cb	VideoCommon: move AssetMap to a types header file, so it can be pulled in without the DirectFilesystemAssetLibrary dependencies, the header will be expanded later	2025-06-06 23:03:02 -05:00
iwubcode	7d59c2743d	Common: Add class 'FilesystemWatcher' that is used to watch paths and receive callbacks about filesystem level events for anything under that path	2025-06-06 23:03:02 -05:00
iwubcode	bafe78203d	VideoCommon: remove 'GetLastAssetWriteTime' and switch to a steady_clock for asset times	2025-06-06 23:03:02 -05:00
iwubcode	15f125ebee	VideoCommon: change asset loading to return the number of bytes loaded instead of a pass/fail	2025-06-06 23:03:02 -05:00
iwubcode	316740daed	VideoCommon: add 'Unload' functionality to CustomAsset	2025-06-06 23:03:02 -05:00
Dentomologist	2a7e8a4003	DolphinQt: Remove redundant window hints ... Remove window hints clearing the flag Qt::WindowContextHelpButtonHint, which is already off by default in Qt 6. In Qt 5 this flag was set by default for QDialogs, and on Windows put a ? button in the corner of the title bar allowing users to activate Qt's QWhatsThis help system for a given widget. Since we don't set that text the ? button was useless and so we hid it manually.	2025-06-06 19:35:13 -07:00
iwubcode	9ec69b5925	VideoCommon: add a handle to custom asset, this is an id that is only relevant for a particular game session but is slightly faster as a numeric value for lookups than the traditional asset id	2025-06-06 19:20:25 -05:00
iwubcode	d7de49ccf6	Core / VideoCommon: Remove original custom asset loader	2025-06-06 19:20:25 -05:00
JMC47	5ec5db9240	Merge pull request #13392 from jordan-woyak/frame-pacing-accurate-time ... CoreTiming: Add setting to pursue accurate overall emulation runtime	2025-06-06 19:17:44 -04:00
JMC47	974c56d3c5	Merge pull request #13731 from iwubcode/pixel_shader_gen_fix_complete_initialize ... VideoCommon: ensure pixel shader gen input structure is completely initialized	2025-06-06 19:08:57 -04:00
JMC47	b1d114f7f7	Merge pull request #13730 from jordan-woyak/controllers-on-main-config-dialog ... DolphinQt: Move "Controllers" to main settings window.	2025-06-06 18:54:12 -04:00
Javier Martinez	d766c527c7	Common: Replace Contains and ContainsSubrange with C++23 std::ranges equivalents ... Common: Use feature macros for better compatibility Common/Contains.h: fix linting issue Common/Contains.h: Add C++23 TODO Common/Contains.h: Fix comment lint issue.	2025-06-05 19:18:08 -04:00
Jordan Woyak	a0611b512b	Merge pull request #13713 from Dentomologist/filesystemwidget_center_header_text ... FilesystemWidget: Center header text	2025-06-05 14:34:36 -05:00
Admiral H. Curtiss	ea959f2651	DSP/Jit: Don't return to dispatcher if no exception was generated	2025-06-05 20:57:27 +02:00
Admiral H. Curtiss	a43fc68452	DSPAnalyzer: Set store instructions as potentially generating exceptions	2025-06-05 19:10:42 +02:00
iwubcode	ae26b38fc0	VideoCommon: fix pixel shader gen error about structure not being fully initialized	2025-06-05 01:37:45 -05:00
Jordan Woyak	b9bea58f0f	DolphinQt: Move "Controllers" to main settings window.	2025-06-04 19:33:01 -05:00
Martino Fontana	2de9122b5f	GameList: Prevent opening Properties multiple times for the same game	2025-06-04 23:11:09 +02:00
JMC47	8665b22822	Merge pull request #13651 from jordan-woyak/config-list ... DolphinQt: Change Config QTabWidget into a QListWidget and QStackedWidget.	2025-06-04 16:01:51 -04:00
Dr. Dystopia	bae0e5f67a	DolphinNoGUI: Make override explicit	2025-06-04 21:49:29 +02:00
Dr. Dystopia	2ae928ca79	DolphinNoGUI: Make parameters constant	2025-06-04 21:49:15 +02:00
Dr. Dystopia	f04f659710	DolphinNoGUI: Replace C-style cast with reinterpret_cast	2025-06-04 21:49:01 +02:00
Dr. Dystopia	ec1d659363	DolphinNoGUI: Make classes final	2025-06-04 21:48:53 +02:00
Dr. Dystopia	c37933932d	DolphinNoGUI: Make variables constant	2025-06-04 21:48:40 +02:00
Dr. Dystopia	23af1e025b	DolphinNoGUI: Make function static	2025-06-04 21:30:59 +02:00
Dr. Dystopia	135b6840e5	DolphinNoGUI: Remove unused include directives	2025-06-04 21:30:59 +02:00
Dr. Dystopia	e3df00b7f4	DolphinNoGUI: Make variables constexpr	2025-06-04 21:30:59 +02:00
Dr. Dystopia	71da0f2d24	DolphinNoGUI: Replace deprecated signal.h header	2025-06-04 21:30:59 +02:00
JMC47	3f090dd474	Merge pull request #13681 from iwubcode/material_overhaul_custom_vertex ... VideoCommon: move vertex shader gen logic to a 'process_vertex()' for use in future custom shaders	2025-06-04 15:27:47 -04:00
JMC47	8def02072b	Merge pull request #13379 from JoshuaVandaele/system-ng ... Use minizip-ng in non-compatibility mode	2025-06-04 15:21:05 -04:00
Jordan Woyak	19a3f25a71	Merge pull request #13723 from Dentomologist/wavefile_add_prefix_to_member_variables ... WaveFile: Add m_ prefix to member variables	2025-06-04 13:11:14 -05:00
Joshua Vandaële	4b65cc9a4c	fmt: Replace deprecated fmt::localtime usage with Common::LocalTime	2025-06-04 13:32:12 +02:00
Sam Belliveau	d7f45c7b96	Fade audio after an entire loop	2025-06-02 14:37:30 -04:00
Dentomologist	61ccdb0a3c	WaveFile: Add m_ prefix to member variables	2025-06-01 11:41:09 -07:00
Dr. Dystopia	8192d9d2a9	Make parameters, arguments etc. constant	2025-05-31 20:57:54 +02:00
Jordan Woyak	31d0756808	Config: Make s_callbacks_lock recursive to fix hardcore mode deadlock.	2025-05-30 17:33:01 -05:00
Dr. Dystopia	a6b04f53e0	AudioCommon: Remove unused qualifiers and make variables constant	2025-05-30 21:48:38 +02:00
Jordan Woyak	a8eafa4ccd	DolphinQt: Move the "Point (Passthrough)" "Enabled" checkbox below the mapping indicator.	2025-05-29 19:46:53 -05:00
CostPerUnit	a5b4a0b9e4	InputCommon/DolphinQt: Add advanced settings button for "Point" and "Point (Passthrough)" "Enabled" checkboxes.	2025-05-29 19:39:10 -05:00
LillyJadeKatrin	fd285f6348	AchievementManager - Minor cleanup ... Deleting the unused m_game_data and m_is_game_loaded fields.	2025-05-29 18:35:30 -04:00
Dentomologist	3dc1605569	FilesystemWidget: Center header text ... Center header text to match all the other headers.	2025-05-27 12:34:20 -07:00
TryTwo	a6a5e201b6	Qt Advanced Panel: Convert QSliders into ConfigSliders. ... Part of the refactor into the config system.	2025-05-26 19:52:30 -07:00
Jordan Woyak	aafe961177	DolphinQt: Make GeckoCodeWidget default size not taller than it needs to be.	2025-05-26 20:58:48 -05:00
Jordan Woyak	eed7843d4a	DolphinQt: Add stretch to the end of the game config Info tab.	2025-05-26 20:58:48 -05:00
Jordan Woyak	1e4dfc0956	DolphinQt: Fix the WiiPane hinting a larger than required size.	2025-05-26 20:58:48 -05:00
Jordan Woyak	5bc661aeca	DolphinQt/AudioPane: Fix Volume QGroupBox title uglyness on Windows and inconsistent percent-sign spacing.	2025-05-26 20:58:48 -05:00
Jordan Woyak	fcff7a3a49	DolphinQt: Fix FilesystemWidget QTreeView visual style.	2025-05-26 20:58:48 -05:00
Jordan Woyak	543b85a451	DolphinQt: Make WrapInScrollArea and GetWrappedWidget less hacky.	2025-05-26 20:58:48 -05:00
Jordan Woyak	e796e82e8c	DolphinQt: Change game properties QTabWidget to QListWidget.	2025-05-26 20:58:48 -05:00
Jordan Woyak	2b9935e6f4	DolphinQt: Change main settings window QTabWidget into a QListWidget and QStackedWidget.	2025-05-26 20:58:48 -05:00
Admiral H. Curtiss	4e8a863d8b	Merge pull request #13709 from JosJuice/hide-header-bin ... Hide DirectoryBlob header.bin files from game list	2025-05-26 19:41:07 +02:00
JosJuice	66f181a621	Hide DirectoryBlob header.bin files from game list ... This is a continuation of 552b6da. That commit hid sys/boot.bin, but not disc/header.bin, which is only present for Wii games. Fixes https://bugs.dolphin-emu.org/issues/13810.	2025-05-25 20:37:52 +02:00
JosJuice	18a78a9bab	Merge pull request #13647 from jordan-woyak/sha1-avoid-memcpy ... Crypto/SHA1: Re-add memcpy avoiding optimization to BlockContext::Update.	2025-05-25 12:40:43 +02:00
JosJuice	f99d3dbd5c	Android: Ask system for optimal audio buffer size and sample rate ... This can reduce audio latency according to https://developer.android.com/ndk/guides/audio/opensl/opensl-prog-notes#perform. Previously we were using the hardcoded values of 48000 Hz and 256 frames per buffer. The sample rate we use with this change is 48000 Hz on all devices I'm aware of, but the buffer size does vary across devices. Terminology note: The old code used the term "sample" to refer to what Android refers to as a "frame". "Frame" is a clearer term to use for this, so I've changed OpenSLESStream's terminology. One frame consists of one sample per channel.	2025-05-25 11:59:33 +02:00
JosJuice	34e8fb068f	Android: Get rid of OpenSLESStream's global state ... Not sure if we're ever going to want to have more than one of these at the same time, but these global variables are a code smell nonetheless. I'm also deleting the existing member variables because they were unused.	2025-05-25 11:55:22 +02:00
Dr. Dystopia	7c237bbd7c	AudioCommon: Remove unused includes	2025-05-25 10:30:41 +02:00
JosJuice	776086fa1c	Merge pull request #13692 from jordan-woyak/work-queue-thread-command-queue ... WorkQueueThread: Fix Cancel() race with internal command queue.	2025-05-24 16:26:10 +02:00
iwubcode	b23dddea4e	VideoCommon: move vertex shader gen logic to a 'process_vertex()' function, to eventually allow for custom shaders to override vertex logic	2025-05-24 01:27:58 -05:00
Sketch	35d70fd531	IOS/KD: Set Checksum when flushing NWC24Config	2025-05-23 18:01:06 -04:00
JosJuice	7c8d53a51d	Merge pull request #13699 from JosJuice/force-typo ... DolphinQt: Fix verb agreement in Immediate XFB description	2025-05-22 23:22:53 +02:00
JosJuice	260f0225a4	DolphinQt: Don't translate Wii Speak OSD string ... We have a general policy of not translating OSD strings due to the OSD font not having good enough support for languages other than English.	2025-05-22 16:51:28 +02:00
JosJuice	98b0d1db05	DolphinQt: Fix verb agreement in Immediate XFB description	2025-05-22 16:48:10 +02:00
Joshua Vandaële	2ed5f16600	minizip-ng: Stop using compatibility mode	2025-05-22 12:51:55 +02:00
LillyJadeKatrin	c23b4e1020	RetroAchievements: Updated PatchAllowlistTest to generate new allowlist ... Refactors the PatchAllowlistTest to streamline the experience for developers. Instead of a textual description of what needs to change in ApprovedInis.json for RetroAchievements compatibility, the test will now generate a replacement file and instruct the coder where to copy it in their local branch, and what to update APPROVED_LIST_HASH to. The result should be easier and more instructive for developers to make changes, while still maintaining that allowed codes cannot be added or modified without recompiling Dolphin. As ApprovedInis.json no longer needs to be user-readable for this process, it no longer contains titles or pretty formatting and as such is updated in this commit, hash included.	2025-05-21 21:38:34 -04:00
Admiral H. Curtiss	f90508ff99	Merge pull request #13661 from jordan-woyak/info-first ... DolphinQt: Make the Info tab first in the game properties dialog.	2025-05-21 20:43:51 +02:00
Admiral H. Curtiss	a6bc251677	Merge pull request #13693 from jordan-woyak/focus-render-window-on-click ... DolphinQt/RenderWidget: Grab focus on mouse button press.	2025-05-21 20:28:58 +02:00
JMC47	a62449711f	Merge pull request #12769 from sepalani/wii-speak ... IOS/USB: Emulate Wii Speak using cubeb	2025-05-21 13:54:56 -04:00
Jordan Woyak	9ba71448cc	WorkQueueThread: Fix Cancel() race with internal command queue.	2025-05-20 21:51:25 -05:00
Jordan Woyak	f1b7f8a72e	DolphinQt/RenderWidget: Grab focus on mouse button press.	2025-05-20 21:06:32 -05:00
JMC47	1dc4dc6b6d	Merge pull request #13675 from LillyJadeKatrin/retroachievements-close-deadlock ... AchievementManager - LoadGameCallback	2025-05-20 11:54:31 -04:00
Jordan Woyak	faaf13eaad	Merge pull request #13562 from sanjay900/santroller-support ... LibusbDevice: Send wakeup command to Santroller devices	2025-05-20 01:13:39 -05:00
LillyJadeKatrin	dac023af15	Resolve clang-tidy violation	2025-05-18 05:16:17 -04:00
Jordan Woyak	94888d250e	Merge pull request #13527 from tygyh/Replace-msg-with-structured-binding-VideoCommon/NetPlayChatUI ... VideoCommon/NetPlayChatUI: Replace msg with structured binding	2025-05-17 17:09:13 -05:00
Jordan Woyak	dacb004516	Merge pull request #13190 from tygyh/Move-to-inner-scope-DolphinQT ... DolphinQT: Move variables to inner scope	2025-05-17 16:52:25 -05:00
LillyJadeKatrin	b6803d00fe	Revert "RetroAchievements: Fix potential deadlock on shutdown." ... This reverts commit 826f04d06c.	2025-05-17 08:29:50 -04:00
LillyJadeKatrin	137e50dc25	AchievementManager: Remove CloseGame from LoadGameCallback ... This was causing deadlocks when a game didn't load (including if RetroAchievements does not yet support it) because it was attempting to close the queue the the callback was currently running on, forcing LoadGameCallback to wait for LoadGameCallback to finish. However, it appears that recent changes to the queue have independently resolved the reason CloseGame was being called here in the first place.	2025-05-17 08:29:34 -04:00
Jordan Woyak	88389146d3	Merge pull request #13662 from Dentomologist/wiimotecontrollerswidget_scan_for_bluetooth_adapters_on_separate_thread ... WiimoteControllersWidget: Fix UI hang when opening Controllers window	2025-05-16 19:43:35 -05:00
Jordan Woyak	7804c16dbb	Merge pull request #13531 from tygyh/DiscIO-Make-functions-constant ... DiscIO: Make functions constant	2025-05-16 14:49:05 -05:00
Jordan Woyak	3b3bf6a04c	Merge pull request #13459 from tygyh/Make-parameters-constants-DolphinQt-Netplay ... DolphinQt/NetPlay: Make variables constant	2025-05-16 14:29:44 -05:00
Dr. Dystopia	9dfcbcecff	DiscIO: Make functions constant	2025-05-16 19:11:39 +02:00
Dentomologist	ffd46cd10c	WiimoteControllersWidget: Fix UI hang on opening ... Fix the UI hanging for several seconds when opening the Controllers window. Move the scan for Bluetooth adapters onto a separate thread so the Host thread doesn't have to wait for it. Only automatically scan for adapters once, when opening the Controllers window for the first time. Add a Refresh button to let the user refresh the adapter list afterward.	2025-05-15 20:36:21 -07:00
Jordan Woyak	fc833f845c	Merge pull request #13660 from jordan-woyak/consistent-icon-text ... DolphinQt: Add utility function for creating label text with a standard icon.	2025-05-15 13:24:18 -05:00
Jordan Woyak	17eb1b1a34	DolphinQt/Mapping: Replace Motion Input "WARNING: " text with a warning icon.	2025-05-15 10:58:43 -05:00
Jordan Woyak	afb27952ee	DolphinQt: Make the Info tab first in the game properties dialog.	2025-05-15 02:13:48 -05:00
Jordan Woyak	a45d00d84d	DolphinQt: Add utility function for creating label text with a standard icon.	2025-05-15 01:49:38 -05:00
Jordan Woyak	c211efd84a	Merge pull request #13603 from tygyh/FifoPlayer-Make-functions-static ... FifoPlayer: Make functions static	2025-05-14 23:01:34 -05:00
Jordan Woyak	826f04d06c	RetroAchievements: Fix potential deadlock on shutdown.	2025-05-14 01:10:53 -05:00
Jordan Woyak	1554e4ab6c	Vulkan: Eliminate m_last_present_done flag.	2025-05-13 20:13:18 -05:00
JMC47	57dce8bd7c	Merge pull request #13650 from JosJuice/stswx-uncached ... PowerPC: Correctly handle stswi/stswx to uncached memory	2025-05-12 19:19:52 -04:00
JMC47	cf3702cbc8	Merge pull request #13046 from SuperSamus/vi-overclock ... Add VBI Frequency Override	2025-05-12 13:36:55 -04:00
Martino Fontana	c720211542	VideoCommon: Limit maximum denominator for MPEG4 ... It happened to be under the limit normally, but now that the VBI rate can be changed, that's no longer the case.	2025-05-12 18:54:42 +02:00
Martino Fontana	832570c658	Core: Add VBI Frequency Override ... This feature allows overriding the frequency of the Vertical Blank Interrupt. For many games, this means that their gameplay speed will change without affecting audio, which would be useful by itself (e.g. grinding in RPGs). However, there are games that use delta time for their game logic, which allows them to be played at >60 FPS at the same gameplay speed! Some games aren't dynamic though, and require a patch to adjust their game speed variable.	2025-05-12 18:54:36 +02:00
JMC47	f19a33340a	Merge pull request #13631 from LillyJadeKatrin/retroachievements-mem2 ... AchievementManager: MEM2 Support	2025-05-10 14:56:14 -04:00
JosJuice	2b376a92ae	PowerPC: Correctly handle stswi/stswx to uncached memory ... On real hardware, stswi and stswx don't trigger any of the special behavior for uncached unaligned writes that was implemented in 543ed8a. This is confirmed by a hwtest (a new commit in https://github.com/dolphin-emu/hwtests/pull/42). This change fixes Dolphin's stswi and stswx implementations so they stop triggering the special behavior, bringing them back to the behavior they had before 543ed8a. No games are known to be affected, but Extrems has reported that it affects homebrew they've made.	2025-05-10 19:47:15 +02:00
Dr. Dystopia	cb30862cfb	DolphinQT/Netplay: Make variables constant	2025-05-10 13:05:54 +02:00
JMC47	b2e5d6df25	Merge pull request #13350 from iwubcode/custom_shader_overhaul_vertex_pos ... VideoCommon: move transform matrices to accessible functions in VertexShaderGen	2025-05-10 01:20:28 -04:00
Jordan Woyak	bb77d61967	Crypto/SHA1: Re-add memcpy avoiding optimization to BlockContext::Update.	2025-05-09 20:59:17 -05:00
JMC47	0351fd56b1	Merge pull request #10766 from xperia64/dsp_format_fun ... DSP accelerator improvements	2025-05-09 19:04:23 -04:00
JMC47	463bd86145	Merge pull request #13641 from jordan-woyak/sha1-fix ... Crypto/SHA1: Fix past-the-last-element std::array access and modernize code.	2025-05-09 18:56:20 -04:00
JMC47	7113bafd94	Merge pull request #13586 from Tilka/spr_disasm ... GekkoDisassembler: standardize SPR names and add missing ones	2025-05-09 18:55:53 -04:00
JMC47	b18bca11e8	Merge pull request #13440 from jordan-woyak/si-dev-change-tweak ... HW/SI: Don't require waiting a second before disconnecting an SIDevice.	2025-05-09 18:55:18 -04:00
Dentomologist	55cfb958c7	GeneralPane: Add Hardcore Mode tooltip clarification ... When Hardcore Mode is active, clarify in the Speed Limit tooltip that values less than 100% won't slow emulation.	2025-05-08 15:45:15 -07:00
Admiral H. Curtiss	37f97cabb4	Merge pull request #13639 from Tilka/move ... AchievementManager: fix -Wpessimizing-move warning	2025-05-08 21:40:06 +02:00
Admiral H. Curtiss	083ffd5fdb	Merge pull request #13643 from parona-source/no-retroachievments-buildfix ... Remove filename option from stubbed AchievementManager::LoadGame	2025-05-08 21:37:11 +02:00
JMC47	721175b0d2	Merge pull request #13642 from sepalani/hid-log ... IOS/USB: Change HIDv4.cpp LogLevel to avoid INTRMSG killing performance	2025-05-08 15:19:51 -04:00
Alfred Wingate	85bbaf6563	Remove filename option from stubbed AchievementManager::LoadGame ... Fixes: c796691d00 Signed-off-by: Alfred Wingate <parona@protonmail.com>	2025-05-08 22:05:42 +03:00
Sepalani	17e57f550c	IOS/USB: Change HIDv4.cpp LogLevel to avoid INTRMSG killing performance ... This message can be sent a lot when polling inputs from a keyboard. HIDv5.cpp doesn't log INTRMSG in such a way. If needed, log messages can be added into specific devices instead.	2025-05-08 22:14:01 +04:00
Jordan Woyak	a9ab0e979e	Crypto/SHA1: Fix past-the-last-element std::array access and modernize code.	2025-05-08 03:03:59 -05:00
Jordan Woyak	d922ba31f7	DolphinQt: Fix unnecessarily created Triforce widget in game properties Info tab.	2025-05-08 01:58:20 -05:00
Tillmann Karras	a8fb4153d7	AchievementManager: fix -Wpessimizing-move warning	2025-05-08 00:15:17 +01:00
Jordan Woyak	01bb9d1f8c	Merge pull request #13584 from tygyh/Core/HW/SI-Make-variables-constant ... Core/HW/SI: Make variables constant	2025-05-07 16:06:00 -05:00
Jordan Woyak	a52e8ff9bd	Merge pull request #13585 from tygyh/Core/HW/GCMemcard-Make-variables-constant ... Core/HW/GCMemcard: Make variables constant	2025-05-07 16:04:44 -05:00
Jordan Woyak	d74d1d42d6	Merge pull request #13511 from tygyh/Use-range-based-loops-Core-VideoBackends ... Core/VideoBackends: Use range-based loops	2025-05-07 15:53:18 -05:00
Jordan Woyak	921ffe153d	Merge pull request #13542 from tygyh/DiscIO-Pass-parameters-by-constant-reference ... DiscIO: Pass parameters by constant reference	2025-05-07 15:50:11 -05:00
Jordan Woyak	b8ca3c8d15	Merge pull request #13575 from tygyh/DolphinTool-Make-variables-constant ... DolphinTool: Make variables constant	2025-05-07 15:47:14 -05:00
Jordan Woyak	c4616226ab	Merge pull request #13589 from tygyh/Core/HW/EXI-Remove-redundant-inline-specifiers ... Core/HW/EXI: Remove redundant `inline` specifiers	2025-05-07 15:44:53 -05:00
Sepalani	eff334524a	HotkeyManager: Add HK_TOGGLE_WII_SPEAK_MUTE	2025-05-07 21:27:50 +04:00
Sepalani	4efbd35a5e	IOS/USB: Implement Wii Speak SAMPLER_FREQ register properly ... Fix the default sampling rate which should be 16KHz	2025-05-07 20:33:22 +04:00
Sepalani	74a875e9d6	IOS/USB: Implement a bare-bones Wii Speak loudness level ... Add a volume modifier to the UI which relies on gain.	2025-05-07 20:33:22 +04:00
Sepalani	1f0ff42aa0	IOS/USB: Implement Wii Speak REQUEST_SET_INTERFACE command ... Based on LibusbDevice::SubmitTransfer code	2025-05-07 20:33:22 +04:00
Sepalani	61ab0faab8	Config: Rename MAIN_WII_SPEAK_CONNECTED to MAIN_WII_SPEAK_MUTED	2025-05-07 20:33:22 +04:00
Sepalani	aea5054509	CubebUtils: Add COM helper class	2025-05-07 20:33:22 +04:00
Sepalani	407218a8b4	IOS/USB: Report Wii Speak packet size properly	2025-05-07 20:33:22 +04:00
Sepalani	dbc09bfb0d	Android: Add emulated Wii Speak	2025-05-07 20:33:22 +04:00
Sepalani	a85ffc116e	IOS/USB: Only sample Wii Speak data when necessary ... Skip data when HLE Wii Speak is not connected Lock microphone buffer less frequently	2025-05-07 20:33:22 +04:00
Sepalani	f5dd80bb5b	IOS/USB: Try to fix the Wii Speak Channel record/playback feature ... 1. Fix Wii Speak SAMPLER_MUTE register: The register should be 12 (i.e. 0x0c) instead of 0xc0. 2. Fix Wii Speak buffer memcpy size parameter: It seems to fix random echoes and reduce noises when nobody is speaking. 3. Change the isochronous transfer timing: It is based on empirical testing.	2025-05-07 20:33:22 +04:00
Sepalani	6a36930c74	IOS/USB: Add more logs to the Wii Speak code	2025-05-07 20:33:22 +04:00
Sepalani	1ac40f25a2	IOS/USB: Emulate Wii Speak using cubeb ... Based on @noahpistilli (Sketch) PR: https://github.com/dolphin-emu/dolphin/pull/12567 Fixed the Windows support and the heisenbug caused by uninitialized members. Config system integration finalized.	2025-05-07 20:33:22 +04:00
Sketch	451e36defc	IOS/USB: Emulate Wii Speak (OpenAL) ... Credits to @degasus and shuffle2 (godisgovernment): https://github.com/degasus/dolphin/tree/wiispeak	2025-05-07 17:45:59 +04:00
LillyJadeKatrin	85bb066cb0	AchievementManager: update dev memory clone for Wii ... The clone of system memory used by AchievementManager during achievement development for the sake of thread decoupling was only copying MEM1; this grabs MEM2 as well if it exists.	2025-05-06 16:59:27 -04:00
LillyJadeKatrin	599f28045e	AchievementManager: verify MEM2 if it exists ... Adds MEM2 to MemoryVerifier.	2025-05-06 16:59:27 -04:00
Jordan Woyak	845fecff22	Common/BitField: Make deleted functions public.	2025-05-05 19:34:35 -05:00
Jordan Woyak	2dc975fa92	Common: Replace enable_if with concepts and other minor modernizations.	2025-05-05 19:34:24 -05:00
JMC47	c9bdda63dc	Merge pull request #13342 from Tilka/fifo_reset ... VideoCommon: reset some CP registers during PI_FIFO_RESET	2025-05-05 20:20:40 -04:00
Jordan Woyak	2f1d8272a8	DolphinQt/TAS: Use non-default std::atomic struct constructor to fix build with libstdc++ 15.	2025-05-05 16:29:15 -05:00
Tillmann Karras	6f25e20c6a	VideoCommon: reset some CP registers during PI_FIFO_RESET ... This fixes the shutdown error in SpongeBob Globs of Doom.	2025-05-05 21:18:37 +01:00
Jordan Woyak	6e22e145a0	HW/SI: Don't require waiting a second before disconnecting an SIDevice.	2025-05-04 15:00:48 -05:00
Admiral H. Curtiss	d2db9d9590	Merge pull request #13608 from jordan-woyak/async-work-thread ... Common: Add AsyncWorkThread.	2025-05-04 18:45:14 +02:00
Admiral H. Curtiss	2a3580fda5	Merge pull request #13482 from jordan-woyak/string-util-concepts ... StringUtil: Use concepts instead of enable_if.	2025-05-04 17:47:37 +02:00
Admiral H. Curtiss	380a9291ad	Merge pull request #13602 from jordan-woyak/move-only-function ... Common: Add MoveOnlyFunction.	2025-05-04 17:28:06 +02:00
Admiral H. Curtiss	fc0601e55f	Merge pull request #13628 from jordan-woyak/unique-buffer-texture-data ... Common and VideoCommon: Change texture data from std::vector to Common::UniqueBuffer.	2025-05-04 14:03:10 +02:00
LillyJadeKatrin	6b52336bf7	AchievementManager: Fix unknown hash achievements deadlock ... Within AchievementManager, CloseGame being called when LoadGame fails was causing m_queue.Cancel to be called within a lock when Cancel itself locks until it is empty, causing a deadlock. This is resolved by cancelling the queues outside of the lock when they are safe to wait for resolutions.	2025-05-03 22:51:07 -04:00
Jordan Woyak	5a80105555	Common and VideoCommon: Change texture data from std::vector to Common::UniqueBuffer.	2025-05-03 18:32:30 -05:00
iwubcode	e80ed595ac	VideoCommon: move position/normal matrices to be gettable by function in VertexShaderGen	2025-05-03 16:51:34 -05:00
cristian64	2eeb2fd2b9	DolphinQt: Use non-autodismissable menus in menu bar. ... A new class that derives from `QMenu` has been introduced. Menus of this `NonAutodismissibleMenu` type will stay visible when a _checkable_ action is triggered. This is convenient in menus that feature a series of check boxes that toggle visibility of third components (e.g. the **List Columns** menu), allowing the user to toggle several actions at once. For now, the new type is used in the top menu bar.	2025-05-03 20:29:21 +02:00
Admiral H. Curtiss	7774dccc9d	Merge pull request #13509 from Dentomologist/gamelist_fix_right_doubleclick_starting_games ... GameList: Ignore non-left double-clicks	2025-05-03 20:15:11 +02:00
JMC47	78465693ad	Merge pull request #13607 from LillyJadeKatrin/retroachievements-wiiware ... RetroAchievements - Wii and WiiWare Support	2025-05-03 13:21:00 -04:00
Admiral H. Curtiss	dcc09906e5	Merge pull request #13622 from TryTwo/Settings_Bugfix ... Settings: Bugfix. GFX settings getting set without user input	2025-05-03 18:36:36 +02:00
Admiral H. Curtiss	ffd78711be	Merge pull request #13618 from jordan-woyak/cubeb-logging ... AudioCommon/CubebUtils: Fix logged file name.	2025-05-03 18:33:06 +02:00
TryTwo	c1d0a49f35	Settings: Bugfix. Fix some combo boxes setting a value without user input. Prevents initial Load from calling the connection to save value.	2025-05-02 18:21:45 -07:00
TryTwo	1aabae49ed	Settings: Bugfix. Remove Aspect Ratio combobox signal so it doesn't trigger a settings changed save.	2025-05-02 18:21:18 -07:00
Dentomologist	77744169be	SDL: Check if touchpad exists before getting input ... Verify a touchpad is present before polling it for input. Without this check the Debug log is spammed with the message "error: Parameter 'touchpad' is invalid" if you have a controller without a touchpad. One would think every touchpad supports at least 1 finger, but in case there's some weird edge case check the finger count to be sure.	2025-05-02 17:21:42 -07:00
Jordan Woyak	63572f15fc	Merge pull request #13620 from JosJuice/logmanager-cleanup ... LogManager: Stop using manual memory management	2025-05-02 15:24:34 -05:00
Jordan Woyak	ec29d120b5	CoreTiming: Add a setting to pursue accurate emulation time.	2025-05-02 15:23:43 -05:00
JosJuice	c8be819711	LogManager: Stop using manual memory management ... This fixes a memory leak that would occur when the Android frontend calls LogManager::Init more than once in order to reload settings. Note that the log window listener is now owned by LogManager instead of by the frontend, making it consistent with the other log listeners.	2025-05-02 21:14:32 +02:00
JosJuice	6515807685	Merge pull request #13278 from JoshuaVandaele/saves-import ... Implement importing multiple saves from an export folder	2025-05-02 15:40:27 +02:00
Jordan Woyak	06826319c7	AudioCommon/CubebUtils: Fix logged file name.	2025-05-02 02:54:15 -05:00
JosJuice	b566e81644	Merge pull request #13596 from JosJuice/config-callback-locking ... Config: Add locking for config changed callbacks	2025-05-02 08:49:22 +02:00
JosJuice	58d305f75c	Merge pull request #13616 from parona-source/musl-cstdint ... UICommon: Include implicit header	2025-05-02 08:03:01 +02:00
Jordan Woyak	4e736d60db	Core and AudioCommon: Use AsyncWorkThread.	2025-05-01 22:55:23 -05:00
Jordan Woyak	be4b0af971	Common: Add AsyncWorkThread.	2025-05-01 22:54:40 -05:00
JMC47	0066119e41	Merge pull request #13617 from OatmealDome/coretiming-include ... CoreTiming: Add missing SystemTimers.h include	2025-05-01 21:33:22 -04:00
JMC47	da4f643b9f	Merge pull request #13611 from jordan-woyak/work-queue-thread-sp ... Core and Vulkan: Change WorkQueueThread to WorkQueueThreadSP in a few places.	2025-05-01 21:32:16 -04:00
JMC47	757e6aba46	Merge pull request #13597 from JosJuice/hide-boot-bin ... Hide DirectoryBlob boot.bin files from game list	2025-05-01 21:30:10 -04:00
JMC47	2b568566ac	Merge pull request #13535 from m-brodschi/mihaib/fix-shutdown-crash ... Core, VideoCommon: Fix crash at shutdown due to destructor order	2025-05-01 21:29:02 -04:00
JMC47	539a3ed021	Merge pull request #13464 from jordan-woyak/dont-toggle-skip-frames ... DolphinQt: Don't auto toggle GFX_HACK_SKIP_DUPLICATE_XFBS.	2025-05-01 21:28:13 -04:00
JMC47	7222779e21	Merge pull request #13448 from Dentomologist/fix_unresponsive_hotkeys_when_moving_overlay_during_framestep ... DolphinQt: Fix unresponsive hotkeys when clicking overlay during a framestep	2025-05-01 21:27:30 -04:00
JMC47	1bd2570d97	Merge pull request #13239 from JosJuice/jitarm64-rlwimix-imm-mask ... JitArm64: Use AArch64 imm masks in rlwimix slow case	2025-05-01 21:26:27 -04:00
OatmealDome	0bd7cc64c9	CoreTiming: Add missing SystemTimers.h include	2025-05-01 19:13:02 -04:00
Alfred Wingate	fbb54604b6	UICommon: Include implicit header ... The header isn't implicitly included on musl. Bug: https://bugs.gentoo.org/952952 Signed-off-by: Alfred Wingate <parona@protonmail.com>	2025-05-02 02:03:41 +03:00
Jordan Woyak	20874124c2	StringUtil: Use concepts instead of enable_if.	2025-05-01 16:30:37 -05:00
Jordan Woyak	e4525ca7ee	Merge pull request #13499 from jordan-woyak/frame-pacing-better-math ... CoreTiming: Cleanups to avoid drift from cumulative rounding errors.	2025-05-01 15:58:33 -05:00
Dr. Dystopia	f240e20e3f	Make overriding explicit and remove redundant virtual specifiers on overriding destructors - Core & UnitTests	2025-05-01 15:00:37 +02:00
Dr. Dystopia	5c0cf0788f	VideoCommon/NetPlayChatUI: Replace msg with structured binding	2025-05-01 14:11:55 +02:00
LillyJadeKatrin	1633011d2a	Add achievement support for Wii and WiiWare ... Add a method to detect console ID from an input file and instruct rcheevos to load as Gamecube or Wii accordingly. Also, hash .wads upon loading, to support achievements on WiiWare titles.	2025-05-01 07:54:12 -04:00
LillyJadeKatrin	c796691d00	Remove filename option from achievement manager load ... The only option that was currently using this was a pass-by-executable that wouldn't hash correctly anyways.	2025-05-01 07:54:12 -04:00
JosJuice	0ce929220d	Merge pull request #13553 from tygyh/Core/PowerPC/JitArm64-Replace-zeroes-in-boolean-context-with-false ... JitArm64: Replace zeroes in boolean context with `false`	2025-05-01 10:11:44 +02:00
LillyJadeKatrin	999c7aed98	Don't close achievements on games that don't hash ... Minor bugfix necessary for future development; issue brought on by a conflict resolving wrong.	2025-05-01 00:17:20 -04:00
Jordan Woyak	0987c03693	Merge pull request #13453 from tygyh/Use-underlying-method ... DolphinQt/FIFO/FIFOAnalyzer: Use Common::ToUnderlying	2025-04-30 22:18:02 -05:00
Admiral H. Curtiss	2e20e24136	Merge pull request #13587 from jordan-woyak/manual-value ... Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.	2025-04-30 23:45:33 +02:00
Jordan Woyak	ec940e6a2e	VideoBackends/Vulkan: Use WorkQueueThreadSP for swap commands.	2025-04-30 16:29:35 -05:00
Jordan Woyak	753fe5bed1	Core: Use WorkQueueThreadSP in NetKDRequestDevice.	2025-04-30 16:29:21 -05:00
Jordan Woyak	c14101534f	Core: Use WorkQueueThreadSP in NetIPTopDevice.	2025-04-30 16:28:57 -05:00
Jordan Woyak	bdb4fd8376	Core: Use WorkQueueThreadSP in DVDThread.	2025-04-30 16:17:21 -05:00
Jordan Woyak	8e64a02a42	Merge pull request #13579 from jordan-woyak/work-queue-thread-cleanup ... WorkQueueThread: Implement in terms of WaitableSPSCQueue. Add unit tests.	2025-04-30 16:10:28 -05:00
Jordan Woyak	43e4e8f182	Merge pull request #13581 from jordan-woyak/dvd-WorkQueueThread ... DVDThread: Implement with WorkQueueThread and WaitableSPSCQueue.	2025-04-30 16:09:36 -05:00
Jordan Woyak	4899913446	Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.	2025-04-30 14:56:07 -05:00
Jordan Woyak	a149b9d62d	WorkQueueThread: Cleanups. Implement in terms of WaitableSPSCQueue. Add single producer WorkQueueThreadSP.	2025-04-30 14:31:51 -05:00
OatmealDome	0b0151770a	Merge pull request #13436 from JoshuaVandaele/clang-format-19 ... Update clang-format to version 19	2025-04-30 01:17:31 -04:00
Dr. Dystopia	c32ca0696e	FifoPlayer: Make functions static	2025-04-28 20:09:14 +02:00
Mihai Brodschi	bad78cfed4	Core, VideoCommon: Fix crash at shutdown due to destructor ordering ... Previously, PerformanceTracker registered a callback to be updated on emulation state changes. PerformanceTrackers live in a global variable (g_perf_metrics) within libvideocommon. The callback was stored in a global variable in libcore. This created a race condition at shutdown between these libraries, when the PerfTracker's destructor tried to unregister the callback. Notify the PerfTracker directly from libcore, without callbacks, since Core.cpp already references g_perf_metrics explicitly. Also rename Core::CallOnStateChangedCallbacks to NotifyStateChanged to better reflect what it's doing.	2025-04-28 07:11:53 +03:00
Jordan Woyak	4ec2072beb	Core: Use MoveOnlyFunction for RunOnCPUThread.	2025-04-27 20:07:13 -05:00
Jordan Woyak	37aa65afc4	VideoCommon: Use MoveOnlyFunction for AsyncRequests.	2025-04-27 20:07:13 -05:00
Jordan Woyak	e403dee3da	Common: Add MoveOnlyFunction.	2025-04-27 20:07:13 -05:00
Joshua Vandaële	97e696e524	CMake: Explicitely link udev if LIBUDEV_FOUND is set	2025-04-27 22:03:15 +02:00
Jordan Woyak	2e6e7eddd1	DVDThread: Implement with WorkQueueThread and WaitableSPSCQueue.	2025-04-27 04:16:27 -05:00
JosJuice	552b6da9c4	Hide DirectoryBlob boot.bin files from game list ... Extracted games contain a boot.bin file that contains the disc header. These boot.bin files are considered valid volumes by Dolphin, since Dolphin only checks the disc header to determine if something is a valid GC/Wii disc. Running them doesn't make any sense, though. boot.bin files used to not be scanned by Dolphin due to their file extension, but .bin was added to the list of file extensions to scan for in 494e2c0. To stop them from showing up in the game list, let's update the ShouldHideFromGameList mechanism.	2025-04-26 20:54:32 +02:00
Tilka	8ee64a84c7	Merge pull request #13590 from tygyh/UCodes-Remove-redundant-qualifiers ... UCodes: Remove redundant qualifiers	2025-04-26 16:23:27 +01:00
JosJuice	f060baa257	Config: Add locking for config changed callbacks ... Different threads are adding and calling callbacks, so this should have some locking. This is both to ensure thread safety when accessing `s_callbacks` and to ensure that there won't be situations where a callback gets called after it's removed. `s_callback_guards` is also accessed from multiple threads and has therefore been made atomic.	2025-04-26 12:56:37 +02:00
JosJuice	741ffc3114	Merge pull request #13514 from LillyJadeKatrin/retroachievements-failed-load-bug ... Call AchievementManager CloseGame on load failures	2025-04-26 10:36:09 +02:00
Dentomologist	3a883f28d6	Config: Add [[nodiscard]] to AddConfigChangedCallback ... Require callers of Config::AddConfigChangedCallback and CPUThreadConfigCallback::AddConfigChangedCallback to handle the returned ConfigChangedCallbackIDs to hopefully prevent future issues with callbacks getting called after their associated objects have been destroyed.	2025-04-25 16:04:12 -07:00
Dentomologist	45b9def42c	VideoConfig: Remove ConfigChangedCallback on shutdown	2025-04-25 16:00:43 -07:00
Dentomologist	d0dc8ae5e1	FreeLook: Remove ConfigChangedCallback on shutdown	2025-04-25 16:00:43 -07:00
Dentomologist	9db4067957	UICommon: Merge ConfigChangedCallbacks ... Use a single lambda as a callback which calls InitCustomPaths and RefreshConfig instead of having separate callbacks for each of them. This fixes the callback for InitCustomPaths not being removed on shutdown; the callback for the lambda (previously for RefreshConfig) is already removed in Shutdown().	2025-04-25 16:00:43 -07:00
Dentomologist	8724daf44e	Settings: Remove ConfigChangedCallback on shutdown	2025-04-25 16:00:19 -07:00
Dentomologist	9c40a7976b	AchievementManager: Remove ConfigChangedCallback on shutdown ... Prevent SetHardcoreMode from being called after m_client is set to nullptr. rc_client_set_hardcore_enabled() checks for nullptr so this didn't cause any problems, but better not to rely on that. Also prevents multiple SetHardcoreMode callbacks from piling up when repeatedly toggling Config::RA_ENABLED.	2025-04-25 15:29:29 -07:00
Dentomologist	e37a195192	MainWindow: Fix use-after-free during shutdown ... Remove ConfigChangedCallback in MainWindow's destructor to prevent the callback from accessing the destroyed MainWindow afterward. After MainWindow is destroyed UICommon::Shutdown calls LogManager::Shutdown which ultimately triggers any remaining callbacks. This resulted in calling MainWindow::OnHardcoreChanged, which crashed in debug builds and didn't have any obvious effect in release builds.	2025-04-25 15:29:29 -07:00
Dr. Dystopia	9868138c22	UCodes: Remove redundant qualifiers	2025-04-25 13:18:56 +02:00
Dr. Dystopia	066408326c	Core/HW/EXI: Remove redundant inline specifiers	2025-04-25 12:03:52 +02:00
Dr. Dystopia	50ca32352f	Core/HW/GCMemcard: Make variables constant	2025-04-25 11:35:59 +02:00
Tilka	805307f432	Merge pull request #13451 from vyuuui/numeric_labels ... Add numeric label support to assembler	2025-04-25 01:56:43 +01:00
Tilka	fe307a06c6	Merge pull request #13476 from jordan-woyak/sdl-header ... InputCommon: Move SDL Device class into its own cpp/h files.	2025-04-25 01:49:52 +01:00
Tilka	5523b9a01b	Merge pull request #13487 from Dentomologist/performancemetrics_fix_window_arrangement ... PerformanceMetrics: Fix window arrangement	2025-04-25 01:40:58 +01:00
Tilka	50026ab795	Merge pull request #13497 from hoogmin/modernize_fs_path ... Core/Common/FileUtil.cpp: Use std path utility for automatic path separator handling.	2025-04-25 01:38:35 +01:00
Tillmann Karras	a6290caa2e	DSPHLE: set accelerator gain	2025-04-25 01:09:15 +01:00
Tillmann Karras	8412a7c336	DSPAccelerator: update comment (NFC)	2025-04-25 01:09:15 +01:00
Tillmann Karras	f0bacb826a	DSPAccelerator: rename MMIOPCMHalt to MMIOPCMNoInc	2025-04-25 01:09:15 +01:00
Tillmann Karras	7c7c179b44	DSP tests: update DSP MMIO labels	2025-04-25 00:51:46 +01:00
Tillmann Karras	05381c5b6d	Address Pokechu22's feedback	2025-04-25 00:51:46 +01:00
xperia64	cd77e682ca	Name gain shift/scaling better	2025-04-25 00:51:46 +01:00
xperia64	c460cafecf	Update ACDRAW/ACDSAMP reg names in DSPTables and DSPSpy tests	2025-04-25 00:51:46 +01:00
xperia64	d517fe25f1	Add accelerator input MMIO register, fix MMIO PCM modes	2025-04-25 00:51:45 +01:00
xperia64	14fadbbe56	ADPCM mode doesn't entirely die with larger accesses, gain is PCM only	2025-04-25 00:51:45 +01:00
xperia64	c7d8afc5a7	Use correct exceptions for d3 reads/writes	2025-04-25 00:51:45 +01:00
xperia64	0dd282f626	Fix DSPAcceleratorTest	2025-04-25 00:51:45 +01:00
xperia64	ac2fdefcb4	Refactor accelerator format as a bitfield, use gain/yn1/yn2 in PCM mode	2025-04-25 00:51:45 +01:00
xperia64	04c7c1a4a1	Rename accelerator accesses to 'raw' and 'sample'	2025-04-25 00:51:45 +01:00
xperia64	256d9f8702	Improve ReadD3 emulation	2025-04-25 00:51:45 +01:00
xperia64	bbc11edd7d	Rework WriteD3 based on hardware testing	2025-04-25 00:51:45 +01:00
Tillmann Karras	4d9dc1e1cd	GekkoDisassembler: standardize SPR names and add missing ones	2025-04-25 00:24:12 +01:00
Dr. Dystopia	ef8b9a0dcd	Core/HW/SI: Make variables constant	2025-04-24 17:01:12 +02:00
JMC47	8fa725d5e4	Merge pull request #13573 from tygyh/DolphinTool-Make-parameter-constant ... DolphinTool: Make parameter constant	2025-04-24 00:49:10 -04:00
JMC47	fc0aafca3b	Merge pull request #13577 from tygyh/UCodes-Make-functions-static ... UCodes: Make functions static	2025-04-24 00:48:46 -04:00
JMC47	f675048768	Merge pull request #13578 from tygyh/Core/HW-Remove-redundant-empty-lambda-parameter-lists ... Core/HW: Remove redundant empty lambda parameter lists	2025-04-24 00:48:28 -04:00
Jordan Woyak	1cea31c75a	Merge pull request #13580 from LillyJadeKatrin/retroachievements-de-bug-debug ... Fix debugger disabled bug	2025-04-23 23:28:19 -05:00
Jordan Woyak	3025cd472c	Merge pull request #13491 from JosJuice/oh0-removed-opened ... IOS: Remove from m_opened_devices in OH0::OnDeviceChange	2025-04-23 23:25:34 -05:00
LillyJadeKatrin	022bc3bf8d	Fix debugger disabled bug ... Fixing an oversight: this was causing the debugger to be disabled if achievements were disabled but hardcore mode was still enabled in the .ini. This fix properly checks for hardcore state via AchievementManager which takes both settings into account.	2025-04-23 22:57:35 -04:00
Sanjay Govind	8bb07bf3c4	LibusbDevice: Send wakeup command to Santroller devices	2025-04-24 12:09:41 +12:00
Admiral H. Curtiss	879a8889aa	Merge pull request #13431 from jordan-woyak/spsc-waiting ... Common: SPSCQueue cleanups and improvements.	2025-04-23 22:19:15 +02:00
Dr. Dystopia	564e7c3320	UCodes: Make functions static	2025-04-23 21:36:13 +02:00
Dr. Dystopia	467a568f60	Core/HW: Remove redundant empty lambda parameter lists	2025-04-23 21:32:09 +02:00
Dr. Dystopia	03a6fdcd85	DolphinTool: Make variables constant	2025-04-23 20:24:50 +02:00
JosJuice	bda1f379b7	IOS: Remove from m_opened_devices in OH0::OnDeviceChange ... I've been playing Rock Band 3 recently and have experienced a bug where sometimes if you disconnect and reconnect a USB microphone, the game won't pick up on it connecting, not even it you disconnect and reconnect it again. An investigation into what's going on inside Dolphin shows that when the game triggers a call to OH0::DeviceOpen after the device has been reinserted, Dolphin doesn't open the device because it's already present in m_opened_devices. Removing the device from m_opened_devices after calling OH0::TriggerHook in OH0::OnDeviceChange resolves this specific issue in my testing. Doing this matches us removing the device from m_opened_devices after calling OH0::TriggerHook in OH0::DeviceClose, but I haven't looked at exactly what real IOS does. I have been able to reproduce a much rarer issue that has the same symptoms on the surface but where OH0::DeviceOpen gets past its m_opened_devices check. I'm currently not sure what the cause of this remaining issue is.	2025-04-23 17:19:14 +02:00
Dr. Dystopia	fe657b9759	DolphinTool: Make parameter constant	2025-04-23 15:55:48 +02:00
Martino Fontana	e751235574	DolphinQt: Remove unused variables from AdvancedPane.h ... Small oversight from #13422.	2025-04-23 12:32:12 +02:00
Joshua Vandaële	bf554edfe0	linter: Add and apply new formatting rules ... New rules: `InsertNewlineAtEOF: true` `RemoveSemicolon: true` `RequiresClausePosition: WithPreceding`	2025-04-23 11:19:57 +02:00
Joshua Vandaële	2c54ee94c1	linter: Apply clang-format 19.1 formatting ... find ./Source/ -name '*.cpp' -o -name '*.h' | xargs clang-format-19 -i	2025-04-23 11:19:20 +02:00
JMC47	8f3483fdd4	Merge pull request #13565 from LillyJadeKatrin/retroachievements-end-of-memory-bug ... Fix memory bounds error in achievements dev	2025-04-23 01:01:47 -04:00
Jordan Woyak	af960651e8	Common: SPSCQueue cleanups and improvements.	2025-04-22 23:49:32 -05:00
Jordan Woyak	116bd3a031	Merge pull request #13382 from JoshuaVandaele/btadapterchoice ... Add a GUI option to select a bluetooth device	2025-04-22 22:05:30 -05:00
LillyJadeKatrin	8b610101bc	Fix memory bounds error in achievements dev ... This particular out of bounds error was causing every memory read at the far end of memory to return all zeroes.	2025-04-22 22:49:55 -04:00
Tilka	c4f65febf3	Merge pull request #13563 from Tilka/rcheevos ... Fix building with USE_RETRO_ACHIEVEMENTS=OFF	2025-04-23 03:27:15 +01:00
Tilka	871073eee2	Merge pull request #13564 from jordan-woyak/triforce_ipl-warning ... Core/Boot: Fix unused variable warning.	2025-04-23 03:26:48 +01:00
Jordan Woyak	31a3de819d	Merge pull request #13540 from tygyh/DiscIO-Remove-redundant-qualifiers ... DiscIO: Remove redundant qualifiers	2025-04-22 20:00:03 -05:00
Jordan Woyak	0fd090ce19	Merge pull request #13550 from Tilka/top_warnings ... IOS/Network: fix some warnings	2025-04-22 19:45:47 -05:00
Joshua Vandaële	4773a6f323	Add a GUI option to select a bluetooth device	2025-04-23 02:19:28 +02:00
JMC47	826625c7be	Merge pull request #13422 from jordan-woyak/adv-tooltips ... DolphinQt: Use tooltips on Advanced tab.	2025-04-22 19:27:21 -04:00
Jordan Woyak	00544e4dff	Core/Boot: Fix unused variable warning.	2025-04-22 18:19:32 -05:00
Tillmann Karras	609165b62b	Fix building with USE_RETRO_ACHIEVEMENTS=OFF	2025-04-22 23:45:40 +01:00
Tillmann Karras	f6d3f448d9	IOS/Network: fix -Wmissing-braces warnings	2025-04-22 23:36:01 +01:00
Jordan Woyak	ac76deaef0	Merge pull request #13529 from jordan-woyak/StateBuffer ... Core/State: Avoid unnecessarily value-initializing large buffers.	2025-04-22 16:30:51 -05:00
OatmealDome	da84a9f605	Merge pull request #13477 from OatmealDome/macos-11 ... CMakeLists: Bump minimum macOS to 11.0	2025-04-22 17:27:12 -04:00
Jordan Woyak	afee9a56e9	Merge pull request #13474 from JosJuice/rock-band-playstation ... IOS: Disguise Rock Band PlayStation USB devices as Wii equivalents	2025-04-22 16:02:16 -05:00
Jordan Woyak	9254a53397	Merge pull request #13490 from JosJuice/one-usb-scanner ... IOS: Only have one USB scanning thread	2025-04-22 16:01:18 -05:00
JMC47	fd8ce3ce80	Merge pull request #13555 from jordan-woyak/cubeb-default ... AudioCommon: Make cubeb sound backend default on Linux.	2025-04-22 12:07:43 -04:00
JosJuice	12010ebf78	Merge pull request #13557 from LillyJadeKatrin/pause-bugfix ... AchievementManager: Always allow pausing if game not loaded	2025-04-22 17:55:23 +02:00
Dr. Dystopia	ecafd8058f	DiscIO: Remove redundant qualifiers	2025-04-22 13:54:10 +02:00
Jordan Woyak	89873d6238	Merge pull request #13472 from tygyh/Use-values-function ... Core/NetPlayServer: Use std::views::values and std::views::keys functions	2025-04-22 02:25:46 -05:00
LillyJadeKatrin	d670c21c8e	Always allow pausing if game not loaded ... RetroAchievements disables pausing too frequently when running but there's no sense of doing this if RetroAchievements does not currently have a game running.	2025-04-21 22:38:09 -04:00
Jordan Woyak	1e8b668793	DVDInterface: Fix crash when playing wiiware.	2025-04-21 18:38:33 -05:00
Jordan Woyak	1fc6be7f80	AudioCommon: Make cubeb sound backend default on Linux.	2025-04-21 16:25:40 -05:00
JosJuice	e468e2359a	IOS: Only have one USBScanner ... Some games open two USB interfaces, e.g. /dev/usb/oh0 and /dev/usb/hid. This was causing us to run two scanning threads at once, using up more CPU time for scanning than we need to.	2025-04-21 21:57:49 +02:00
LillyJadeKatrin	8f12512d0d	Call AchievementManager CloseGame on load failures ... We have identified that a failed RetroAchievements game load (most easily done when closing a game before the server can finish responding) can leave data behind that causes problems. As such, refactored CloseGame to always delete data even if there wasn't a game loaded when it was called, and call it on the failure paths of LoadGameCallback.	2025-04-21 15:53:31 -04:00
JosJuice	920a44aec2	IOS: Diff device lists in USBHost instead of USBScanner ... Instead of having USBScanner create "hooks" as it scans for devices, let's have USBScanner present a list of devices to USBHost and have USBHost diff the new device list with its old device list to create the hook calls instead. This gets rid of some complex edge cases that the next commit otherwise would have to deal with, in particular regarding toggling determinism and adding new USBHosts to a USBScanner.	2025-04-21 21:25:36 +02:00
JosJuice	24fdcc1a0e	IOS: Add missing locking for USBHost::m_devices ... Note: After adding the missing locking of m_devices_mutex, I had to move the locking of m_hooks_mutex to avoid a random deadlock between the CPU thread and USB scanning thread. (Either that or I would have to lock m_devices_mutex before m_hooks_mutex.)	2025-04-21 21:25:35 +02:00
JosJuice	50a8ae9d90	IOS: Keep copy of m_devices in USBHost ... This gets rid of the ugly direct access to USBScanner::m_devices that was introduced by the previous commit. This also fixes a potential thread safety issue. USB_HIDv4::TriggerDeviceChangeReply loops through m_devices and calls GetDeviceEntry for each device. If USB_HIDv4::TriggerDeviceChangeReply is called after a new device is added to m_devices but before hooks are dispatched, GetDeviceEntry crashes, because the hook that's supposed to update m_device_ids hasn't run yet. With this commit, this issue can no longer happen, because USBHost::m_devices_mutex doesn't get unlocked in between updating m_devices and dispatching the hooks.	2025-04-21 21:25:35 +02:00
JosJuice	427e9c5ad2	IOS: Move USB scanning thread to new class USBScanner	2025-04-21 21:25:35 +02:00
JosJuice	c0c180bdc2	Merge pull request #13467 from JosJuice/profiler-thread-safety ... Common: Make Profiler thread safe	2025-04-21 20:19:47 +02:00
JMC47	258fc1b209	Merge pull request #12949 from LillyJadeKatrin/retroachievements-new-dev-branch ... RetroAchievements - Dev Branch Refactor	2025-04-21 14:08:40 -04:00
Dr. Dystopia	35fa32e254	Core/PowerPC/JitArm64: Replace zeroes in boolean context with false	2025-04-21 17:06:06 +02:00
Zopolis4	89fdc0b9e0	Fix Triforce GameINIs	2025-04-21 22:05:26 +10:00
Zopolis4	2238967d93	Add Triforce IPL hash	2025-04-21 22:05:25 +10:00
Zopolis4	660232a12c	Preliminary implementation of the Triforce Baseboard	2025-04-21 22:05:25 +10:00
Zopolis4	2baa09d5b4	Implement endian swapping and lazy decryption of Triforce DI commands	2025-04-21 22:05:25 +10:00
Zopolis4	8d94d25203	Implement Triforce ID parsing	2025-04-21 22:05:25 +10:00
Zopolis4	71f654cdc4	Add Triforce platform and preliminary boot.id parsing	2025-04-21 22:05:25 +10:00
Zopolis4	494e2c05c2	Adding support for detecting .bin images	2025-04-21 22:05:24 +10:00
OatmealDome	ec9fb08dab	MTLUtil: Remove availability check for iOS 13 ... My personal fork requires minimum iOS 14, so this is not required.	2025-04-21 00:24:58 -04:00
OatmealDome	65f42ee2d2	MTLUtil: Always use MSL 2.3 ... The minimum macOS (and minimum iOS on my personal fork) are enough to allow MSL 2.3 usage without availability checks.	2025-04-21 00:24:58 -04:00
OatmealDome	53b66be47d	MTLUtil: Remove availability checks for macOS 10.15 and iOS 13	2025-04-21 00:24:58 -04:00
OatmealDome	0bc33fb6df	MTLUtil: Remove availability check for macOS 10.15	2025-04-21 00:24:58 -04:00
OatmealDome	dc8865718e	MTLUtil: Remove availability check for macOS 11	2025-04-21 00:24:58 -04:00
OatmealDome	7213cdd439	MemoryUtil: Remove availability checks for macOS 11	2025-04-21 00:24:58 -04:00
Jordan Woyak	a517c9f862	CoreTiming: Move VISkip calculation into a separate function.	2025-04-20 22:01:06 -05:00
Jordan Woyak	7236d1539a	CoreTiming: Cleanups to avoid drift from cumulative rounding errors.	2025-04-20 22:01:01 -05:00
OatmealDome	bc3c3eb79a	Merge pull request #13524 from jordan-woyak/fix-gba-link ... SI: Fix GBA link by having a separate response for "error" and "no data".	2025-04-20 22:29:38 -04:00
Tilka	7e7b75c1e6	Merge pull request #13537 from tygyh/DiscIO-Make-variables-constexpr ... DiscIO: Make variables constexpr	2025-04-21 00:52:18 +01:00
Tilka	9504916f72	Merge pull request #13538 from tygyh/DiscIO-Use-default-to-define-a-trivial-destructor ... DiscIO: Use `= default` to define a trivial destructor	2025-04-20 22:32:12 +01:00
Tilka	0a52140145	Merge pull request #13549 from shuffle2/ucrtpatch ... remove ucrt compat patches	2025-04-20 22:24:57 +01:00
Tilka	45ed4b2be9	Merge pull request #13541 from tygyh/DiscIO-Remove-redundant-zero-initializers-in-aggregate-initializations ... DiscIO: Remove redundant zero initializers in aggregate initializations	2025-04-20 22:07:58 +01:00
Tilka	2adf3449f3	Merge pull request #13548 from shuffle2/http ... HttpRequest: remove some legacy code for windows < 8.1	2025-04-20 22:07:32 +01:00
Jordan Woyak	8d7d026da6	Merge pull request #13533 from tygyh/DiscIO-Make-classes-final ... DiscIO: Make classes final	2025-04-20 16:06:07 -05:00
Shawn Hoffman	2d1161150b	remove ucrt compat patches ... Dolphin has not supported a version of windows where these binaries exist for a while.	2025-04-20 12:50:10 -07:00
Shawn Hoffman	5dd896a7d9	HttpRequest: remove some legacy code for windows < 8.1	2025-04-20 11:46:09 -07:00
Dr. Dystopia	07ad189b4f	DiscIO: Pass parameters by constant reference	2025-04-20 08:26:09 +02:00
Jordan Woyak	ac3dbe2294	Core/State: Use UniqueBuffer instead of make_unique and std::vector for save state buffers.	2025-04-19 17:29:56 -05:00
Jordan Woyak	12dcd6c285	Common: Add UniqueBuffer and SharedBuffer templates.	2025-04-19 17:13:40 -05:00
Jordan Woyak	f78fa2e9f1	LinearDiskCache: Use make_unique_for_overwrite.	2025-04-19 17:13:40 -05:00
Dr. Dystopia	77b4270981	DiscIO: Remove redundant zero initializers in aggregate initializations	2025-04-19 22:04:50 +02:00
Dr. Dystopia	7123fcd19b	DiscIO: Use = default to define a trivial destructor	2025-04-19 17:43:18 +02:00
Dr. Dystopia	f6ba69f99a	DiscIO: Make variables constexpr	2025-04-19 17:17:02 +02:00
JosJuice	1ae0b23265	Merge pull request #13528 from jordan-woyak/win-cmake-fix ... Common/Timer: Change HANDLE to void* to avoid including Windows.h to fix cmake build.	2025-04-19 16:41:51 +02:00
JosJuice	49ebdaaae3	Merge pull request #13507 from JosJuice/time-played-game-id ... Core: Don't store game ID inside TimePlayed	2025-04-19 14:28:02 +02:00
Jordan Woyak	fda8afaf5c	SI: Fix GBA link by having a separate response for "error" and "no data".	2025-04-19 03:28:57 -05:00
Dr. Dystopia	301cc5ee63	DiscIO: Make classes final	2025-04-19 09:05:22 +02:00
Jordan Woyak	cb20959679	Common/Timer: Change HANDLE to void* to avoid including Windows.h to fix cmake build.	2025-04-18 21:50:15 -05:00
Jordan Woyak	056b0339be	Merge pull request #13496 from TryTwo/PR_GameSettings_Fix ... Game config settings: Show global value when no game setting exists.	2025-04-18 15:56:59 -05:00
LillyJadeKatrin	c55624702c	Allow RA Dev Tools for Unidentified Games ... Due to requests from RA Devs, updating the AchievementManager LoadGameCallback to still set MemoryPeeker (and set m_system) if the load game response is NO_GAME_LOADED, so that the memory inspector et al continue function properly on unidentified hashes. Without this, no memory is loaded and the memory inspector will show all zeroes.	2025-04-16 23:59:16 -04:00
LillyJadeKatrin	a96c935c1c	Added modified achievements confirmation ... Added a line to the close game confirmation dialog to tell the dev if there are unsaved modifications to the achievement assets.	2025-04-16 17:01:22 -04:00
LillyJadeKatrin	b9a93794ff	Added game title estimate for achievement development ... If the development system is started for a game with an unrecognized hash, RA_Integration opens a dialog for connecting the hash with a title. That dialog is prepopulated by the results of GameTitleEstimateHandler.	2025-04-16 17:01:22 -04:00
LillyJadeKatrin	ef612912a2	Handle local achievements ... Displays an additional message when an achievement unlocks that isn't on the site yet (either hasn't yet been uploaded or modified from remote) i.e. achievements the "player" is actively developing.	2025-04-16 17:01:21 -04:00
LillyJadeKatrin	fa782de15c	Add MemoryPoker for RAIntegration	2025-04-16 17:00:58 -04:00
Jordan Woyak	f8bf35e6f0	Merge pull request #13518 from tygyh/Fix-Partition-struct-comparison-operators ... DiscIO/Volume: Fix Partition struct comparison operators	2025-04-16 00:20:28 -05:00
Jordan Woyak	8bfde300f4	Merge pull request #13519 from tygyh/Replace-definitions-with-constant-expressions ... Replace definitions with constant expressions - Core/HW/EXI/BBA/TAP_Win32	2025-04-16 00:19:40 -05:00
OatmealDome	2af276d27e	MemArenaDarwin: Initialize all address variables passed to vm_map	2025-04-16 00:50:54 -04:00
Dr. Dystopia	c4f906bcd9	Replace definitions with constant expressions - Core/HW/EXI/BBA/TAP_Win32	2025-04-15 12:26:16 +02:00
Dr. Dystopia	3bb925c1c7	DiscIO/Volume: Fix Partition struct comparison operators	2025-04-15 12:18:23 +02:00
Dr. Dystopia	2397a3a915	Use range-based loops - Core VideoBackends	2025-04-14 21:49:08 +02:00
LillyJadeKatrin	90a4be4b36	Add RAIntegration event handler ... Some refactoring done to hardcore toggling so that it's more readily available for the toggle hardcore event.	2025-04-13 13:36:15 -04:00
LillyJadeKatrin	9caa02493d	Add RetroAchievements development menu ... When the menu exists, it replaces the Achievements action in the Tools menu.	2025-04-13 08:06:00 -04:00
LillyJadeKatrin	36c7e7f3c7	Load RA_Integration.DLL at init if present	2025-04-13 08:05:59 -04:00
LillyJadeKatrin	cab5bc5680	Update rcheevos submodule to newest master	2025-04-13 08:05:59 -04:00
LillyJadeKatrin	6ad267017c	Refactor AchievementBox to const pointer ... Not sure when or why this became necessary but it works.	2025-04-13 08:05:59 -04:00
Dentomologist	2c20d5dcd9	GameList: Ignore non-left double-clicks ... Don't start a game when a double-click is triggered by a mouse button other than the left button. Fixes https://bugs.dolphin-emu.org/issues/12272.	2025-04-12 16:17:04 -07:00
JosJuice	4f210df86a	Merge pull request #13489 from AdmiralCurtiss/translate-audio-backend ... DolphinQt/AudioPane: Fix Audio backend dropdown not using translated names	2025-04-12 17:59:42 +02:00
JMC47	bcddd78a89	Merge pull request #13500 from jordan-woyak/accel-gyro-any-mapping ... InputCommon: Activate IMU Accelerometer and Gyroscope mappings when any direction has a bound input.	2025-04-12 11:47:38 -04:00
JosJuice	d194e69bbd	Core: Don't store game ID inside TimePlayed ... When you use TimePlayed, you have to provide a game ID either when creating the object or when calling GetTimePlayed on it. If you don't provide a game ID when creating the object, function calls that don't take a game ID will silently fail, except for Reload. This isn't very obvious, and there's no strong benefit to storing the game ID inside TimePlayed anyway (it just lets TimePlayed skip calling EscapeFileName), so this commit removes the TimePlayed constructor that takes a game ID and instead makes the functions that need game IDs always take a game ID argument.	2025-04-12 15:20:49 +02:00
JMC47	5285b1168a	Merge pull request #13503 from sepalani/ip-top-perf ... IP/Top: Fix performance regression in GetInterfaceOpt	2025-04-11 18:56:35 -04:00
Sepalani	03451f2bc9	IP/Top: Fix performance regression in GetInterfaceOpt	2025-04-12 01:38:00 +04:00
Jordan Woyak	87beb7d67b	InputCommon: Activate IMU Accelerometer and Gyroscope when any direction has a bound input.	2025-04-10 15:55:49 -05:00
JMC47	fc0179c1ea	Merge pull request #13498 from jordan-woyak/immxfb-dualcore-todo ... BPStructs: Add TODO for unsafe usage of GetTicks.	2025-04-09 23:20:35 -04:00
Jordan Woyak	4aa056dd4d	BPStructs: Add TODO for unsafe usage of GetTicks.	2025-04-08 19:58:31 -05:00
Javier Martinez	7ca8dc3767	Use std path utility for automatic path seperator handling. ... It was being done manually, which a TODO comment advised against. Using generic_string() from std::filesystem::path solves this. Fix encoding issue using generic_wstring instead.	2025-04-08 16:54:11 -04:00
JMC47	01363572cb	Merge pull request #13483 from Sam-Belliveau/fixed_playback_speed ... Use Doubles for Sample Rate Conversion	2025-04-08 13:45:12 -04:00
TryTwo	91380258a1	GameConfig Settings: If no game setting exists for a certain option, then show the global setting value. Previously showed the default value if the game setting didn't exist.	2025-04-07 20:41:46 -07:00
JMC47	ee27f03a43	Merge pull request #13439 from jordan-woyak/perf-marker ... Core: Move CountPerformanceMarker to VideoInterface to eliminate a Throttle call. PerformanceMetrics: Fixes/Cleanups.	2025-04-07 17:57:56 -04:00
Admiral H. Curtiss	b306d00d5d	DolphinQt/AudioPane: Fix Audio backend dropdown not using translated names	2025-04-06 05:09:23 +02:00
Dentomologist	ec49ea5be3	PerformanceMetrics: Fix window arrangement ... Fix overlays stacking on top of each other or not moving to the edge of the screen when enabling or disabling overlays while emulation is active. This change only applies when Config::GFX_MOVABLE_PERFORMANCE_METRICS is False.	2025-04-05 14:22:17 -07:00
Sam Belliveau	74e752ed9c	Mixer: Use Doubles for Sample Rate Conversion.	2025-04-05 13:46:37 -05:00
Jordan Woyak	06afa0036a	CoreTiming: Fix Precision Frame Timing in Dual Core mode on Windows.	2025-04-04 19:13:53 -05:00
Jordan Woyak	e0e53f3235	Common/Timer: Use YieldProcessor on Windows.	2025-04-03 15:48:51 -05:00
Jordan Woyak	7dc27753e2	CoreTiming: Add a setting to use Common::PrecisionTimer.	2025-04-03 15:48:51 -05:00
Jordan Woyak	e5c8935acc	Common: Create a PrecisionTimer class.	2025-04-03 15:48:51 -05:00
Admiral H. Curtiss	dadbd2f9fb	Merge pull request #13479 from iwubcode/mali_draw_fix ... VideoCommon: fix a mali draw bug that causes crashes in some games	2025-04-03 21:55:41 +02:00
Jordan Woyak	af1f07207f	VideoInterface: Throttle for VBlank only when necessary.	2025-04-02 23:24:03 -05:00
Jordan Woyak	c42dab6388	Core: Move CountPerformanceMarker to VideoInterface to eliminate a Throttle call. PerformanceMetrics: Fixes/Cleanups.	2025-04-02 23:23:51 -05:00
JMC47	61ab662733	Merge pull request #13424 from Sam-Belliveau/granule-performance-improvements ... AudioCommon: Increased Granule Synthesis Performance	2025-04-02 22:44:14 -04:00
Dr. Dystopia	ebc9c8492d	Use std::views::values and std::views::keys functions - NetPlayServer	2025-04-02 20:06:10 +02:00
iwubcode	ec36fce7c6	VideoCommon: fix a mali bug by moving the perf queries back to being close to the draw call, having them apart seems to cause errors on some devices	2025-04-01 18:32:42 -05:00
Sam Belliveau	877864c23a	Improve Performance of Granular Buffering + User Adjustable Buffer Size	2025-04-01 18:17:21 -04:00
Jordan Woyak	33a7283d3b	VideoBackends/Metal: Fix anisotropic filtering handling.	2025-04-01 15:09:21 -05:00
JosJuice	01a7732d50	IOS: Disguise Rock Band PlayStation USB devices as Wii equivalents ... This lets you use PS3 Rock Band controllers with Wii Rock Band and Guitar Hero games. A normal user will probably never have any reason to disable this behavior, but I figured maybe there's some person out there who would like to disable it. (For instance, I know there's a mod for RB3 that's trying to implement the same kind of cross-console controller compatibility, and that can only be tested if the behavior I'm adding is disabled.) So the behavior is controlled by an INI-only setting.	2025-03-31 21:24:25 +02:00
Jordan Woyak	17c994df2a	InputCommon: Move SDL Device class into its own cpp/h files.	2025-03-30 23:23:06 -05:00
Jordan Woyak	4533605c03	DolphinQt: Update tooltips for ImmediateXFB, VBISkip, SkipPresentingDuplicateFrames interaction clarity.	2025-03-30 20:55:26 -05:00
Jordan Woyak	920f940ad0	DolphinQt: Don't toggle GFX_HACK_SKIP_DUPLICATE_XFBS when GFX_HACK_IMMEDIATE_XFB or GFX_HACK_VI_SKIP are enabled.	2025-03-30 20:51:20 -05:00
Admiral H. Curtiss	1b85da9b85	Merge pull request #13471 from Nitch2024/CTRL+G ... [Debugger] CTRL+G support in code and memory view	2025-03-30 15:39:54 +02:00
Nitch2024	1b87ea83e6	[Debugger] CTRL+G support in code and memory view	2025-03-29 12:43:15 -07:00
JosJuice	957265ba52	Common: Make Profiler thread safe	2025-03-29 15:05:02 +01:00
JMC47	9819d66a47	Merge pull request #13221 from mitaclaw/nrvo-fails-1 ... GCC: Remedy NRVO Fails	2025-03-29 03:26:46 -04:00
JMC47	f00b7d39f0	Merge pull request #13465 from TryTwo/PR_Bugfix ... AudioPanel Bugfix	2025-03-28 19:56:36 -04:00
TryTwo	efd993f382	AudioPanel bugfix: Forgot to wrap an optional slider in a conditional.	2025-03-28 15:50:24 -07:00
JMC47	4c727a84c5	Merge pull request #13456 from jordan-woyak/mapping-window-blank-square-fix ... DolphinQt: Fix blank square in MappingWindow's top-left corner.	2025-03-28 18:44:32 -04:00
JMC47	932b4abdcf	Merge pull request #13457 from jordan-woyak/efb-access-fix ... VideoCommon: Fix out-of-bounds and disabled EFB access.	2025-03-28 18:43:57 -04:00
JMC47	7d794897c4	Merge pull request #13434 from JosJuice/android-non-blocking-input-detection ... Android: Don't use separate thread for MotionAlertDialog	2025-03-28 18:25:04 -04:00
JMC47	e0032b3e2c	Merge pull request #13122 from TryTwo/PR_Audio_Configs ... AudioPanel: Refactor to use Config system.	2025-03-28 14:52:54 -04:00
Joshua Vandaële	3a1a60d4f8	Fix shadowed variable warnings and missing declarations ... - PPCSymbolDB: Resolve shadowed variable warnings - PerformanceMetrics: Resolve shadowed variable warnings - SWEfbInterface: Add missing declarations	2025-03-27 21:48:08 +01:00
Tilka	662cfa38c2	Merge pull request #13460 from jordan-woyak/play-time-tracker-thread-name ... Core: Name the play time tracker thread.	2025-03-27 17:02:36 +00:00
JMC47	cb24821dcc	Merge pull request #13217 from cristian64/extract_gecko_creator_name ... DolphinQt: Extract creator name from code name in Gecko codes.	2025-03-27 12:26:47 -04:00
Jordan Woyak	ebd879cb30	Core: Name the play time tracker thread.	2025-03-27 01:38:55 -05:00
TryTwo	e5608c6ca5	ConfigControl fix: Add invalid index check to ConfigComplexChoice. Resolve with a default index that can be set. ... If more control is needed, it could be changed to allow multiple states to point to the same index.	2025-03-26 13:15:57 -07:00
TryTwo	896b4bb1fa	AudioPanel: Refactor to use Config system. Some options were changed to a different format, for easier compatibility. ... Removed VolumeChanged signal, as ConfigChanged will trigger what is needed. Only applies UpdateSoundStream to things that can change during emulation. Settings::SetVolume might no longer be used, but left it in.	2025-03-26 12:26:01 -07:00
tygyh	1ecd6fbc9b	Move variables to inner scope	2025-03-26 18:21:46 +01:00
Jordan Woyak	e351f03cdf	VideoCommon: Fix out-of-bounds and disabled EFB access.	2025-03-26 01:23:16 -05:00
Jordan Woyak	849d8b7dae	DolphinQt: Fix blank square in MappingWindow's top-left corner.	2025-03-25 20:52:29 -05:00
JMC47	1981f22228	Merge pull request #13433 from iwubcode/update_min_win10 ... Update our minimum windows 10 version to 1903 and reinstate code that depends on it	2025-03-25 18:30:15 -04:00
Dr. Dystopia	d2cc6760a0	Use Common::ToUnderlying	2025-03-25 21:25:46 +01:00
JMC47	eb84b0fb9b	Merge pull request #13442 from TryTwo/PR_CodeWidget_Layout_Tweak ... Debugger CodeWidget: Small layout tweak	2025-03-25 13:19:02 -04:00
vyuuui	e34907025d	Add numeric label support to assembler	2025-03-24 18:59:32 -07:00
cristian64	6d8ba94e4c	DolphinQt: Extract creator name from code name in Gecko codes. ... Gecko codes in Dolphin feature a dedicated field for the creator of the cheat code. When saved into the INI file, the code name and the creator name are concatenated, and then inserted in the `[Gecko]` section: ```ini [Gecko] $<cheat code name> [<creator>] <code line 1> <code line 2> <code line 3> <...> $<other cheat code name> [<creator>] <code line 1> <code line 2> <code line 3> <...> ``` On the other hand, enabled codes are listed under the `[Gecko_Enabled]` section, but in this case the creator name is omitted from the line: ```ini [Gecko_Enabled] $<cheat code name> $<other cheat code name> ``` Having the creator name in the `[Gecko]` section but not in the `[Gecko_Enabled]` section is arguably not ideal, but this is legacy behavior in Dolphin. The **Cheat Code Editor** dialog is not acknowledging this subtle behavior in Dolphin: the cheat code name and the creator name *can* be both inserted in the name field. This issue manifests as an inconsistent state where a Gecko code that *appears* to be enabled has no effect when the game is launched. As part of this fix, the creator name (if present) is now moved into the dedicated creator field before the code is stored internally. Test plan: - Right-click on any game and open the **Properties** dialog. - Switch to the **Gecko Codes** tab. - Press the **Add New Code...** button. - In the **Cheat Code Editor** dialog: - Enter `This is a test [Jane Doe]` in the **Name:** field. - Enter `01234567 00000000` in the **Code:** field. - Press **Save**. - Observe that the newly added code is now in the list, and *appears* to be enabled. - Close the **Properties** dialog. - Right-click on the same game and open the **Properties** dialog again. **Without** the fix, the newly added code, while still on the list, has been inadvertently disabled (it was never really enabled!). **With** the fix, the newly added code is the list and remains enabled. This fixes https://bugs.dolphin-emu.org/issues/13695.	2025-03-23 21:37:23 +00:00
Dentomologist	0b128badae	DolphinQt: Fix unresponsive hotkeys during framestep overlay move ... Fix the following bug: * Have a moveable ImGui overlay enabled, such as the Statistics window. * Pause the game. * Click and hold on the overlay's title bar as if you were going to move it. Because the screen isn't updating while the game is paused, you won't be able to actually move the overlay. * Press the Frame Advance hotkey several times until it stops responding. At this point emulation hotkeys are no longer responsive. This can be resolved by selecting Play from the toolbar or menu, or selecting Frame Advance from the menu a couple times, but it's annoying and not obvious what's gone wrong or how to fix it. Why the bug is happening: * Doing a framestep while clicking on the overlay title bar causes ImGui to set IO.WantCaptureKeyboard to true, indicating that ImGui is requesting Dolphin ignore any keyboard events while the overlay is being interacted with. * Dolphin complies with this request, causing Host_UIBlocksControllerState to return true and thus setting the input gate to ignore input. * IO.WantCaptureKeyboard is only updated when ImGui::NewFrame() is called, which only happens at the end of each present. It thus remains true indefinitely since the game paused after the last framestep, and so Dolphin ignores any hotkeys such as the framestep or play keys. The fix: Ignore IO.WantCaptureKeyboard when the game is paused. ImGui can't meaningfully capture input anyway when the game is paused, so this shouldn't cause any problems elsewhere. Once async presentation is implemented we'll want to revert this change, both because it'll become unnecessary and because ImGui will be able to do stuff while paused and so suppressing emulation hotkeys will actually be useful.	2025-03-23 14:36:58 -07:00
JosJuice	516c1314d2	Android: Don't use separate thread for MotionAlertDialog ... This is an Android continuation of bc95c00. We now call InputDetector::Update immediately after receiving an input event from Android instead of periodically calling it in a sleep loop. This improves detection of very short inputs, which are especially likely to occur for volume buttons on phones (or at least on my phone) if you don't intentionally keep them held down.	2025-03-23 21:39:04 +01:00
JMC47	ad3650abfc	Merge pull request #13093 from mitaclaw/ranges-modernization-4-projection ... Ranges Algorithms Modernization - Projection	2025-03-23 15:56:13 -04:00
JMC47	1515cf6ccd	Merge pull request #13447 from JosJuice/bba-panic-tr ... EXI: Make HLE BBA panic alerts translatable	2025-03-23 15:22:11 -04:00
JMC47	cef4d8fb76	Merge pull request #13432 from iwubcode/custom_pixel_fragment ... VideoCommon: move to a 'process_fragment()' function to simplify custom shaders	2025-03-23 15:21:48 -04:00
JMC47	f50d2ee86c	Merge pull request #13425 from jordan-woyak/after-present-cleanup ... Fix performance statistics when Skip Duplicate Frames is turned off.	2025-03-23 15:21:31 -04:00
JMC47	28f1beeca8	Merge pull request #13398 from jordan-woyak/perf-tracker ... PerformanceTracker: Eliminate mutex. General cleanups.	2025-03-23 15:21:11 -04:00
JMC47	178462e10f	Merge pull request #13385 from Tilka/sp2_ad16 ... Fix AD16 and make SP2 configurable	2025-03-23 15:20:45 -04:00
JMC47	9b0471532c	Merge pull request #13368 from jordan-woyak/anisotropic-filtering ... Use Game Requested Anisotropic Filtering	2025-03-23 15:17:24 -04:00
JMC47	2da255d8cd	Merge pull request #13311 from iwubcode/dynamic_input_textures_reduce_image_writes ... Core / DolphinQt / InputCommon: reduce the number disk writes when using DynamicInputTextures	2025-03-23 15:12:28 -04:00
JMC47	e93f0de8a4	Merge pull request #13295 from jordan-woyak/controller-emu-cleanup ... InputCommon/ControllerEmu: Break out functionality of EmulatedController to eliminate redundant members.	2025-03-23 15:12:06 -04:00
JosJuice	c1990bc687	EXI: Make HLE BBA panic alerts translatable ... Also rewording the messages to make them clearer and fix typos.	2025-03-23 15:43:16 +01:00
JosJuice	303366b1ce	PowerPC: Add RAII handling for breakpoint updates ... bbf72e7 made a change where you can pass `false` to certain MemChecks functions to get them to skip performing an "update" step. It was then up to the caller to call the Update function later. This commit changes the implementation so that, instead of the caller passing in a boolean that controls whether a function calls Update, the function now returns an object that on destruction will call Update. Callers that are fine with Update being called right away can skip storing the object in a variable and thereby call Update immediately, and callers that want to call Update later can keep the object around. This new design reduces the risk that someone will forget calling Update.	2025-03-23 15:29:19 +01:00
iwubcode	8e253518e6	VideoCommon: move to a 'process_fragment()' function to simplify custom shaders and provide a direct override of the tev stage logic	2025-03-22 15:22:00 -05:00
iwubcode	e18d98d4fc	Core: properly distinguish between ES title switches (Wii titles) and normal loading (GC, also called for Wii..); update config for ES title change, generate textures for both situations	2025-03-22 14:55:20 -05:00
iwubcode	d03f9032c1	Core / DolphinQt / InputCommon: reduce the number disk writes when using DynamicInputTextures	2025-03-22 14:53:02 -05:00
TryTwo	b0867c1602	CodeWidget: Layout tweak. Give left-side widgets more vertical space by moving the address bar out of the way. Align things better.	2025-03-21 09:55:52 -07:00
Jordan Woyak	3bf2de369a	WiimoteEmu: Eliminate dynamic memory allocation in speaker data decoding.	2025-03-18 03:12:50 -05:00
Jordan Woyak	561aee7707	Config: Expose Default and 1x Anisotropic Filtering setting.	2025-03-17 20:46:24 -05:00
Jordan Woyak	4b711e1e0a	DolphinQt: Allow ConfigComplexChoice to handle DefaultState values.	2025-03-17 20:46:24 -05:00
Jordan Woyak	ba1bf6959e	Config: Allow passing a DefaultState object to Set functions to delete keys.	2025-03-17 20:46:24 -05:00
Jordan Woyak	137d1375d4	Enable game-requested anisotropic filtering in Metal backend.	2025-03-17 20:46:24 -05:00
Pokechu22	79a1e480ca	Enable anisotropic filtering when the game requests it	2025-03-17 20:46:19 -05:00
Jordan Woyak	a7d1cac8ad	Core: Call PerformanceMetrics::CountFrame regardless of PresentReason.	2025-03-17 17:24:08 -05:00
JosJuice	0299540209	Merge pull request #13397 from jordan-woyak/perf-metrics ... PerformanceMetrics: Eliminated a mutex. Code cleanups.	2025-03-17 23:20:41 +01:00