From f1a639b12bcbdf59fbdad06d68efac00a65899b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joshua=20Vanda=C3=ABle?= Date: Wed, 15 Jul 2026 15:24:48 +0200 Subject: [PATCH] CWDemangler: Resolve missing-declarations warnings --- Source/Core/Common/CWDemangler.cpp | 4 ++-- Source/UnitTests/Common/CWDemanglerTest.cpp | 21 +++++++++++---------- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/Source/Core/Common/CWDemangler.cpp b/Source/Core/Common/CWDemangler.cpp index 8b4d700c2a..fd9503a111 100644 --- a/Source/Core/Common/CWDemangler.cpp +++ b/Source/Core/Common/CWDemangler.cpp @@ -111,7 +111,7 @@ static std::optional find_split(std::string_view s, bool special, return std::nullopt; } -ParseQualifiersResult parse_qualifiers(std::string_view str) +static ParseQualifiersResult parse_qualifiers(std::string_view str) { std::string pre; std::string post; @@ -171,7 +171,7 @@ ParseQualifiersResult parse_qualifiers(std::string_view str) return {pre, post, str}; } -std::optional parse_digits(std::string_view str) +static std::optional parse_digits(std::string_view str) { if (str.empty()) return std::nullopt; diff --git a/Source/UnitTests/Common/CWDemanglerTest.cpp b/Source/UnitTests/Common/CWDemanglerTest.cpp index 7320e48472..6bd50caa0a 100644 --- a/Source/UnitTests/Common/CWDemanglerTest.cpp +++ b/Source/UnitTests/Common/CWDemanglerTest.cpp @@ -7,13 +7,13 @@ #include #include #include -#include #include "Common/CWDemangler.h" using namespace CWDemangler; -void DoDemangleTemplateArgsTest(std::string mangled, std::string name, std::string template_args) +static void DoDemangleTemplateArgsTest(std::string mangled, std::string name, + std::string template_args) { DemangleOptions options = DemangleOptions(); @@ -28,7 +28,7 @@ void DoDemangleTemplateArgsTest(std::string mangled, std::string name, std::stri } } -void DoDemangleNameTest(std::string mangled, std::string name, std::string full_name) +static void DoDemangleNameTest(std::string mangled, std::string name, std::string full_name) { DemangleOptions options = DemangleOptions(); @@ -44,7 +44,8 @@ void DoDemangleNameTest(std::string mangled, std::string name, std::string full_ } } -void DoDemangleQualifiedNameTest(std::string mangled, std::string base_name, std::string full_name) +static void DoDemangleQualifiedNameTest(std::string mangled, std::string base_name, + std::string full_name) { DemangleOptions options = DemangleOptions(); @@ -60,8 +61,8 @@ void DoDemangleQualifiedNameTest(std::string mangled, std::string base_name, std } } -void DoDemangleArgTest(std::string mangled, std::string type_pre, std::string type_post, - std::string remainder) +static void DoDemangleArgTest(std::string mangled, std::string type_pre, std::string type_post, + std::string remainder) { DemangleOptions options = DemangleOptions(); @@ -77,7 +78,7 @@ void DoDemangleArgTest(std::string mangled, std::string type_pre, std::string ty } } -void DoDemangleFunctionArgsTest(std::string mangled, std::string args, std::string remainder) +static void DoDemangleFunctionArgsTest(std::string mangled, std::string args, std::string remainder) { DemangleOptions options = DemangleOptions(); @@ -92,7 +93,7 @@ void DoDemangleFunctionArgsTest(std::string mangled, std::string args, std::stri } } -void DoDemangleTest(std::string mangled, std::string demangled) +static void DoDemangleTest(std::string mangled, std::string demangled) { DemangleOptions options = DemangleOptions(); @@ -104,8 +105,8 @@ void DoDemangleTest(std::string mangled, std::string demangled) EXPECT_EQ(result, expected); } -void DoDemangleOptionsTest(bool omit_empty_params, bool mw_extensions, std::string mangled, - std::string demangled) +static void DoDemangleOptionsTest(bool omit_empty_params, bool mw_extensions, std::string mangled, + std::string demangled) { DemangleOptions options = DemangleOptions(omit_empty_params, mw_extensions);