From 99531cf5098d71730b36147fce7da1b80fd4ba39 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Wed, 1 Apr 2026 08:17:13 +0200 Subject: [PATCH] Don't call OpenModeToAndroid in GBACore `OpenModeToAndroid("r")` is conceptually wrong, since we're opening a binary file. It should be either `OpenModeToAndroid("rb")` or just `"r"`. But either way it evaluates to `"r"`, so this doesn't affect behavior. --- Source/Core/Core/HW/GBACore.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/HW/GBACore.cpp b/Source/Core/Core/HW/GBACore.cpp index 2226610d35..a04f38a8f8 100644 --- a/Source/Core/Core/HW/GBACore.cpp +++ b/Source/Core/Core/HW/GBACore.cpp @@ -134,7 +134,7 @@ static VFile* OpenReadOnlyFile(const char* path) { #ifdef ANDROID if (IsPathAndroidContent(path)) - return VFileFromFD(OpenAndroidContent(path, OpenModeToAndroid("r"))); + return VFileFromFD(OpenAndroidContent(path, "r")); #endif return VFileOpen(path, O_RDONLY); }