Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-04-26 01:56:34 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Android: Add SAF support for GBA ROM and BIOS files

Browse Source 
SAF for save files is a huge can of worms because they're managed in a
more complicated way than asking the user to select an existing file,
so I won't be touching save files for now.
This commit is contained in:
JosJuice 2026-03-30 21:37:34 +02:00 committed by Jordan Woyak
parent 606bcbe3ed
commit c542279595
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Externals/mGBA/CMakeLists.txt vendored
View File

@ -11,6 +11,7 @@ if(NOT MSVC)
endif()
if(ANDROID)
target_compile_definitions(mgba PUBLIC ENABLE_VFS_FD)
target_compile_definitions(mgba PRIVATE -Dfutimes=futimens)
endif()

17
Source/Core/Core/HW/GBACore.cpp
View File

@ -39,6 +39,10 @@
#include "Core/NetPlayProto.h"
#include "Core/System.h"
#ifdef ANDROID
#include "jni/AndroidCommon/AndroidCommon.h"
#endif
namespace HW::GBA
{
namespace
@ -126,6 +130,15 @@ static VFile* OpenROM_Zip(const char* path)
return vf;
}
static VFile* OpenReadOnlyFile(const char* path)
{
#ifdef ANDROID
if (IsPathAndroidContent(path))
return VFileFromFD(OpenAndroidContent(path, OpenModeToAndroid("r")));
#endif
return VFileOpen(path, O_RDONLY);
}
static VFile* OpenROM(const char* rom_path)
{
VFile* vf{};
@ -134,7 +147,7 @@ static VFile* OpenROM(const char* rom_path)
if (!vf)
vf = OpenROM_Zip(rom_path);
if (!vf)
vf = VFileOpen(rom_path, O_RDONLY);
vf = OpenReadOnlyFile(rom_path);
if (!vf)
return nullptr;
@ -338,7 +351,7 @@ void Core::EReaderQueueCard(std::string_view card_path)
bool Core::LoadBIOS(const char* bios_path)
{
VFile* vf = VFileOpen(bios_path, O_RDONLY);
VFile* vf = OpenReadOnlyFile(bios_path);
if (!vf)
{
ERROR_LOG_FMT(CORE, "GBA{0} failed to open the BIOS in {1}", m_device_number + 1, bios_path);