Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-20 01:15:08 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve usage of std::move and const references parameters

Browse Source 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Source/Core/VideoBackends/OGL/OGLPipeline.cpp
View File

@@ -3,6 +3,8 @@
#include "VideoBackends/OGL/OGLPipeline.h"
#include <utility>
#include "VideoBackends/OGL/OGLShader.h"
#include "VideoBackends/OGL/OGLVertexManager.h"
#include "VideoBackends/OGL/ProgramShaderCache.h"
@@ -27,12 +29,12 @@ static GLenum MapToGLPrimitive(PrimitiveType primitive_type)
}
}
OGLPipeline::OGLPipeline(const AbstractPipelineConfig& config, const GLVertexFormat* vertex_format,
const RasterizationState& rasterization_state,
const DepthState& depth_state, const BlendingState& blending_state,
PipelineProgram* program, GLuint gl_primitive)
RasterizationState rasterization_state, DepthState depth_state,
BlendingState blending_state, PipelineProgram* program,
GLuint gl_primitive)
: AbstractPipeline(config), m_vertex_format(vertex_format),
m_rasterization_state(rasterization_state), m_depth_state(depth_state),
m_blending_state(blending_state), m_program(program), m_gl_primitive(gl_primitive)
m_rasterization_state(std::move(rasterization_state)), m_depth_state(std::move(depth_state)),
m_blending_state(std::move(blending_state)), m_program(program), m_gl_primitive(gl_primitive)
{
}