Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-18 00:07:30 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve usage of std::move and const references parameters

Browse Source 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp
View File

@@ -4,6 +4,7 @@
#include "InputCommon/ControllerEmu/ControlGroup/Buttons.h"
#include <string>
#include <utility>
namespace ControllerEmu
{
@@ -11,8 +12,8 @@ Buttons::Buttons(const std::string& name_) : Buttons(name_, name_)
{
}
Buttons::Buttons(const std::string& ini_name, const std::string& group_name)
: ControlGroup(ini_name, group_name, GroupType::Buttons)
Buttons::Buttons(std::string ini_name, std::string group_name)
: ControlGroup(std::move(ini_name), std::move(group_name), GroupType::Buttons)
{
}

2
Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.h
View File

@@ -15,7 +15,7 @@ class Buttons : public ControlGroup
{
public:
explicit Buttons(const std::string& name_);
Buttons(const std::string& ini_name, const std::string& group_name);
Buttons(std::string ini_name, std::string group_name);
template <typename C>
void GetState(C* const buttons, const C* bitmasks) const

3
Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.cpp
View File

@@ -13,8 +13,7 @@
namespace ControllerEmu
{
ModifySettingsButton::ModifySettingsButton(std::string button_name)
: Buttons(std::move(button_name))
ModifySettingsButton::ModifySettingsButton(const std::string& button_name) : Buttons(button_name)
{
}

2
Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h
View File

@@ -13,7 +13,7 @@ namespace ControllerEmu
class ModifySettingsButton : public Buttons
{
public:
explicit ModifySettingsButton(std::string button_name);
explicit ModifySettingsButton(const std::string& button_name);
void AddInput(std::string button_name, bool toggle = false);